• Type: Task
• Resolution: Fixed
• Priority: Minor
• Component/s: build-timeout-plugin
• Labels:

  None

[JENKINS-29357] Fix findbugs issue in build-timeout-plugin

ikedam created issue - 2015-07-11 00:32

Collapse comment: SCM/JIRA link daemon added a comment - 2015-07-18 04:34

SCM/JIRA link daemon added a comment - 2015-07-18 04:34

Code changed in jenkins
User: ikedam
Path:
pom.xml
http://jenkins-ci.org/commit/build-timeout-plugin/a70b00894b8b57867bf439c2922361e661c216c0
Log:
JENKINS-29357 Specifies source encodings explicitly to have findbugs not fail on non-english locale.

Expand comment: SCM/JIRA link daemon added a comment - 2015-07-18 04:34

SCM/JIRA link daemon added a comment - 2015-07-18 04:34 Code changed in jenkins User: ikedam Path: pom.xml http://jenkins-ci.org/commit/build-timeout-plugin/a70b00894b8b57867bf439c2922361e661c216c0 Log: JENKINS-29357 Specifies source encodings explicitly to have findbugs not fail on non-english locale.

Collapse comment: SCM/JIRA link daemon added a comment - 2015-07-18 04:34

SCM/JIRA link daemon added a comment - 2015-07-18 04:34

Code changed in jenkins
User: ikedam
Path:
src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java
src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java
http://jenkins-ci.org/commit/build-timeout-plugin/7d5a730be225aed670441ee80d22c0f84e9bd818
Log:
[FIXED JENKINS-29357] Fixed findbugs warnings in DeadlineTimeOutStrategy. Mainly the issue about thread-safeness of SimpleDateFormatter.

Expand comment: SCM/JIRA link daemon added a comment - 2015-07-18 04:34

SCM/JIRA link daemon added a comment - 2015-07-18 04:34 Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/7d5a730be225aed670441ee80d22c0f84e9bd818 Log: [FIXED JENKINS-29357] Fixed findbugs warnings in DeadlineTimeOutStrategy. Mainly the issue about thread-safeness of SimpleDateFormatter.

SCM/JIRA link daemon made changes - 2015-07-18 04:34

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

Collapse comment: SCM/JIRA link daemon added a comment - 2015-07-18 04:34

SCM/JIRA link daemon added a comment - 2015-07-18 04:34

Code changed in jenkins
User: ikedam
Path:
pom.xml
src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java
src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java
http://jenkins-ci.org/commit/build-timeout-plugin/c3156ed8d385f65c8ad585d3139577320920b523
Log:
Merge pull request #42 from ikedam/feature/JENKINS-29357_FixFindBugsWarnings

JENKINS-29357 Fixed findbugs warnings in DeadlineTimeoutStrategy

Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/86b154b96544...c3156ed8d385

Expand comment: SCM/JIRA link daemon added a comment - 2015-07-18 04:34

SCM/JIRA link daemon added a comment - 2015-07-18 04:34 Code changed in jenkins User: ikedam Path: pom.xml src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/c3156ed8d385f65c8ad585d3139577320920b523 Log: Merge pull request #42 from ikedam/feature/ JENKINS-29357 _FixFindBugsWarnings JENKINS-29357 Fixed findbugs warnings in DeadlineTimeoutStrategy Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/86b154b96544...c3156ed8d385

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

Original: JNJira [ 164231 ]

New: JNJira + In-Review [ 197454 ]