Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29649

don't overwrite existing junit-results

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • tap-plugin
    • None
    • Linux
      Jenkins 1.621
      TAP Plugin 1.23

    Description

      We have in our projects some tests that emit result as JUnit-XML and some that write a TAP-file. Since installing the TAP-plugin, the testresults-graph only shows the TAP-results. This is bad, as we have ~70 TAP-tests, but 5000 JUnit-XML tests.

      Attachments

        1. junit.xml
          0.3 kB
        2. tap.hpi
          338 kB
        3. tap.t
          0.0 kB

        Activity

          Ack Matthias. I hadn't had much time to fix issues in the past, partly due to not using it at work. Now I've changed jobs and luckily they were using the tap-plugin, so that gives me a bit more of time to work on the plug-in. I'll try to reproduce it in the next days and check how to propose a fix.

          Would you have time and a testbed server to try a snapshot with the fix?

          Thanks!
          Bruno

          kinow Bruno P. Kinoshita added a comment - Ack Matthias. I hadn't had much time to fix issues in the past, partly due to not using it at work. Now I've changed jobs and luckily they were using the tap-plugin, so that gives me a bit more of time to work on the plug-in. I'll try to reproduce it in the next days and check how to propose a fix. Would you have time and a testbed server to try a snapshot with the fix? Thanks! Bruno

          Hmm, I don't have a testbed-server, but a live one.

          I would give a snapshot-version a try (if you give me instructions on how to install that).

          Since we use your plugin in the majority of our jobs, I can give you feedback rather quickly.

          kronn Matthias Viehweger added a comment - Hmm, I don't have a testbed-server, but a live one. I would give a snapshot-version a try (if you give me instructions on how to install that). Since we use your plugin in the majority of our jobs, I can give you feedback rather quickly.

          I learned how to install the development version of your plugin, so I can try snapshots (even of feature-branches) rather quickly.

          Is there any other way I can help with this issue?

          kronn Matthias Viehweger added a comment - I learned how to install the development version of your plugin, so I can try snapshots (even of feature-branches) rather quickly. Is there any other way I can help with this issue?
          anenviousguest Vladislav Ponomarev added a comment - Suggested fix: https://github.com/jenkinsci/tap-plugin/pull/13

          anenviousguest's fix seems to work fine attaching example files used for a quick test. Just need to review the code now and check backward compatibility.

          kinow Bruno P. Kinoshita added a comment - anenviousguest 's fix seems to work fine attaching example files used for a quick test. Just need to review the code now and check backward compatibility.

          Code changed in jenkins
          User: Vladislav Ponomarev
          Path:
          src/main/java/org/tap4j/plugin/AbstractTapProjectAction.java
          src/main/java/org/tap4j/plugin/TapProjectAction.java
          src/main/java/org/tap4j/plugin/TapTestResultAction.java
          src/test/java/org/tap4j/plugin/PublishersCombinationTest.java
          src/test/resources/org/tap4j/plugin/PublishersCombinationTest.zip
          http://jenkins-ci.org/commit/tap-plugin/bc46bc5d413cbb139a4c0931752f42a594728cd8
          Log:
          [FIXED JENKINS-29649] Now JUnit and TAP publisher do not clash with each other trying to draw a plot on a project page.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vladislav Ponomarev Path: src/main/java/org/tap4j/plugin/AbstractTapProjectAction.java src/main/java/org/tap4j/plugin/TapProjectAction.java src/main/java/org/tap4j/plugin/TapTestResultAction.java src/test/java/org/tap4j/plugin/PublishersCombinationTest.java src/test/resources/org/tap4j/plugin/PublishersCombinationTest.zip http://jenkins-ci.org/commit/tap-plugin/bc46bc5d413cbb139a4c0931752f42a594728cd8 Log: [FIXED JENKINS-29649] Now JUnit and TAP publisher do not clash with each other trying to draw a plot on a project page.

          Pull request merged. Marking as resolved. Included in the next release. Thanks Vladislav for your contribution. Matthias, I've attached the .hpi file used, in case you'd like to try it before the release.

          kinow Bruno P. Kinoshita added a comment - Pull request merged. Marking as resolved. Included in the next release. Thanks Vladislav for your contribution. Matthias, I've attached the .hpi file used, in case you'd like to try it before the release.

          2.0 released

          kinow Bruno P. Kinoshita added a comment - 2.0 released

          Code changed in jenkins
          User: Vladislav Ponomarev
          Path:
          pom.xml
          src/main/java/org/tap4j/plugin/util/GraphHelper.java
          src/test/java/org/tap4j/plugin/PublishersCombinationTest.java
          src/test/resources/org/tap4j/plugin/PublishersCombinationTest.zip
          http://jenkins-ci.org/commit/tap-plugin/170bfce788bbd13be50fae603e5b0c2bb78bbd26
          Log:
          Added red testcase for JENKINS-29649 + Jenkins2 pipeline job.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vladislav Ponomarev Path: pom.xml src/main/java/org/tap4j/plugin/util/GraphHelper.java src/test/java/org/tap4j/plugin/PublishersCombinationTest.java src/test/resources/org/tap4j/plugin/PublishersCombinationTest.zip http://jenkins-ci.org/commit/tap-plugin/170bfce788bbd13be50fae603e5b0c2bb78bbd26 Log: Added red testcase for JENKINS-29649 + Jenkins2 pipeline job.

          Code changed in jenkins
          User: Vladislav Ponomarev
          Path:
          src/main/java/org/tap4j/plugin/TapProjectAction.java
          src/main/java/org/tap4j/plugin/TapTestResultAction.java
          src/main/java/org/tap4j/plugin/model/TapStreamResult.java
          src/main/java/org/tap4j/plugin/model/TapTestResultResult.java
          src/main/java/org/tap4j/plugin/util/GraphHelper.java
          http://jenkins-ci.org/commit/tap-plugin/2fbcc63feba07d583c5ec620fa47f5c509ca0f01
          Log:
          Fixing Jenkins 2 part of JENKINS-29649. Making the testcase green, migrating AbstractBuild -> Run to better support Jenkins 2 workflow jobs.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vladislav Ponomarev Path: src/main/java/org/tap4j/plugin/TapProjectAction.java src/main/java/org/tap4j/plugin/TapTestResultAction.java src/main/java/org/tap4j/plugin/model/TapStreamResult.java src/main/java/org/tap4j/plugin/model/TapTestResultResult.java src/main/java/org/tap4j/plugin/util/GraphHelper.java http://jenkins-ci.org/commit/tap-plugin/2fbcc63feba07d583c5ec620fa47f5c509ca0f01 Log: Fixing Jenkins 2 part of JENKINS-29649 . Making the testcase green, migrating AbstractBuild -> Run to better support Jenkins 2 workflow jobs.

          People

            kinow Bruno P. Kinoshita
            kronn Matthias Viehweger
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: