Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29698

NullPointerException and threads blocked in the JVM with the Gitlab Merge Requests Builder plugin

      Dear,

      We are currently using Jenkins 1.596.3 with the Gitlab Merge Requests Builder plugin version 1.2.2.

      If we create a jenkins job which uses this plugin, and if we try to save the configuration of the job, we see a NPE:

      WARNING: org.jenkinsci.plugins.gitlab.GitlabBuildTrigger.run() failed for hudson.model.FreeStyleProject@37d513a0[MY_JOB]
      java.lang.NullPointerException
              at org.jenkinsci.plugins.gitlab.GitlabBuildTrigger.run(GitlabBuildTrigger.java:100)
              at hudson.triggers.Trigger.checkTriggers(Trigger.java:266)
              at hudson.triggers.Trigger$Cron.doRun(Trigger.java:214)
              at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:54)
              at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
              at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
              at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
              at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
              at java.lang.Thread.run(Thread.java:744)
      

      At the same time, we also see that the thread related to the save of the job gets blocked in the JVM.
      As users try and try again to save the job configuration, we have several threads blocked in the JVM, which has an impact on the stability of our Jenkins instance.

      Could you please investigate ?

      Thanks

          [JENKINS-29698] NullPointerException and threads blocked in the JVM with the Gitlab Merge Requests Builder plugin

          Ludovic Vercruysse created issue -
          Kanstantsin Shautsou made changes -
          Link New: This issue is related to JENKINS-29794 [ JENKINS-29794 ]

          Kanstantsin Shautsou added a comment - proposed PR with fix https://github.com/jenkinsci/gitlab-merge-request-builder-plugin/pull/1
          Kanstantsin Shautsou made changes -
          Assignee New: Kanstantsin Shautsou [ integer ]
          Kanstantsin Shautsou made changes -
          Assignee Original: Kanstantsin Shautsou [ integer ]

          Removing myself from assignee because of inadequate maintainer. My fix was stolen into external git repository.

          Kanstantsin Shautsou added a comment - Removing myself from assignee because of inadequate maintainer. My fix was stolen into external git repository.
          Kanstantsin Shautsou made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Hi timols, hi integer,

          I read the comments in https://github.com/jenkinsci/gitlab-merge-request-builder-plugin/pull/1 and I find it very disappointing that a fix has been developed for this issue but cannot be proposed through the Jenkins update center because two people disagree on the ownership of the plugin.

          May I ask you to discuss again together about this issue and find a collaborative approach in which both of you would be identified as owners/maintainers of this plugin, in order to allow Jenkins users like me to get this fix ?

          Best regards

          Ludovic Vercruysse added a comment - Hi timols , hi integer , I read the comments in https://github.com/jenkinsci/gitlab-merge-request-builder-plugin/pull/1 and I find it very disappointing that a fix has been developed for this issue but cannot be proposed through the Jenkins update center because two people disagree on the ownership of the plugin. May I ask you to discuss again together about this issue and find a collaborative approach in which both of you would be identified as owners/maintainers of this plugin, in order to allow Jenkins users like me to get this fix ? Best regards
          Ludovic Vercruysse made changes -
          Assignee New: Timothy Olshansky [ timols ]
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          lvercruysse this maintainer is not carying about JIRA issues and jenkinsci repo, he is living in his home GH repo. So send your questions to him. If he did release right, then it should be available in 1.2.3 or in 1.2.4.

          Kanstantsin Shautsou added a comment - lvercruysse this maintainer is not carying about JIRA issues and jenkinsci repo, he is living in his home GH repo. So send your questions to him. If he did release right, then it should be available in 1.2.3 or in 1.2.4.

            timols Timothy Olshansky
            lvercruysse Ludovic Vercruysse
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: