Details
-
Type:
New Feature
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: jenkins-reviewbot-plugin, job-dsl-plugin
-
Labels:None
-
Similar Issues:
Description
As reviewbot is a really powerful plugin it would be great if DSL could support it.
https://wiki.jenkins-ci.org/display/JENKINS/Jenkins-Reviewbot
Attachments
Activity
@misery: Please open a pull request to add support for the Jenkins-Reviewbot Plugin. It's not mandatory to support all options, just add those where you do not want to use the default value.
Daniel Spilker
added a comment - @misery: Please open a pull request to add support for the Jenkins-Reviewbot Plugin. It's not mandatory to support all options, just add those where you do not want to use the default value. The upcoming generic DSL (https://github.com/jenkinsci/job-dsl-plugin/pull/816) will enable support for the Reviewbot plugin:
job('example') { parameters { reviewboardParameterDefinition() } steps { reviewboardPollingBuilder { reviewbotJobName('JobName') checkBackPeriod('2') reviewbotRepoId('1') restrictByUser(true) disableAdvanceNotice(true) } } publishers { reviewboardNotifier { shipItOnSuccess(false) useMarkdown(true) } } }
Daniel Spilker
added a comment - - edited The upcoming generic DSL ( https://github.com/jenkinsci/job-dsl-plugin/pull/816 ) will enable support for the Reviewbot plugin:
job( 'example' ) {
parameters {
reviewboardParameterDefinition()
}
steps {
reviewboardPollingBuilder {
reviewbotJobName( 'JobName' )
checkBackPeriod( '2' )
reviewbotRepoId( '1' )
restrictByUser( true )
disableAdvanceNotice( true )
}
}
publishers {
reviewboardNotifier {
shipItOnSuccess( false )
useMarkdown( true )
}
}
}
For everyone who wants to use it until it is officially supported.
Parameter:
configure { project -> project / 'properties' / 'hudson.model.ParametersDefinitionProperty' / 'parameterDefinitions' << 'org.jenkinsci.plugins.jenkinsreviewbot.ReviewboardParameterDefinition' { name('review.url') defaultValue('') } }Polling:
configure { project -> project / 'builders' << 'org.jenkinsci.plugins.jenkinsreviewbot.ReviewboardPollingBuilder' { reviewbotJobName 'JobName' checkBackPeriod '2' reviewbotRepoId '1' restrictByUser 'true' disableAdvanceNotice 'true' processedReviewDates '' } }Notifier:
configure { project -> project / 'publishers' << 'org.jenkinsci.plugins.jenkinsreviewbot.ReviewboardNotifier' { shipItOnSuccess 'false' useMarkdown 'true' customMessage '' } }