Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29776

Job DSL support for Promoted Builds Plugin

    XMLWordPrintable

Details

    Description

      There is actually a discussion on Google Groups if it makes sense to add support for the Job DSL plugin directly into the Promoted Builds Plugin:
      https://groups.google.com/d/msgid/jenkinsci-dev/e6946a1a-a207-4bc4-8fc2-b42021b996f3%40googlegroups.com?utm_medium=email&utm_source=footer

      I created already a Job DSL Extension in a separate Repository (https://github.com/codecentric/job-dsl-promotions-plugin). The question is now if I should invest the time to create a PR for the Promoted Builds Plugin. The main point is here, that the extension is mainly written in Groovy. Is it ok for you to see Groovy in your code base?

      Regards
      Dennis

      Attachments

        Activity

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          README.md
          pom.xml
          src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java
          src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ConditionsContext.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualCondition.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcess.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverter.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ManualConditionConverter.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionContext.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsContext.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsExtensionPoint.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ReleasePromotionCondition.java
          src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualConditionConverterTest.java
          src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverterTest.java
          src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsDslContextExtensionTest.java
          src/test/resources/complex-example-dsl.groovy
          src/test/resources/example-dsl.groovy
          http://jenkins-ci.org/commit/promoted-builds-plugin/93b8ea1bf26da3564722dd4633be5da963d9afcb
          Log:
          Merge pull request #82 from denschu/master

          [FIXED JENKINS-29776] Add Job DSL support for Promoted Builds Plugin

          Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/be96e51aa2ba...93b8ea1bf26d

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: README.md pom.xml src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ConditionsContext.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualCondition.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcess.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverter.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ManualConditionConverter.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionContext.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsContext.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsExtensionPoint.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ReleasePromotionCondition.java src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualConditionConverterTest.java src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverterTest.java src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsDslContextExtensionTest.java src/test/resources/complex-example-dsl.groovy src/test/resources/example-dsl.groovy http://jenkins-ci.org/commit/promoted-builds-plugin/93b8ea1bf26da3564722dd4633be5da963d9afcb Log: Merge pull request #82 from denschu/master [FIXED JENKINS-29776] Add Job DSL support for Promoted Builds Plugin Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/be96e51aa2ba...93b8ea1bf26d

          Code changed in jenkins
          User: Dennis Schulte
          Path:
          README.md
          pom.xml
          src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java
          src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ConditionsContext.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualCondition.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcess.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverter.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ManualConditionConverter.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionContext.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsContext.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsExtensionPoint.java
          src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ReleasePromotionCondition.java
          src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualConditionConverterTest.java
          src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverterTest.java
          src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsDslContextExtensionTest.java
          src/test/resources/complex-example-dsl.groovy
          src/test/resources/example-dsl.groovy
          http://jenkins-ci.org/commit/promoted-builds-plugin/327d0233255d0a2c2806c3337daac97e8580905c
          Log:
          [FIXED JENKINS-29776] Add Job DSL support for Promoted Builds Plugin

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dennis Schulte Path: README.md pom.xml src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ConditionsContext.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualCondition.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcess.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverter.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ManualConditionConverter.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionContext.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsContext.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsExtensionPoint.java src/main/java/hudson/plugins/promoted_builds/integrations/jobdsl/ReleasePromotionCondition.java src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslManualConditionConverterTest.java src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/JobDslPromotionProcessConverterTest.java src/test/java/hudson/plugins/promoted_builds/integrations/jobdsl/PromotionsDslContextExtensionTest.java src/test/resources/complex-example-dsl.groovy src/test/resources/example-dsl.groovy http://jenkins-ci.org/commit/promoted-builds-plugin/327d0233255d0a2c2806c3337daac97e8580905c Log: [FIXED JENKINS-29776] Add Job DSL support for Promoted Builds Plugin
          davidschou David Chou added a comment -

          +1 for this. Thanks denschu for taking the time to create that PR. Looks like no activity yet on your updated https://github.com/jenkinsci/promoted-builds-plugin/pull/82

          Was wondering if anyone has a work around for this while we wait for the process?

          davidschou David Chou added a comment - +1 for this. Thanks denschu for taking the time to create that PR. Looks like no activity yet on your updated https://github.com/jenkinsci/promoted-builds-plugin/pull/82 Was wondering if anyone has a work around for this while we wait for the process?
          denschu Dennis Schulte added a comment - Created a PR: https://github.com/jenkinsci/promoted-builds-plugin/pull/81

          People

            denschu Dennis Schulte
            denschu Dennis Schulte
            Votes:
            3 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: