Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29835

Condition for Remote Directory should Include Empty

XMLWordPrintable

      The artifact deployer form outlines that 'Remote Directory' is mandatory as per attached screenshot.

      But, if the value is actually empty during run time, this does not get caught.

      Right now, that value gets checked against null only:

      if (entry.getRemote() == null) {
            throw new ArtifactDeployerException("A remote directory must be set.");
        }

      I think there should be a check for character count = 0, or empty.

      This is important: A scenario took place on our instance where a user left 'Remote Directory' empty and checked checkbox 'Clean-up remote directory before deployment'. It wiped everything empty under the agent's root dir. All workspaces, Maven repo, and other stuff...

        1. artifacedeployer.png
          artifacedeployer.png
          6 kB

          [JENKINS-29835] Condition for Remote Directory should Include Empty

          Fawzy Manaa created issue -
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 164912 ] New: JNJira + In-Review [ 181738 ]
          Ian Williams made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]
          Ian Williams made changes -
          Description Original: The artifact deployer form outlines that 'Remote Directory' is mandatory as per attached screenshot.

          But, if the value is actually empty during run time, this does not get caught.

          Right now, that value gets checked against null only:

          {code:java}

          if (entry.getRemote() == null) {
                      throw new ArtifactDeployerException("A remote directory must be set.");
                  }
          {code}

          I think there should be a check for character count = 0, or empty.

          This is important: A scenario took place on our instance where a user left 'Remote Directory' empty and checked checkbox 'Clean-up remote directory before deployment'. It wiped everything empty under the slave's root dir. All workspaces, Maven repo, and other stuff...           		New: The artifact deployer form outlines that 'Remote Directory' is mandatory as per attached screenshot.

          But, if the value is actually empty during run time, this does not get caught.

          Right now, that value gets checked against null only:

          {code:java}

          if (entry.getRemote() == null) {
                      throw new ArtifactDeployerException("A remote directory must be set.");
                  }
          {code}

          I think there should be a check for character count = 0, or empty.

          *This is important*: A scenario took place on our instance where a user left 'Remote Directory' empty and checked checkbox 'Clean-up remote directory before deployment'. It wiped everything empty under the agent's root dir. All workspaces, Maven repo, and other stuff...

            gbois Gregory Boissinot
            fawzymanaa Fawzy Manaa
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: