• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • git-plugin
    • None
    • CentOS release 6.7 (Final)
      Java 1.7.0_85
      Jenkins 1.624 installed via RPM
      Git Plugin 2.4.0
      Git client plugin 1.18.0

      The commit messages in the changes view began to be truncated at some recent version of the Git plugin.

      This problem can be seen in Problem1.png where the commit messages are truncated. In Problem2.png you can see that the full message is available but it appears that there is a newline in there. Correct.png is a screenshot of an older version (not entirely sure which, it's from Apache's Jenkins server) where the same commit is correctly displayed.

      This does not only affect display but also the E-Mail notifications that are sent making them relatively useless.

      There is - as far as I know - no workaround hence I marked it as major and not as minor.

        1. Problem1.png
          Problem1.png
          618 kB
        2. Correct.png
          Correct.png
          82 kB
        3. Problem2.png
          Problem2.png
          46 kB

          [JENKINS-29977] Git Plugin truncates changelog

          Lars Francke created issue -

          Mark Waite added a comment - - edited

          Can you identify which plugin release was the last version you used which did not truncate?

          I see the truncation, but rather assume it has been that way for a long time.

          I think that truncation is not unreasonable, considering the recommendation for 50/72 formatting on stackoverflow, linux kernel recommendations, Chris Beams blog, Tim Pope's blog, and Caleb Thompson. I'm not aware of a change which intentionally truncated the commit message for display, but I see the truncation is happening.

          Mark Waite added a comment - - edited Can you identify which plugin release was the last version you used which did not truncate? I see the truncation, but rather assume it has been that way for a long time. I think that truncation is not unreasonable, considering the recommendation for 50/72 formatting on stackoverflow , linux kernel recommendations , Chris Beams blog , Tim Pope's blog , and Caleb Thompson . I'm not aware of a change which intentionally truncated the commit message for display, but I see the truncation is happening.

          Lars Francke added a comment -

          Thanks for the comment Mark. As you can see from the screenshot the truncation has been introduced recently (sometime this year, took me a while to notice).

          I have tried a few versions back to 2.2.6 but it still happens there. I will try and ask the Apache folks which versions they are running.

          Lars Francke added a comment - Thanks for the comment Mark. As you can see from the screenshot the truncation has been introduced recently (sometime this year, took me a while to notice). I have tried a few versions back to 2.2.6 but it still happens there. I will try and ask the Apache folks which versions they are running.

          Mark Waite added a comment -

          I'm not persuaded that it happened in the last year, since 2.2.6 was released Sep 2014 and you indicate that it is already there in 2.2.6. My initial suspicion is that the version which does not truncate is from the 1.x release series from a long time ago. However, I'm open to being proven wrong on that.

          Mark Waite added a comment - I'm not persuaded that it happened in the last year, since 2.2.6 was released Sep 2014 and you indicate that it is already there in 2.2.6. My initial suspicion is that the version which does not truncate is from the 1.x release series from a long time ago. However, I'm open to being proven wrong on that.

          Lars Francke added a comment -

          You could very well be correct, yes. Next chance I get I'll try to downgrade to a 1.x version.

          Lars Francke added a comment - You could very well be correct, yes. Next chance I get I'll try to downgrade to a 1.x version.

          Lars Francke added a comment -

          I've tried 1.5 and you're correct: That does not truncate.

          So I have a workaround for now but to me this still seems undesirable and like a bug. If you do agree - and I'm not sure about that - I'm happy to take a look at the code to see if I can find what's going on.

          Lars Francke added a comment - I've tried 1.5 and you're correct: That does not truncate. So I have a workaround for now but to me this still seems undesirable and like a bug. If you do agree - and I'm not sure about that - I'm happy to take a look at the code to see if I can find what's going on.

          Mark Waite added a comment - - edited

          I prefer the current behavior of only showing a reasonable subset of the commit message in the UI presentation. My rationale is captured in my earlier comment on this bug. Other maintainers may have a different opinion, but for me, I prefer the truncation that was implemented in the 2.0 plugin rather than returning to the 1.0 unlimited length string behavior.

          Mark Waite added a comment - - edited I prefer the current behavior of only showing a reasonable subset of the commit message in the UI presentation. My rationale is captured in my earlier comment on this bug . Other maintainers may have a different opinion, but for me, I prefer the truncation that was implemented in the 2.0 plugin rather than returning to the 1.0 unlimited length string behavior.

          Lars Francke added a comment -

          Thanks Mark. Shall I close the issue then?

          (It seems as if 1.5 doesn't always work as it used to either, so I'll have to find alternatives to Jenkins anyway)

          Lars Francke added a comment - Thanks Mark. Shall I close the issue then? (It seems as if 1.5 doesn't always work as it used to either, so I'll have to find alternatives to Jenkins anyway)

          Mark Waite added a comment -

          I think you should close the issue. If you're passionate about not truncating and willing to invest some effort in the plugin, you could consider creating a separate plugin (to add the behavior for those users who want it) or an optional extension of the current plugin which would modify the behavior to never truncate the change log message.

          Mark Waite added a comment - I think you should close the issue. If you're passionate about not truncating and willing to invest some effort in the plugin, you could consider creating a separate plugin (to add the behavior for those users who want it) or an optional extension of the current plugin which would modify the behavior to never truncate the change log message.
          Lars Francke made changes -
          Resolution New: Not A Defect [ 7 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

            jtaboada Jose Blas Camacho Taboada
            lars_francke Lars Francke
            Votes:
            8 Vote for this issue
            Watchers:
            19 Start watching this issue

              Created:
              Updated:
              Resolved: