• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Util.isOverridden works only on public methods.

      It needs to be improved in order to inspect non-public too through the inheritance. For example is this case:

      public abstract class Base {
          protected abstract void method();
      }
      public abstract class Intermediate extends Base {
          protected void method() {}
      }
      public class Derived extends Intermediate {}
      

      A call to isOverridden(Base.class, Derived.class, "method") should return true.

          [JENKINS-30002] Improve Util.isOverridden

          Antonio Muñiz created issue -
          Antonio Muñiz made changes -
          Assignee New: Antonio Muñiz [ amuniz ]
          Antonio Muñiz made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Antonio Muñiz added a comment - PR sent: https://github.com/jenkinsci/jenkins/pull/1804

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          core/src/main/java/hudson/Util.java
          core/src/test/java/hudson/util/IsOverriddenTest.java
          http://jenkins-ci.org/commit/jenkins/89a0050ceaf2a50517056582d1c188052f994fd7
          Log:
          JENKINS-30002 Improve Util.isOverridden

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: core/src/main/java/hudson/Util.java core/src/test/java/hudson/util/IsOverriddenTest.java http://jenkins-ci.org/commit/jenkins/89a0050ceaf2a50517056582d1c188052f994fd7 Log: JENKINS-30002 Improve Util.isOverridden

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/Util.java
          core/src/test/java/hudson/util/IsOverriddenTest.java
          http://jenkins-ci.org/commit/jenkins/6adbb33e6b2c267e1832ecb801f7bcc364331d5a
          Log:
          Merge pull request #1804 from amuniz/JENKINS-30002

          JENKINS-30002 Improve Util.isOverridden

          Compare: https://github.com/jenkinsci/jenkins/compare/dd8f775a99cf...6adbb33e6b2c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Util.java core/src/test/java/hudson/util/IsOverriddenTest.java http://jenkins-ci.org/commit/jenkins/6adbb33e6b2c267e1832ecb801f7bcc364331d5a Log: Merge pull request #1804 from amuniz/ JENKINS-30002 JENKINS-30002 Improve Util.isOverridden Compare: https://github.com/jenkinsci/jenkins/compare/dd8f775a99cf...6adbb33e6b2c
          Oleg Nenashev made changes -
          Issue Type Original: Task [ 3 ] New: Bug [ 1 ]

          Oleg Nenashev added a comment -

          Should become available in 1.632

          Oleg Nenashev added a comment - Should become available in 1.632
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4302
          JENKINS-30002 Improve Util.isOverridden (Revision 89a0050ceaf2a50517056582d1c188052f994fd7)

          Result = SUCCESS
          amuniz : 89a0050ceaf2a50517056582d1c188052f994fd7
          Files :

          • core/src/test/java/hudson/util/IsOverriddenTest.java
          • core/src/main/java/hudson/Util.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4302 JENKINS-30002 Improve Util.isOverridden (Revision 89a0050ceaf2a50517056582d1c188052f994fd7) Result = SUCCESS amuniz : 89a0050ceaf2a50517056582d1c188052f994fd7 Files : core/src/test/java/hudson/util/IsOverriddenTest.java core/src/main/java/hudson/Util.java

            amuniz Antonio Muñiz
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: