Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30080

Possible deadlock between scheduleBuild() and NodeProvisioner updates

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      jenkins-1.607+
    • Similar Issues:

      Description

      JIRA was down when I've created the issue

      NodeProvisioner#getPendingLaunches() and NodeProvisioner#update() may get deadlocked if somebody retrieves a list of pending launches in the build scheduler. It
      also applies to all other methods guarded by provisioningLock, because NodeProvisioner#update() locks the queue after locking provisioningLock.

      Pull requests:

        Attachments

          Issue Links

            Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Environment jenkins-1.607+
            Hide
            oleg_nenashev Oleg Nenashev added a comment -
            Show
            oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/jenkins/pull/1785 has been merged into 1.625
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels deadlock queue deadlock lts-candidate queue
            danielbeck Daniel Beck made changes -
            Labels deadlock lts-candidate queue deadlock lts-candidate
            danielbeck Daniel Beck made changes -
            Labels deadlock lts-candidate deadlock lts-candidate queue
            Hide
            danielbeck Daniel Beck added a comment -

            We decided on making 1.625 the next LTS baseline.

            Show
            danielbeck Daniel Beck added a comment - We decided on making 1.625 the next LTS baseline.
            danielbeck Daniel Beck made changes -
            Labels deadlock lts-candidate queue deadlock queue
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 165163 ] JNJira + In-Review [ 197637 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal CE-80 (Web Link)" [ 19084 ]

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: