Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30223

Migrator for Credential.java is failing

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      ElasticBox plugin is using github plugin to connect to GitHub. It uses Crendential class that GitHub-plugin has removed in 1.13 release.

      It seems that there is a migration to move the class from com.cloudbees.jenkins.Credential.java to org.jenkinsci.plugins.github.deprecated.Credential.java but when we install ElasticBox plugin, that migration is failing. I've attached jenkins log.

      It seems also that you removed login() function from Credential class, so although migration works, the compatibility with a plugin that is depending on this, is not working anymore.

        Attachments

          Activity

          Hide
          integer Kanstantsin Shautsou added a comment -

          github-plugin is not designed for sharing connection atm, it provides API for registering to events.
          What do you do with this connection?

          Show
          integer Kanstantsin Shautsou added a comment - github-plugin is not designed for sharing connection atm, it provides API for registering to events. What do you do with this connection?
          Hide
          integer Kanstantsin Shautsou added a comment -

          As i see elasticbox plugin invented parts of ghprb-plugin and github-plugins.

          Github plugin need to be reviewed whether it can provide gh connection as fixed API.

          Show
          integer Kanstantsin Shautsou added a comment - As i see elasticbox plugin invented parts of ghprb-plugin and github-plugins. Github plugin need to be reviewed whether it can provide gh connection as fixed API.
          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          We use to connect to the gihub and manage PR events to manage the lifecycle of pull requests

          Show
          ignaciofuertes Ignacio Fuertes added a comment - We use to connect to the gihub and manage PR events to manage the lifecycle of pull requests
          Hide
          lanwen Kirill Merkushev added a comment -

          is it ok if i send you pr with fix?

          Show
          lanwen Kirill Merkushev added a comment - is it ok if i send you pr with fix?
          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          yes, it's ok

          Show
          ignaciofuertes Ignacio Fuertes added a comment - yes, it's ok
          Hide
          lanwen Kirill Merkushev added a comment -

          will restore removed class and create fix in a few hours

          Show
          lanwen Kirill Merkushev added a comment - will restore removed class and create fix in a few hours
          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          Sounds great! Thanks!

          Show
          ignaciofuertes Ignacio Fuertes added a comment - Sounds great! Thanks!
          Show
          lanwen Kirill Merkushev added a comment - https://github.com/jenkinsci/github-plugin/pull/79 https://github.com/jenkinsci/elasticbox-plugin/pull/3
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kirill Merkushev
          Path:
          src/main/java/com/cloudbees/jenkins/Credential.java
          src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
          src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java
          src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java
          src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java
          src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java
          http://jenkins-ci.org/commit/github-plugin/061d849cd41f079a205656afa4d3583fce821351
          Log:
          [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential

          as of it makes fail to boot jenkins after installation of plugin which depends on this class.
          Also remove migration to another package for this class and use it directly

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kirill Merkushev Path: src/main/java/com/cloudbees/jenkins/Credential.java src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java http://jenkins-ci.org/commit/github-plugin/061d849cd41f079a205656afa4d3583fce821351 Log: [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential as of it makes fail to boot jenkins after installation of plugin which depends on this class. Also remove migration to another package for this class and use it directly
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kanstantsin Shautsou
          Path:
          src/main/java/com/cloudbees/jenkins/Credential.java
          src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
          src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java
          src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java
          src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java
          src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java
          http://jenkins-ci.org/commit/github-plugin/36241308ca565289e93a4ed1ec706b7a25d6176b
          Log:
          Merge pull request #79 from lanwen/restore_creds

          [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential

          Compare: https://github.com/jenkinsci/github-plugin/compare/a726907597da...36241308ca56

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: src/main/java/com/cloudbees/jenkins/Credential.java src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java http://jenkins-ci.org/commit/github-plugin/36241308ca565289e93a4ed1ec706b7a25d6176b Log: Merge pull request #79 from lanwen/restore_creds [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential Compare: https://github.com/jenkinsci/github-plugin/compare/a726907597da...36241308ca56
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kirill Merkushev
          Path:
          pom.xml
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestBuildHandler.java
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestCleanup.java
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestManager.java
          http://jenkins-ci.org/commit/elasticbox-plugin/10cd2e0b2e0809d6fcdc40e30373c87f14dec216
          Log:
          [FIXES JENKINS-30223] Migrate to new version of GH Plugin

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kirill Merkushev Path: pom.xml src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestBuildHandler.java src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestCleanup.java src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestManager.java http://jenkins-ci.org/commit/elasticbox-plugin/10cd2e0b2e0809d6fcdc40e30373c87f14dec216 Log: [FIXES JENKINS-30223] Migrate to new version of GH Plugin
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kirill Merkushev
          Path:
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestManager.java
          src/test/java/com/elasticbox/jenkins/tests/PullRequestTestBase.java
          http://jenkins-ci.org/commit/elasticbox-plugin/ab9c85d25f0c9bd43c0fe60cf47aec69c8c6918c
          Log:
          [FIXES JENKINS-30223] Migrate to new version of GH Plugin in tests

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kirill Merkushev Path: src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestManager.java src/test/java/com/elasticbox/jenkins/tests/PullRequestTestBase.java http://jenkins-ci.org/commit/elasticbox-plugin/ab9c85d25f0c9bd43c0fe60cf47aec69c8c6918c Log: [FIXES JENKINS-30223] Migrate to new version of GH Plugin in tests
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: riccardoelasticbox
          Path:
          pom.xml
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestBuildHandler.java
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestCleanup.java
          src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestManager.java
          src/test/java/com/elasticbox/jenkins/tests/PullRequestTestBase.java
          http://jenkins-ci.org/commit/elasticbox-plugin/86df8fba5fef7cff7d1c4cbc1b54d1a1889f22fe
          Log:
          Merge pull request #3 from lanwen/JENKINS-30223_fix

          [FIXES JENKINS-30223] Migrate to new version (1.13.1) of GH Plugin

          Compare: https://github.com/jenkinsci/elasticbox-plugin/compare/bac7fef81943...86df8fba5fef

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: riccardoelasticbox Path: pom.xml src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestBuildHandler.java src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestCleanup.java src/main/java/com/elasticbox/jenkins/triggers/github/PullRequestManager.java src/test/java/com/elasticbox/jenkins/tests/PullRequestTestBase.java http://jenkins-ci.org/commit/elasticbox-plugin/86df8fba5fef7cff7d1c4cbc1b54d1a1889f22fe Log: Merge pull request #3 from lanwen/ JENKINS-30223 _fix [FIXES JENKINS-30223] Migrate to new version (1.13.1) of GH Plugin Compare: https://github.com/jenkinsci/elasticbox-plugin/compare/bac7fef81943...86df8fba5fef
          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          Thanks a lot for your help!

          Show
          ignaciofuertes Ignacio Fuertes added a comment - Thanks a lot for your help!
          Hide
          lanwen Kirill Merkushev added a comment -

          will release gh 1.13.3 with reverted class tomorrow in the morning

          Show
          lanwen Kirill Merkushev added a comment - will release gh 1.13.3 with reverted class tomorrow in the morning
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kirill Merkushev
          Path:
          src/main/java/com/cloudbees/jenkins/Credential.java
          src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
          src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java
          src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java
          src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java
          src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java
          http://jenkins-ci.org/commit/github-plugin/b10ad388815a35617fe5fbb79171f116eb814a64
          Log:
          [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential

          as of it makes fail to boot jenkins after installation of plugin which depends on this class.
          Also remove migration to another package for this class and use it directly

          (cherry picked from commit 061d849)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kirill Merkushev Path: src/main/java/com/cloudbees/jenkins/Credential.java src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java http://jenkins-ci.org/commit/github-plugin/b10ad388815a35617fe5fbb79171f116eb814a64 Log: [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential as of it makes fail to boot jenkins after installation of plugin which depends on this class. Also remove migration to another package for this class and use it directly (cherry picked from commit 061d849)
          Hide
          lanwen Kirill Merkushev added a comment -

          1.13.3 shipped

          Show
          lanwen Kirill Merkushev added a comment - 1.13.3 shipped
          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          Great, Thanks!

          Show
          ignaciofuertes Ignacio Fuertes added a comment - Great, Thanks!

            People

            Assignee:
            lanwen Kirill Merkushev
            Reporter:
            ignaciofuertes Ignacio Fuertes
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: