• Type: Bug
• Resolution: Not A Defect
• Priority: Blocker
• Component/s: git-plugin
• Labels:

  None
• Environment:

  2.4.0/1.18.0
  1.609.3

[JENKINS-30474] delete me

Kanstantsin Shautsou created issue - 2015-09-15 23:29

Kanstantsin Shautsou made changes - 2015-09-16 11:20

Resolution		New: Duplicate [ 3 ]
Status	Original: Open [ 1 ]	New: Closed [ 6 ]

Kanstantsin Shautsou made changes - 2015-09-16 11:21

Assignee	Original: Mark Waite [ markewaite ]	New: Kanstantsin Shautsou [ integer ]
Resolution	Original: Duplicate [ 3 ]
Status	Original: Closed [ 6 ]	New: Reopened [ 4 ]

Kanstantsin Shautsou made changes - 2015-09-16 11:21

Description

Original: After long time of debugging i found that current polling algorithm works in the next way: # Get from remote repo branchnames + sha1 # compare with existed BuilData in latest build (ONE logic) # If sha1/branch not found -> trigger build (NO RPA attached) # Build is running and it calls checkout() step in GITScm # checkout() calls getBuildRevision that calls DefaultBuildChooser that calls getAdvancedCandidateRevisions() that calls revs = GitUtils.filterTipBranches(revs); (SECOND logic) # filter tips removes all intermediate branches and they never appears in BuildData That ends in situations that Polling needs branches, but checkout didn't build them. I fixed this issue by commenting tips filtering https://github.com/KostyaSha/git-plugin/commit/8336202ee5ec8d5a12caa875aeba27b89ac3af58 this allowed build all branches and Polling now satisfied. Suggestion: # Put RPA as polling result for triggered build -> allows ensure that BuildData will get what polling wants # Use the same logic for checkout and polling -> more or less allows hope that checkout will pick what polling mean

New: delete me

Kanstantsin Shautsou made changes - 2015-09-16 11:21

Summary

Original: bad design for Polling vs Checkout algorithms

New: delete me

Kanstantsin Shautsou made changes - 2015-09-16 11:22

Resolution		New: Not A Defect [ 7 ]
Status	Original: Reopened [ 4 ]	New: Resolved [ 5 ]

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

Original: JNJira [ 165584 ]

New: JNJira + In-Review [ 197761 ]

Mark Waite made changes - 2019-10-23 01:28

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]