Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30531

Define SCMRevisionAction from SCMBinder

    XMLWordPrintable

Details

    Description

      SCMBinder currently uses some hacks to save an SCM object in the build. Perhaps it would be better to use SCMRevisionAction, which was intended for this purpose.

      Attachments

        Issue Links

          Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick added a comment -

            Possible this would be helpful in resolving JENKINS-30222.

            jglick Jesse Glick added a comment - Possible this would be helpful in resolving JENKINS-30222 .
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-30222 [ JENKINS-30222 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 239 (Web Link)" [ 13500 ]
            jglick Jesse Glick made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            jglick Jesse Glick made changes -
            Issue Type Task [ 3 ] Improvement [ 4 ]
            jglick Jesse Glick made changes -
            Summary Consider using SCMRevisionAction from SCMBinder Define SCMRevisionAction from SCMBinder

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
            multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java
            multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java
            multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java
            http://jenkins-ci.org/commit/workflow-plugin/4e9bd117797620e2f11c03f4053e8210d3086eac
            Log:
            [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record.
            Has the happy side effect of fixing JENKINS-30222: scm as a global variable can be used unqualified from library code.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java http://jenkins-ci.org/commit/workflow-plugin/4e9bd117797620e2f11c03f4053e8210d3086eac Log: [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record. Has the happy side effect of fixing JENKINS-30222 : scm as a global variable can be used unqualified from library code.

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
            multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java
            multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java
            multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java
            http://jenkins-ci.org/commit/workflow-plugin/46d63875dbaa218e9f23e9520cf5f1ed8f6a1c43
            Log:
            Merge pull request #239 from jglick/SCMRevisionAction-JENKINS-30531

            JENKINS-30531 Set SCMRevisionAction when we do a build

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/59e6cf394ba7...46d63875dbaa

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java http://jenkins-ci.org/commit/workflow-plugin/46d63875dbaa218e9f23e9520cf5f1ed8f6a1c43 Log: Merge pull request #239 from jglick/SCMRevisionAction- JENKINS-30531 JENKINS-30531 Set SCMRevisionAction when we do a build Compare: https://github.com/jenkinsci/workflow-plugin/compare/59e6cf394ba7...46d63875dbaa
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/587f35da06082e0ee5c8f925d0877a63c0e123b0
            Log:
            [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record.
            Has the happy side effect of fixing JENKINS-30222: scm as a global variable can be used unqualified from library code.
            Originally-Committed-As: 4e9bd117797620e2f11c03f4053e8210d3086eac

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java http://jenkins-ci.org/commit/workflow-cps-plugin/587f35da06082e0ee5c8f925d0877a63c0e123b0 Log: [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record. Has the happy side effect of fixing JENKINS-30222 : scm as a global variable can be used unqualified from library code. Originally-Committed-As: 4e9bd117797620e2f11c03f4053e8210d3086eac

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java
            multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java
            multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/d8d9403029143715efee336d7094d46cef758d6f
            Log:
            [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record.
            Has the happy side effect of fixing JENKINS-30222: scm as a global variable can be used unqualified from library code.
            Originally-Committed-As: 4e9bd117797620e2f11c03f4053e8210d3086eac

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/d8d9403029143715efee336d7094d46cef758d6f Log: [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record. Has the happy side effect of fixing JENKINS-30222 : scm as a global variable can be used unqualified from library code. Originally-Committed-As: 4e9bd117797620e2f11c03f4053e8210d3086eac
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 165642 ] JNJira + In-Review [ 197778 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: