Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31098

New delete-node CLI command breaks node cleanup in cloud plugins

    XMLWordPrintable

Details

    Description

      The new implementation of the delete-node command badly breaks cleanup of cloud-managed VMs (at least in jclouds-plugin and openstack-plugin)

      The cloud plugins extend AbstractCloudComputer and then override doDoDelete() in order to perform any cleanup (and delay the actual deleteion until this is done). The new delete-node command does not invoke this and thus when using this command, lots of unused VM's are kept around which get never cleaned up. In fact, there is no "hook" whatsoever anymore which allows a cloud plugin to intercept node deletion.

      If there's some other (new) functionality to intercept node-deletion please let me know.
      Unfortunately this made it into 1.625.1 LTS and I only noticed that change now. It is not even mentioned in the changelog.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          View 11 older comments
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4340
          JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (Revision 04a874ac9572245314208fdeea485383d621fcf6)

          Result = SUCCESS
          pjanouse : 04a874ac9572245314208fdeea485383d621fcf6
          Files :

          • core/src/main/java/hudson/cli/DeleteNodeCommand.java
          • test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4340 JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (Revision 04a874ac9572245314208fdeea485383d621fcf6) Result = SUCCESS pjanouse : 04a874ac9572245314208fdeea485383d621fcf6 Files : core/src/main/java/hudson/cli/DeleteNodeCommand.java test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/e3b3638f76107c020fa43d545890329d92e2bcdf
          Log:
          Noting fix of JENKINS-31098 in #1882

          Compare: https://github.com/jenkinsci/jenkins/compare/fef832fb9ff5...e3b3638f7610

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: changelog.html http://jenkins-ci.org/commit/jenkins/e3b3638f76107c020fa43d545890329d92e2bcdf Log: Noting fix of JENKINS-31098 in #1882 Compare: https://github.com/jenkinsci/jenkins/compare/fef832fb9ff5...e3b3638f7610
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ing. Pavel Janousek
          Path:
          core/src/main/java/hudson/cli/DeleteNodeCommand.java
          test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
          http://jenkins-ci.org/commit/jenkins/24785d545971e10ece89b29fa2dfb50c29c85fd9
          Log:
          JENKINS-31098 Deletage remove a node back to Computer.doDoDelete()

          (cherry picked from commit 04a874ac9572245314208fdeea485383d621fcf6)

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ing. Pavel Janousek Path: core/src/main/java/hudson/cli/DeleteNodeCommand.java test/src/test/java/hudson/cli/DeleteNodeCommandTest.java http://jenkins-ci.org/commit/jenkins/24785d545971e10ece89b29fa2dfb50c29c85fd9 Log: JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (cherry picked from commit 04a874ac9572245314208fdeea485383d621fcf6)
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4373
          JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (Revision 24785d545971e10ece89b29fa2dfb50c29c85fd9)

          Result = SUCCESS
          ogondza : 24785d545971e10ece89b29fa2dfb50c29c85fd9
          Files :

          • test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
          • core/src/main/java/hudson/cli/DeleteNodeCommand.java
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4373 JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (Revision 24785d545971e10ece89b29fa2dfb50c29c85fd9) Result = SUCCESS ogondza : 24785d545971e10ece89b29fa2dfb50c29c85fd9 Files : test/src/test/java/hudson/cli/DeleteNodeCommandTest.java core/src/main/java/hudson/cli/DeleteNodeCommand.java
          dogfood dogfood added a comment -

          Integrated in jenkins_2.0 #5
          JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (Revision 24785d545971e10ece89b29fa2dfb50c29c85fd9)

          Result = SUCCESS
          ogondza : 24785d545971e10ece89b29fa2dfb50c29c85fd9
          Files :

          • core/src/main/java/hudson/cli/DeleteNodeCommand.java
          • test/src/test/java/hudson/cli/DeleteNodeCommandTest.java
          dogfood dogfood added a comment - Integrated in jenkins_2.0 #5 JENKINS-31098 Deletage remove a node back to Computer.doDoDelete() (Revision 24785d545971e10ece89b29fa2dfb50c29c85fd9) Result = SUCCESS ogondza : 24785d545971e10ece89b29fa2dfb50c29c85fd9 Files : core/src/main/java/hudson/cli/DeleteNodeCommand.java test/src/test/java/hudson/cli/DeleteNodeCommandTest.java

          People

            pajasoft Pavel JanouĊĦek
            felfert Fritz Elfert
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: