Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31214

Move Job DSL for GitHub Pull Request Builder to ghprb-plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The Job DSL plugin currently has support for configuring the ghprb plugin. But the config format for the ghprb plugin has changed a lot with recent versions which makes it hard for the Job DSL to support newer features while keeping compatibility with older versions.

      It would be better to move the DSL support to the ghprb plugin by using the Job DSL extension point. That would assure that the DSL will always generate the correct configuration for the ghprb plugin.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          docs/Home.md
          docs/Migration.md
          job-dsl-api-viewer/src/templates/home.hbs
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContext.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContextSpec.groovy
          http://jenkins-ci.org/commit/job-dsl-plugin/45a20249f8c81602572d618f82c67b909bdca231
          Log:
          Merge pull request #717 from daspilker/JENKINS-31214

          JENKINS-31214 deprecated built-in support for GitHub Pull Request Builder Plugin

          Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/0b8fc30b1cef...45a20249f8c8

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-api-viewer/src/templates/home.hbs job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/45a20249f8c81602572d618f82c67b909bdca231 Log: Merge pull request #717 from daspilker/ JENKINS-31214 JENKINS-31214 deprecated built-in support for GitHub Pull Request Builder Plugin Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/0b8fc30b1cef...45a20249f8c8
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          docs/Home.md
          docs/Migration.md
          job-dsl-api-viewer/src/templates/home.hbs
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContext.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContextSpec.groovy
          http://jenkins-ci.org/commit/job-dsl-plugin/6907be0c97072ad198a0a61294ccd0e269f060d7
          Log:
          deprecated built-in support for GitHub Pull Request Builder Plugin

          JENKINS-31214

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-api-viewer/src/templates/home.hbs job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/triggers/ItemTriggerContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/6907be0c97072ad198a0a61294ccd0e269f060d7 Log: deprecated built-in support for GitHub Pull Request Builder Plugin JENKINS-31214
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David Tanner
          Path:
          README.md
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbContextExtensionPoint.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbPullRequestMergeContext.java
          http://jenkins-ci.org/commit/ghprb-plugin/ab983d4c9634bf5f62489156f7ff24aa2fecba8b
          Log:
          Merge pull request #246 from daspilker/JENKINS-31214

          JENKINS-31214 added Job DSL for GhprbPullRequestMerge and docs

          Compare: https://github.com/jenkinsci/ghprb-plugin/compare/070f9880db6c...ab983d4c9634

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: David Tanner Path: README.md src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbContextExtensionPoint.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbPullRequestMergeContext.java http://jenkins-ci.org/commit/ghprb-plugin/ab983d4c9634bf5f62489156f7ff24aa2fecba8b Log: Merge pull request #246 from daspilker/ JENKINS-31214 JENKINS-31214 added Job DSL for GhprbPullRequestMerge and docs Compare: https://github.com/jenkinsci/ghprb-plugin/compare/070f9880db6c...ab983d4c9634
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David Tanner
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbContextExtensionPoint.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbExtensionContext.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbSimpleStatusContext.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbTriggerContext.java
          http://jenkins-ci.org/commit/ghprb-plugin/1bc26e1ff03c75d3589d6d4e754c928c171e7624
          Log:
          Merge pull request #229 from daspilker/JENKINS-31214

          JENKINS-31214 added Job DSL for GhprbTrigger

          Compare: https://github.com/jenkinsci/ghprb-plugin/compare/7d52cf18138e...1bc26e1ff03c

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: David Tanner Path: pom.xml src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbContextExtensionPoint.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbExtensionContext.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbSimpleStatusContext.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbTriggerContext.java http://jenkins-ci.org/commit/ghprb-plugin/1bc26e1ff03c75d3589d6d4e754c928c171e7624 Log: Merge pull request #229 from daspilker/ JENKINS-31214 JENKINS-31214 added Job DSL for GhprbTrigger Compare: https://github.com/jenkinsci/ghprb-plugin/compare/7d52cf18138e...1bc26e1ff03c
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbContextExtensionPoint.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbExtensionContext.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbSimpleStatusContext.java
          src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbTriggerContext.java
          http://jenkins-ci.org/commit/ghprb-plugin/882bbd79f73e2099c7c1125ce5994d0952cf4464
          Log:
          added Job DSL for GhprbTrigger

          [FIXES JENKINS-31214]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: pom.xml src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbContextExtensionPoint.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbExtensionContext.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbSimpleStatusContext.java src/main/java/org/jenkinsci/plugins/ghprb/jobdsl/GhprbTriggerContext.java http://jenkins-ci.org/commit/ghprb-plugin/882bbd79f73e2099c7c1125ce5994d0952cf4464 Log: added Job DSL for GhprbTrigger [FIXES JENKINS-31214]
          Show
          daspilker Daniel Spilker added a comment - PR: https://github.com/jenkinsci/ghprb-plugin/pull/229
          Hide
          arcivanov Arcadiy Ivanov added a comment -

          It would be a great addition, yes.

          Show
          arcivanov Arcadiy Ivanov added a comment - It would be a great addition, yes.
          Hide
          daspilker Daniel Spilker added a comment -

          I will contribute a pull request for the ghprb plugin if the maintainers support this move.

          I'm not sure if Honza Brázdil is still maintaining the plugin, so I'm putting David Tanner and Arcadiy Ivanov on CC.

          Show
          daspilker Daniel Spilker added a comment - I will contribute a pull request for the ghprb plugin if the maintainers support this move. I'm not sure if Honza Brázdil is still maintaining the plugin, so I'm putting David Tanner and Arcadiy Ivanov on CC.

            People

            Assignee:
            daspilker Daniel Spilker
            Reporter:
            daspilker Daniel Spilker
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: