Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31310

Databound constructor clean-up

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • subversion-plugin
    • Jenkins 1.609.1
      Workflow 1.10.1
      Subversion Plugin 2.5.3

      The workflow snippet generator is suggesting this when requested for a SVN step (under General SCM Step, since the simplified version does not accept credentials):

      checkout([$class: 'SubversionSCM', additionalCredentials: [], excludedCommitMessages: '', excludedRegions: '', excludedRevprop: '', excludedUsers: '', filterChangelog: false, ignoreDirPropChanges: false, includedRegions: '', locations: [[credentialsId: 'a30e416f-0240-4af6-bc4d-76a9f7a9de0e', depthOption: 'infinity', ignoreExternalsOption: true, local: '.', remote: 'http://svn.server/project/trunk']], workspaceUpdater: [$class: 'UpdateUpdater']])

      Only two fields where really configured: remote and credentialsId, so any other configuration is not really required. An appropriated @DataBoundConstructor in SubversionSCM using only required fields (and @DataBoundSetter 's) would substantially improve the generated groovy code.

            recena Manuel Recena Soto
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: