Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31344

Allow users to clear out individual approved signatures from the UI

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Major Major
    • script-security-plugin
    • workflow-1.10.1
      FreeBSD 10.2
      Jenkins 1.635
      OpenJDK 1.8.0_60-b24

      Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures with a "Clear Approvals" button (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

      This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

      https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java

          [JENKINS-31344] Allow users to clear out individual approved signatures from the UI

          Mark Austin created issue -
          Mark Austin made changes -
          Description Original: Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures "Clear Approvals" (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

          This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

          https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java#L142
          New: Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures with a "Clear Approvals" button (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

          This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

          https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
          Jesse Glick made changes -
          Component/s New: script-security-plugin [ 18520 ]
          Component/s Original: workflow-plugin [ 18820 ]
          Jesse Glick made changes -
          Labels New: ui
          Jesse Glick made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Jesse Glick made changes -
          Link New: This issue duplicates JENKINS-22660 [ JENKINS-22660 ]
          Jesse Glick made changes -
          Resolution New: Duplicate [ 3 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 166632 ] New: JNJira + In-Review [ 198022 ]

            jglick Jesse Glick
            ganthore Mark Austin
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: