Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31511

Recent (since 1.628) bug introduced into pluginManager filter UI

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core
    • Filter not working in 1.638, worked in 1.628

      Jenkins was, on typing characters into the filter section of the plugin window, filtering results, it no longer works as expected. Attached are screenshots for 1.628 and 1.638 for comparison. Note the filter string of "OWA" is reflected in 1.628, the other screenshot is 1.638 (version number is scrolled off the screen).

        1. Installed plugin filter2.png
          Installed plugin filter2.png
          235 kB
        2. Installed plugin filter1.png
          Installed plugin filter1.png
          159 kB

          [JENKINS-31511] Recent (since 1.628) bug introduced into pluginManager filter UI

          Ronald Gundlach-Chmara created issue -
          Christopher Simons made changes -
          Assignee New: Christopher Simons [ csimons ]
          Christopher Simons made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Christopher Simons added a comment - - edited

          Verified bug exists from Chrome in 46.0.2490.80 (Linux 64-bit) on repository tag 'jenkins-1.638' but does not exist on tag 'jenkins-1.628'.

          When testing, note that the search does not seem to be broken on the default tab, but is broken on the "Installed" tab. When entering a search term, the list results do seem to change sometimes, but more results are returned than are warranted by the search term.

          Results of git-bisect debugging:

          3b5424e507be2e59eabfd3f55ce16cd2b58a6195 is the first bad commit
commit 3b5424e507be2e59eabfd3f55ce16cd2b58a6195
Author: tfennelly <tom.fennelly@gmail.com>
Date:   Fri Sep 25 12:22:46 2015 +0100

    Only allow disable or uninstall when all dependants or dependencies are disabled/enabled

          Christopher Simons added a comment - - edited Verified bug exists from Chrome in 46.0.2490.80 (Linux 64-bit) on repository tag 'jenkins-1.638' but does not exist on tag 'jenkins-1.628'. When testing, note that the search does not seem to be broken on the default tab, but is broken on the "Installed" tab. When entering a search term, the list results do seem to change sometimes, but more results are returned than are warranted by the search term. Results of git-bisect debugging: 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 is the first bad commit commit 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 Author: tfennelly <tom.fennelly@gmail.com> Date: Fri Sep 25 12:22:46 2015 +0100 Only allow disable or uninstall when all dependants or dependencies are disabled/enabled
          Christopher Simons made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]

          Daniel Beck added a comment -

          csimons Are you planning to work on this as you assigned yourself?

          Daniel Beck added a comment - csimons Are you planning to work on this as you assigned yourself?

          Christopher Simons added a comment - - edited

          danielbeck Initially I planned to fix this but have since gotten sidetracked by other demands. I've unassigned this.

          Christopher Simons added a comment - - edited danielbeck Initially I planned to fix this but have since gotten sidetracked by other demands. I've unassigned this.
          Christopher Simons made changes -
          Assignee Original: Christopher Simons [ csimons ]
          Daniel Beck made changes -
          Labels New: lts-candidate regression

          Daniel Beck added a comment -

          This is funny – the filtering actually works, but it also considers plugins that have an (explicit or implied) dependency on any plugin with that name. In the case of OWASP Markup Formatter Plugin, this is (due to how dependencies to detached-from-core plugins work and when this one was detached from core) almost every plugin. If you filter for a string that does not match any plugin that has been detached from core (mostly what Jenkins came bundled with), it works as expected.

          Not sure whether this is deliberate. Pinging tfennelly to shed some light on this.

          Daniel Beck added a comment - This is funny – the filtering actually works, but it also considers plugins that have an (explicit or implied) dependency on any plugin with that name. In the case of OWASP Markup Formatter Plugin, this is (due to how dependencies to detached-from-core plugins work and when this one was detached from core) almost every plugin. If you filter for a string that does not match any plugin that has been detached from core (mostly what Jenkins came bundled with), it works as expected. Not sure whether this is deliberate. Pinging tfennelly to shed some light on this.

            Unassigned Unassigned
            ronabop Ronald Gundlach-Chmara
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: