Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31596

The MasterKillSwitchConfiguration should always be relevant if security is enabled

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Follow-up to JENKINS-31591, there are some plugins that provide additional conditions under which the MasterKillSwitchConfiguration could become relevant. The primary case is the swarm plugin, but there are other cases.

      It would make sense to provide an extension point such that plugins can contribute additional cases where the configuration is relevant.

      The MasterKillSwitchConfiguration should always be relevant when security is enabled and the user has RUN_SCRIPTS

          [JENKINS-31596] The MasterKillSwitchConfiguration should always be relevant if security is enabled

          Stephen Connolly created issue -

          Stephen Connolly added a comment -

          https://github.com/jenkinsci/jenkins/pull/1917

          Stephen Connolly added a comment - https://github.com/jenkinsci/jenkins/pull/1917
          Stephen Connolly made changes -
          Assignee New: Stephen Connolly [ stephenconnolly ]
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java
          http://jenkins-ci.org/commit/jenkins/fc582bae19c562a59400889e95eab754914ee094
          Log:
          [FIXED JENKINS-31596] Provide an extension point for MasterKillSwitchConfiguration relevance

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java http://jenkins-ci.org/commit/jenkins/fc582bae19c562a59400889e95eab754914ee094 Log: [FIXED JENKINS-31596] Provide an extension point for MasterKillSwitchConfiguration relevance
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java
          http://jenkins-ci.org/commit/jenkins/d00dc71b24dbfff8c5e6944c7776c9279bd6b5b0
          Log:
          Merge pull request #1917 from stephenc/jenkins-31596

          [FIXED JENKINS-31596] Provide an extension point for MasterKillSwitchConfiguration relevance

          Compare: https://github.com/jenkinsci/jenkins/compare/7ffefe190dff...d00dc71b24db

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java http://jenkins-ci.org/commit/jenkins/d00dc71b24dbfff8c5e6944c7776c9279bd6b5b0 Log: Merge pull request #1917 from stephenc/jenkins-31596 [FIXED JENKINS-31596] Provide an extension point for MasterKillSwitchConfiguration relevance Compare: https://github.com/jenkinsci/jenkins/compare/7ffefe190dff...d00dc71b24db

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4372
          [FIXED JENKINS-31596] Provide an extension point for MasterKillSwitchConfiguration relevance (Revision fc582bae19c562a59400889e95eab754914ee094)

          Result = SUCCESS
          stephen connolly : fc582bae19c562a59400889e95eab754914ee094
          Files :

          • core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4372 [FIXED JENKINS-31596] Provide an extension point for MasterKillSwitchConfiguration relevance (Revision fc582bae19c562a59400889e95eab754914ee094) Result = SUCCESS stephen connolly : fc582bae19c562a59400889e95eab754914ee094 Files : core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java
          Jesse Glick made changes -
          Labels New: security
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-31591 [ JENKINS-31591 ]

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: