Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31605

Plugin manager allows uninstalling bundled plugins

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: Minor Minor
    • core
    • Jenkins 1.638

      Introduced here:
      https://github.com/jenkinsci/jenkins/pull/1847/files#diff-c2decd7ac964b46c352a3960d1ffd9f1L114

      It's no longer relevant whether a plugin is bundled for whether it can be uninstalled. However, when you (schedule to) uninstall a bundled plugin, it'll just get reinstalled on restart.

      This check needs to be reinstated in addition to the dependencies check.

          [JENKINS-31605] Plugin manager allows uninstalling bundled plugins

          Daniel Beck created issue -
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-23150 [ JENKINS-23150 ]

          Tom FENNELLY added a comment -

          I've no problem with changing this to never allow bundled plugins to be uninstalled (it's easy), but I am curious to know exactly what problem it is causing? The only way you should be able to uninstall a plugin (bundled or otherwise) is if there's no other installed plugin depending on it.

          Tom FENNELLY added a comment - I've no problem with changing this to never allow bundled plugins to be uninstalled (it's easy), but I am curious to know exactly what problem it is causing? The only way you should be able to uninstall a plugin (bundled or otherwise) is if there's no other installed plugin depending on it.

          Tom FENNELLY added a comment -

          Actually, I didn't think this would be possible. I thought I introduced the concept of a "core" dependency and that this was added to all bundled plugins. Anyway ... just a thought and something else to check when fixing this.

          Tom FENNELLY added a comment - Actually, I didn't think this would be possible. I thought I introduced the concept of a "core" dependency and that this was added to all bundled plugins. Anyway ... just a thought and something else to check when fixing this.

          Daniel Beck added a comment -

          tfennelly The problem is that the behavior is unexpected. Rather than actually removing the plugin, you only effectively reset its version to the one that comes bundled. So changing back to not allowing this (while we still have bundled plugins) makes sense IMO.

          Daniel Beck added a comment - tfennelly The problem is that the behavior is unexpected. Rather than actually removing the plugin, you only effectively reset its version to the one that comes bundled. So changing back to not allowing this (while we still have bundled plugins) makes sense IMO.
          Daniel Beck made changes -
          Labels New: lts-candidate

          Tom FENNELLY added a comment -

          danielbeck I agree. Should be easy fix.

          Tom FENNELLY added a comment - danielbeck I agree. Should be easy fix.
          Tom FENNELLY made changes -
          Labels Original: lts-candidate New: lts-candidate regression
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 167037 ] New: JNJira + In-Review [ 182557 ]

          James Nord added a comment -

          I beleive this is now working in 2.x as there are no bundled plugins in OSS - only custom derivatives...

          James Nord added a comment - I beleive this is now working in 2.x as there are no bundled plugins in OSS - only custom derivatives...

            tfennelly Tom FENNELLY
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: