Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31631

JenkinsRule.submit should click YUI submit button

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      JenkinsRule.submit was calling HtmlFormUtil.submit for YUI submit <button> elements, which resulted in a submit on the form because <button> elements are implemented as Submittable in HtmlUnit.

      It should instead be doing a click on the YUI <button>.

        Attachments

          Activity

          tfennelly Tom FENNELLY created issue -
          Show
          tfennelly Tom FENNELLY added a comment - PR: https://github.com/jenkinsci/jenkins/pull/1918
          jglick Jesse Glick made changes -
          Field Original Value New Value
          Description {{JenkinsRule.submit}} was calling {{HtmlFormUtil.submit}} for YUI submit {{<button>}} elements, which resulted in a submit on the form because {{<button>}} elements are implemented as {{Submittable}}s in HtmlUnit.

          It should instead be doing a {{click}} on the YUI {{<button>}}.
          {{JenkinsRule.submit}} was calling {{HtmlFormUtil.submit}} for YUI submit {{<button>}} elements, which resulted in a submit on the form because {{<button>}} elements are implemented as {{Submittable}} in HtmlUnit.

          It should instead be doing a {{click}} on the YUI {{<button>}}.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          test/pom.xml
          test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/23276180209b40315d19ea1c143b69d348d607ae
          Log:
          Merge pull request #1918 from tfennelly/htmlunit-fixes

          [Fixed JENKINS-31631] Handle YUI submit <button> clicks

          Compare: https://github.com/jenkinsci/jenkins/compare/d00dc71b24db...23276180209b

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: test/pom.xml test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/23276180209b40315d19ea1c143b69d348d607ae Log: Merge pull request #1918 from tfennelly/htmlunit-fixes [Fixed JENKINS-31631] Handle YUI submit <button> clicks Compare: https://github.com/jenkinsci/jenkins/compare/d00dc71b24db...23276180209b
          tfennelly Tom FENNELLY made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          olivergondza Oliver Gondža made changes -
          Labels lts-candidate
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          Log:
          JENKINS-31631 Handle YUI submit <button> clicks

          (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/5defc349a8894bbc6dd524e6f9ba9c1fc5662e52 Log: JENKINS-31631 Handle YUI submit <button> clicks (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          test/pom.xml
          http://jenkins-ci.org/commit/jenkins/0056b55146cb1948e3a828a905f543a1c540ab22
          Log:
          JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger

          (cherry picked from commit aec2d8afb1391b479e2531c0d49c211f81aba8b3)

          Compare: https://github.com/jenkinsci/jenkins/compare/b66128c31744...0056b55146cb

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/pom.xml http://jenkins-ci.org/commit/jenkins/0056b55146cb1948e3a828a905f543a1c540ab22 Log: JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger (cherry picked from commit aec2d8afb1391b479e2531c0d49c211f81aba8b3) Compare: https://github.com/jenkinsci/jenkins/compare/b66128c31744...0056b55146cb
          olivergondza Oliver Gondža made changes -
          Labels lts-candidate 1.625.3-fixed
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4373
          JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52)
          JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger (Revision 0056b55146cb1948e3a828a905f543a1c540ab22)

          Result = SUCCESS
          ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          Files :

          • test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          • test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java

          ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22
          Files :

          • test/pom.xml
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4373 JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52) JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger (Revision 0056b55146cb1948e3a828a905f543a1c540ab22) Result = SUCCESS ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52 Files : test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22 Files : test/pom.xml
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_2.0 #5
          JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52)
          JENKINS-31631 Exclude transitive htmlunit-core-js via (Revision 0056b55146cb1948e3a828a905f543a1c540ab22)

          Result = SUCCESS
          ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          Files :

          • test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          • test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java

          ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22
          Files :

          • test/pom.xml
          Show
          dogfood dogfood added a comment - Integrated in jenkins_2.0 #5 JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52) JENKINS-31631 Exclude transitive htmlunit-core-js via (Revision 0056b55146cb1948e3a828a905f543a1c540ab22) Result = SUCCESS ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52 Files : test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22 Files : test/pom.xml
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins-test-harness/bd76ca4d585295ca2395ed14868a7d7423932d44
          Log:
          JENKINS-31631 Handle YUI submit <button> clicks

          (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2)

          Originally-Committed-As: 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins-test-harness/bd76ca4d585295ca2395ed14868a7d7423932d44 Log: JENKINS-31631 Handle YUI submit <button> clicks (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2) Originally-Committed-As: 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 167065 ] JNJira + In-Review [ 198110 ]

            People

            Assignee:
            tfennelly Tom FENNELLY
            Reporter:
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: