Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31871

Jenkins improperly handles single quotes in item names

    XMLWordPrintable

    Details

    • Similar Issues:
    • URL:

      Description

      Jenkins does not prohibit creating of items like "Mike's test project". So you can create this item, but after that you won't be able to reliably access it.

      URL path shows "Problem accessing /job/Mike/'s/%20test%project".

      • The item cannot be opened within a folder
      • Field verification does not work in the item's configuration forms

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-36832 Javascript error on the configuration page when the item name contains a single quote

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32366 Cannot delete job named "Mike's test job"

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-36745 Block new item creation with single quote in name

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Progress

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            danielbeck Daniel Beck added a comment -

            FWIW I'd like to wait a bit longer with this change, to see whether someone/something is using the obscure feature we possibly broke.

            Show
            danielbeck Daniel Beck added a comment - FWIW I'd like to wait a bit longer with this change, to see whether someone/something is using the obscure feature we possibly broke.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Felix Belzunce Arcos
            Path:
            core/src/main/java/hudson/util/FormValidation.java
            http://jenkins-ci.org/commit/jenkins/bee66ede31d45b9d0814e4a45cbf2223585817e2
            Log:
            [FIXED JENKINS-31871] Properly handle single quotes in item names (#1943)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Felix Belzunce Arcos Path: core/src/main/java/hudson/util/FormValidation.java http://jenkins-ci.org/commit/jenkins/bee66ede31d45b9d0814e4a45cbf2223585817e2 Log: [FIXED JENKINS-31871] Properly handle single quotes in item names (#1943)
            Hide
            Permalink
            fbelzunc Félix Belzunce Arcos added a comment - - edited

            I was not able to re-produce the fact that the item with singles quotes cannot be opened within a folder. However, the Field verification is really an issue as Daniel Beck said.

            Oleg Nenashev What Jenkins version were you using?

            Show
            fbelzunc Félix Belzunce Arcos added a comment - - edited I was not able to re-produce the fact that the item with singles quotes cannot be opened within a folder. However, the Field verification is really an issue as Daniel Beck said. Oleg Nenashev What Jenkins version were you using?
            Hide
            Permalink
            danielbeck Daniel Beck added a comment - - edited

            * The item cannot be opened within a folder

            Cannot reproduce the problem on my system (behind Apache reverse proxy). Full project name: EXPERIMENTS/foo'br can be accessed without problem.

            Field verification does not work in the item's configuration forms

            That's because of a bug in FormValidation.CheckMethod or its use in the UI.

            Show
            danielbeck Daniel Beck added a comment - - edited * The item cannot be opened within a folder Cannot reproduce the problem on my system (behind Apache reverse proxy). Full project name: EXPERIMENTS/foo'br can be accessed without problem. Field verification does not work in the item's configuration forms That's because of a bug in FormValidation.CheckMethod or its use in the UI.
            Hide
            Permalink
            oleg_nenashev Oleg Nenashev added a comment -

            Workaround: Specify the project naming restriction patterns to warn users about the issue (see the attached screenshot)

            Show
            oleg_nenashev Oleg Nenashev added a comment - Workaround: Specify the project naming restriction patterns to warn users about the issue (see the attached screenshot)

              People

              Assignee:
              fbelzunc Félix Belzunce Arcos
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: