Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32252

Possible issue with how triggers are started

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Original reporter Pascal Widdershoven

      I noticed that when creating projects with this plugin the Github plugin doesn't create webhooks like it normally does on regular projects.

      I've debugged this issue a bit and noticed that on multi branch projects the Github trigger `start` method is always called with `newInstance = false` whereas on regular projects the it's called with newInstance = true. Looking at the code I think this could possibly originate from https://github.com/mjdetullio/multi-branch-project-plugin/blob/54d7e5ebde04a13469d96b883cb81ce11351164f/src/main/java/com/github/mjdetullio/jenkins/plugins/multibranch/FreeStyleMultiBranchProject.java#L964 where the start method is indeed called with newInstance=false.

      What I'm confused about however is whether the triggers should be started from the parent project at all or if they should be started on each child project. In any case the behavior of starting triggers seems to be different in multi branch projects vs regular projects. Matthew DeTullio can you help me understand this issue? If this is an actual issue I would like to fix it but I first want to make sure I fully understand the issue.

        Attachments

          Issue Links

            Activity

            mjdetullio Matthew DeTullio created issue -
            mjdetullio Matthew DeTullio made changes -
            Field Original Value New Value
            Description I noticed that when creating projects with this plugin the Github plugin doesn't create webhooks like it normally does on regular projects.

            I've debugged this issue a bit and noticed that on multi branch projects the Github trigger `start` method is always called with `newInstance = false` whereas on regular projects the it's called with newInstance = true. Looking at the code I think this could possibly originate from [here](https://github.com/mjdetullio/multi-branch-project-plugin/blob/54d7e5ebde04a13469d96b883cb81ce11351164f/src/main/java/com/github/mjdetullio/jenkins/plugins/multibranch/FreeStyleMultiBranchProject.java#L964) where the start method is indeed called with `newInstance=false`.

            What I'm confused about however is whether the triggers should be started from the parent project at all or if they should be started on each child project. In any case the behavior of starting triggers seems to be different in multi branch projects vs regular projects. @mjdetullio can you help me understand this issue? If this is an actual issue I would like to fix it but I first want to make sure I fully understand the issue.
            Original reporter [~pascalw]

            I noticed that when creating projects with this plugin the Github plugin doesn't create webhooks like it normally does on regular projects.

            I've debugged this issue a bit and noticed that on multi branch projects the Github trigger `start` method is always called with `newInstance = false` whereas on regular projects the it's called with newInstance = true. Looking at the code I think this could possibly originate from [here](https://github.com/mjdetullio/multi-branch-project-plugin/blob/54d7e5ebde04a13469d96b883cb81ce11351164f/src/main/java/com/github/mjdetullio/jenkins/plugins/multibranch/FreeStyleMultiBranchProject.java#L964) where the start method is indeed called with `newInstance=false`.

            What I'm confused about however is whether the triggers should be started from the parent project at all or if they should be started on each child project. In any case the behavior of starting triggers seems to be different in multi branch projects vs regular projects. @mjdetullio can you help me understand this issue? If this is an actual issue I would like to fix it but I first want to make sure I fully understand the issue.
            mjdetullio Matthew DeTullio made changes -
            Description Original reporter [~pascalw]

            I noticed that when creating projects with this plugin the Github plugin doesn't create webhooks like it normally does on regular projects.

            I've debugged this issue a bit and noticed that on multi branch projects the Github trigger `start` method is always called with `newInstance = false` whereas on regular projects the it's called with newInstance = true. Looking at the code I think this could possibly originate from [here](https://github.com/mjdetullio/multi-branch-project-plugin/blob/54d7e5ebde04a13469d96b883cb81ce11351164f/src/main/java/com/github/mjdetullio/jenkins/plugins/multibranch/FreeStyleMultiBranchProject.java#L964) where the start method is indeed called with `newInstance=false`.

            What I'm confused about however is whether the triggers should be started from the parent project at all or if they should be started on each child project. In any case the behavior of starting triggers seems to be different in multi branch projects vs regular projects. @mjdetullio can you help me understand this issue? If this is an actual issue I would like to fix it but I first want to make sure I fully understand the issue.
            Original reporter [~pascalw]

            I noticed that when creating projects with this plugin the Github plugin doesn't create webhooks like it normally does on regular projects.

            I've debugged this issue a bit and noticed that on multi branch projects the Github trigger `start` method is always called with `newInstance = false` whereas on regular projects the it's called with newInstance = true. Looking at the code I think this could possibly originate from https://github.com/mjdetullio/multi-branch-project-plugin/blob/54d7e5ebde04a13469d96b883cb81ce11351164f/src/main/java/com/github/mjdetullio/jenkins/plugins/multibranch/FreeStyleMultiBranchProject.java#L964 where the start method is indeed called with {{newInstance=false}}.

            What I'm confused about however is whether the triggers should be started from the parent project at all or if they should be started on each child project. In any case the behavior of starting triggers seems to be different in multi branch projects vs regular projects. [~mjdetullio] can you help me understand this issue? If this is an actual issue I would like to fix it but I first want to make sure I fully understand the issue.
            mjdetullio Matthew DeTullio made changes -
            Component/s github-plugin [ 15896 ]
            tilorn Alexey Belaytzev made changes -
            Link This issue is blocking JENKINS-32639 [ JENKINS-32639 ]
            Hide
            integer Kanstantsin Shautsou added a comment -

            Not a github-plugin issue.

            Show
            integer Kanstantsin Shautsou added a comment - Not a github-plugin issue.
            integer Kanstantsin Shautsou made changes -
            Component/s github-plugin [ 15896 ]
            mdkf Michael Fowler made changes -
            Link This issue is duplicated by JENKINS-32440 [ JENKINS-32440 ]
            mdkf Michael Fowler made changes -
            Link This issue duplicates JENKINS-31737 [ JENKINS-31737 ]
            mjdetullio Matthew DeTullio made changes -
            Link This issue is duplicated by JENKINS-32440 [ JENKINS-32440 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 167837 ] JNJira + In-Review [ 182866 ]

              People

              Assignee:
              mjdetullio Matthew DeTullio
              Reporter:
              mjdetullio Matthew DeTullio
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: