Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32295

PEP8 warning priority is too high

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • warnings-plugin
    • None
    • Warnings plugin 4.51

    Description

      According to the pep8 tool documentation (https://pep8.readthedocs.org/en/latest/intro.html#error-codes), the reported warnings always are errors (E) or warnings (W).
      The Pep8Parser maps this categories to the HIGH priority.

      IMO, pep8 warnings are less important than other warnings like pylint and should not use the HIGH priority but LOW for warnings (W) and NORMAL for errors (E).

      Is this change acceptable ?

      Regards.

      Attachments

        Activity

          Descending order - Click to sort in ascending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          warnings
          http://jenkins-ci.org/commit/analysis-suite-plugin/b0b48021263dd2d263988fe798441541967b31b9
          Log:
          [FIXED JENKINS-32295] Reduce priorities of parser.

          Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/a10d9985ed92...b0b48021263d

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: warnings http://jenkins-ci.org/commit/analysis-suite-plugin/b0b48021263dd2d263988fe798441541967b31b9 Log: [FIXED JENKINS-32295] Reduce priorities of parser. Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/a10d9985ed92...b0b48021263d
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/warnings/parser/Pep8Parser.java
          src/test/java/hudson/plugins/warnings/parser/Pep8ParserTest.java
          src/test/resources/hudson/plugins/warnings/parser/pep8Test.txt
          http://jenkins-ci.org/commit/warnings-plugin/77c4b4d70b7419c923b679b61cdd182a6da99e4e
          Log:
          [FIXED JENKINS-32295] Reduce priorities of parser.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/warnings/parser/Pep8Parser.java src/test/java/hudson/plugins/warnings/parser/Pep8ParserTest.java src/test/resources/hudson/plugins/warnings/parser/pep8Test.txt http://jenkins-ci.org/commit/warnings-plugin/77c4b4d70b7419c923b679b61cdd182a6da99e4e Log: [FIXED JENKINS-32295] Reduce priorities of parser.
          drulli Ulli Hafner added a comment -

          The source code is quite simple, should not be hard to change the mapping:

          Currently there is support for different characters, I'm not sure where these are coming from... Feel free to change!

          drulli Ulli Hafner added a comment - The source code is quite simple, should not be hard to change the mapping: Pep8Parser Pep8ParserTest Example Log for Tests Currently there is support for different characters, I'm not sure where these are coming from... Feel free to change!
          jonathand131 Jonathan Delizy added a comment -

          I have never done that before but I could try.

          jonathand131 Jonathan Delizy added a comment - I have never done that before but I could try.
          drulli Ulli Hafner added a comment -

          Interested in providing a pull request? I don't use the pep parser by myself...

          drulli Ulli Hafner added a comment - Interested in providing a pull request? I don't use the pep parser by myself...

          People

            drulli Ulli Hafner
            jonathand131 Jonathan Delizy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: