Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32396

Option to suppress automatic SCM trigger

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      There should be an option to create branch projects automatically wherever a Jenkinsfile is detected, yet suppress the automatic SCM trigger which fires when branch indexing detects a new branch head. Manual or other automatic scheduled builds should still be possible.

      Needs to be supported as a configuration option at least at the level of a single multibranch project, or an organization folder. TBD whether there is a need to reinstate the built-in SCM trigger for certain branches, certain repos, etc.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Also probably the initial build #1 should not be automatically scheduled with this option enabled, though that can cause problems when you want to have an automatic trigger set up via the properties step—without the initial build, there will be no job properties, preventing a declarative trigger from being “bootstrapped”. Various implications need to be studied.

            Show
            jglick Jesse Glick added a comment - Also probably the initial build #1 should not be automatically scheduled with this option enabled, though that can cause problems when you want to have an automatic trigger set up via the properties step—without the initial build, there will be no job properties, preventing a declarative trigger from being “bootstrapped”. Various implications need to be studied.
            Hide
            choih Hyung Choi added a comment - - edited

            the initial build #1 should not be automatically scheduled with this option enabled

            I agree. We are looking for this option as well.

            We'd like flexible trigger option to be easily configurable in Jenkinsfile.

            Show
            choih Hyung Choi added a comment - - edited the initial build #1 should not be automatically scheduled with this option enabled I agree. We are looking for this option as well. We'd like flexible trigger option to be easily configurable in Jenkinsfile.
            Hide
            jglick Jesse Glick added a comment -

            PR 1 offered something similar, though it is very outdated and would need to be reworked to support organization folders.

            Show
            jglick Jesse Glick added a comment - PR 1 offered something similar, though it is very outdated and would need to be reworked to support organization folders.
            Hide
            jglick Jesse Glick added a comment -

            Released as 1.9-beta-1.

            Show
            jglick Jesse Glick added a comment - Released as 1.9-beta-1.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/jenkins/branch/BranchProperty.java
            src/main/java/jenkins/branch/NoTriggerBranchProperty.java
            src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            src/main/resources/jenkins/branch/Messages.properties
            src/main/resources/jenkins/branch/NoTriggerBranchProperty/config.jelly
            src/main/resources/jenkins/branch/NoTriggerBranchProperty/help.html
            src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/config.jelly
            src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/help-branches.html
            src/main/resources/jenkins/branch/harness/BranchProjectFactoryImpl/config.jelly
            src/test/java/jenkins/branch/NoTriggerBranchPropertyTest.java
            src/test/java/jenkins/branch/NoTriggerOrganizationFolderPropertyTest.java
            src/test/java/jenkins/branch/harness/BranchProjectFactoryImpl.java
            src/test/java/jenkins/branch/harness/MultiBranchImpl.java
            http://jenkins-ci.org/commit/branch-api-plugin/9468926111de0efcb5ecad4b4d66e6710a795008
            Log:
            [FIXED JENKINS-32396] Option to suppress automatic SCM trigger.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/jenkins/branch/BranchProperty.java src/main/java/jenkins/branch/NoTriggerBranchProperty.java src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java src/main/java/jenkins/branch/OrganizationFolder.java src/main/resources/jenkins/branch/Messages.properties src/main/resources/jenkins/branch/NoTriggerBranchProperty/config.jelly src/main/resources/jenkins/branch/NoTriggerBranchProperty/help.html src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/config.jelly src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/help-branches.html src/main/resources/jenkins/branch/harness/BranchProjectFactoryImpl/config.jelly src/test/java/jenkins/branch/NoTriggerBranchPropertyTest.java src/test/java/jenkins/branch/NoTriggerOrganizationFolderPropertyTest.java src/test/java/jenkins/branch/harness/BranchProjectFactoryImpl.java src/test/java/jenkins/branch/harness/MultiBranchImpl.java http://jenkins-ci.org/commit/branch-api-plugin/9468926111de0efcb5ecad4b4d66e6710a795008 Log: [FIXED JENKINS-32396] Option to suppress automatic SCM trigger.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/jenkins/branch/BranchIndexingCause.java
            src/main/java/jenkins/branch/BranchProperty.java
            src/main/java/jenkins/branch/NoTriggerBranchProperty.java
            src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            src/main/resources/jenkins/branch/Messages.properties
            src/main/resources/jenkins/branch/NoTriggerBranchProperty/config.jelly
            src/main/resources/jenkins/branch/NoTriggerBranchProperty/help.html
            src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/config.jelly
            src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/help-branches.html
            src/main/resources/jenkins/branch/harness/BranchProjectFactoryImpl/config.jelly
            src/test/java/jenkins/branch/NoTriggerBranchPropertyTest.java
            src/test/java/jenkins/branch/NoTriggerOrganizationFolderPropertyTest.java
            src/test/java/jenkins/branch/harness/BranchProjectFactoryImpl.java
            src/test/java/jenkins/branch/harness/MultiBranchImpl.java
            http://jenkins-ci.org/commit/branch-api-plugin/b02297b7ba5c01d40403540badb40b6087ff2394
            Log:
            Merge pull request #43 from jglick/NoTriggerBranchProperty-JENKINS-32396

            JENKINS-32396 Option to suppress automatic SCM trigger

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/0400b7dbb8dd...b02297b7ba5c

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/jenkins/branch/BranchIndexingCause.java src/main/java/jenkins/branch/BranchProperty.java src/main/java/jenkins/branch/NoTriggerBranchProperty.java src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java src/main/java/jenkins/branch/OrganizationFolder.java src/main/resources/jenkins/branch/Messages.properties src/main/resources/jenkins/branch/NoTriggerBranchProperty/config.jelly src/main/resources/jenkins/branch/NoTriggerBranchProperty/help.html src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/config.jelly src/main/resources/jenkins/branch/NoTriggerOrganizationFolderProperty/help-branches.html src/main/resources/jenkins/branch/harness/BranchProjectFactoryImpl/config.jelly src/test/java/jenkins/branch/NoTriggerBranchPropertyTest.java src/test/java/jenkins/branch/NoTriggerOrganizationFolderPropertyTest.java src/test/java/jenkins/branch/harness/BranchProjectFactoryImpl.java src/test/java/jenkins/branch/harness/MultiBranchImpl.java http://jenkins-ci.org/commit/branch-api-plugin/b02297b7ba5c01d40403540badb40b6087ff2394 Log: Merge pull request #43 from jglick/NoTriggerBranchProperty- JENKINS-32396 JENKINS-32396 Option to suppress automatic SCM trigger Compare: https://github.com/jenkinsci/branch-api-plugin/compare/0400b7dbb8dd...b02297b7ba5c
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/NoTriggerBranchPropertyWorkflowTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/882717d567e255d32547aa7a551016c0b1786fd7
            Log:
            JENKINS-32396 Integration test for NoTriggerBranchProperty and NoTriggerOrganizationFolderProperty.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/multibranch/NoTriggerBranchPropertyWorkflowTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/882717d567e255d32547aa7a551016c0b1786fd7 Log: JENKINS-32396 Integration test for NoTriggerBranchProperty and NoTriggerOrganizationFolderProperty.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/4e5b39efc03ff86836aa09f09a444fabc8c523d4
            Log:
            As of JENKINS-32396, JENKINS-32670 is irrelevant since we do have a legitimate BranchProperty.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/4e5b39efc03ff86836aa09f09a444fabc8c523d4 Log: As of JENKINS-32396 , JENKINS-32670 is irrelevant since we do have a legitimate BranchProperty.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowBranchProjectFactory.java
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/NoTriggerBranchPropertyWorkflowTest.java
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/5574409ef9334fb1774137627fe73f60174da515
            Log:
            Merge pull request #12 from jglick/update-no-trigger-JENKINS-32396-JENKINS-30206

            JENKINS-30206 JENKINS-32396 Honor changes to NoTriggerBranchProperty

            Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/eb538b808ee8...5574409ef933

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowBranchProjectFactory.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/NoTriggerBranchPropertyWorkflowTest.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/5574409ef9334fb1774137627fe73f60174da515 Log: Merge pull request #12 from jglick/update-no-trigger- JENKINS-32396 - JENKINS-30206 JENKINS-30206 JENKINS-32396 Honor changes to NoTriggerBranchProperty Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/eb538b808ee8...5574409ef933
            Hide
            arnaudeprez Arnaud Deprez added a comment -

            Hi,

            I don't think this issue is actually fixed.
            See my comment: https://github.com/jenkinsci/branch-api-plugin/pull/43#issuecomment-422763236

            Can we reopen it ?

            Show
            arnaudeprez Arnaud Deprez added a comment - Hi, I don't think this issue is actually fixed. See my comment: https://github.com/jenkinsci/branch-api-plugin/pull/43#issuecomment-422763236 Can we reopen it ?

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              owood Owen Wood
              Votes:
              6 Vote for this issue
              Watchers:
              18 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: