Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32571

Preserve original security settings after calling CLICommandInvoker.invoke()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      Calling CLICommandInvoker.invoke() changes Jenkins authorization as a side effect which means that many operations against Jenkins model failed later.

      It is a quite common to prepare data in Jenkins instance, call CLI command and verify the state of Jenkins model later.

      How-to reproduce:
      JenkinsRule j = new JenkinsRule();
j.createFreeStyleProject("aProject");
j.jenkins.getItem("aProject").getDisplayName() // OK -> 'aProject'
CLICommandInvoker command = new CLICommandInvoker(j, "version");
CLICommandInvoker.Result result = command.authorizedTo(Jenkins.READ).invoke();
j.jenkins.getItem("aProject").getDisplayName() // Fail -> NPE
      How-to fix:
      • in CLICommandInvoker.setAuth() save current SecurityRealm, AuthorizationStrategy and thread's SecurityContext
      • in CLICommandInvoker.invoke() after result = new Result(returnCode, out, err); call a new method restoreAuth()
      • implement a new method CLICommandInvoker.restoreAuth() where SecurityRealm, AuthorizationStrategy and thread's SecurityContext is set to previously saved values

          [JENKINS-32571] Preserve original security settings after calling CLICommandInvoker.invoke()

          Pavel Janoušek created issue -
          Pavel Janoušek made changes -
          Summary Original: CLICommandInvoker.invoke() changes security setting permanently as a side effect New: CLICommandInvoker.invoke() changes security settings permanently as a side effect
          Pavel Janoušek made changes -
          Summary Original: CLICommandInvoker.invoke() changes security settings permanently as a side effect New: Preserve original security settings after calling CLICommandInvoker.invoke()
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Pavel Janoušek made changes -
          Link New: This issue is blocking JENKINS-32535 [ JENKINS-32535 ]
          Jesse Glick made changes -
          Labels New: testing
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 168221 ] New: JNJira + In-Review [ 198377 ]

            pajasoft Pavel Janoušek
            pajasoft Pavel Janoušek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: