Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32823

Whole matrix is triggered when no chilren matched regexp.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: naginator-plugin
    • Labels:
      None
    • Environment:
      naginarot 1.16.1
    • Similar Issues:

      Description

      When no children matches regexp for their logs, whole matrix build is re-triggered (that is, all children are re-triggered).

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          ikedam ikedam added a comment -
          • Only failed parts are retriggered when rerunMatrixPart is checked.
          • Whole the matrix is retriggered if no children fail.
            • I guess this is for the case the parent fail (e.g. an aggregation fail). It makes sense to me.
            • This is a behavior before introducing regexp for child builds (1.15-).
          • This behavior is also applied when regexp doesn't match any children.

          So this behavior is consistent one.
          I think I need to introduce a checkbox "Don't retrigger a build when no children should be retriggered".

          Show
          ikedam ikedam added a comment - Only failed parts are retriggered when rerunMatrixPart is checked. Whole the matrix is retriggered if no children fail. I guess this is for the case the parent fail (e.g. an aggregation fail). It makes sense to me. This is a behavior before introducing regexp for child builds (1.15-). This behavior is also applied when regexp doesn't match any children. So this behavior is consistent one. I think I need to introduce a checkbox "Don't retrigger a build when no children should be retriggered".
          Hide
          Permalink
          ikedam ikedam added a comment -

          https://github.com/jenkinsci/naginator-plugin/pull/29

          Show
          ikedam ikedam added a comment - https://github.com/jenkinsci/naginator-plugin/pull/29
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/NoChildStrategy.java
          src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-noChildStrategy.html
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-rerunMatrixPart.html
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleActionTest.java
          http://jenkins-ci.org/commit/naginator-plugin/9ce342c9b75538c42d3581ddcc017aa4563ac3d3
          Log:
          [FIXED JENKINS-32823] Added "When no combinations to rerun"

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/NoChildStrategy.java src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-noChildStrategy.html src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-rerunMatrixPart.html src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java src/test/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleActionTest.java http://jenkins-ci.org/commit/naginator-plugin/9ce342c9b75538c42d3581ddcc017aa4563ac3d3 Log: [FIXED JENKINS-32823] Added "When no combinations to rerun"
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleAction.java
          src/main/java/com/chikli/hudson/plugin/naginator/NoChildStrategy.java
          src/main/java/com/chikli/hudson/plugin/naginator/RegexpForMatrixStrategy.java
          src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-noChildStrategy.html
          src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-rerunMatrixPart.html
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleActionTest.java
          src/test/java/com/chikli/hudson/plugin/naginator/testutils/MyBuilder.java
          http://jenkins-ci.org/commit/naginator-plugin/76c78c117b80c9a0ca803df49590a75f1dabf327
          Log:
          Merge pull request #29 from ikedam/feature/JENKINS-32823_NoTriggerForNoChild

          JENKINS-32823 [FIXED JENKINS-32821] Added "When no combinations to rerun" and "How to apply the regular expression to matrix"

          Compare: https://github.com/jenkinsci/naginator-plugin/compare/0f1e8f252788...76c78c117b80

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorListener.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisher.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleAction.java src/main/java/com/chikli/hudson/plugin/naginator/NoChildStrategy.java src/main/java/com/chikli/hudson/plugin/naginator/RegexpForMatrixStrategy.java src/main/resources/com/chikli/hudson/plugin/naginator/Messages.properties src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/config.jelly src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-noChildStrategy.html src/main/resources/com/chikli/hudson/plugin/naginator/NaginatorPublisher/help-rerunMatrixPart.html src/test/java/com/chikli/hudson/plugin/naginator/NaginatorPublisherTest.java src/test/java/com/chikli/hudson/plugin/naginator/NaginatorScheduleActionTest.java src/test/java/com/chikli/hudson/plugin/naginator/testutils/MyBuilder.java http://jenkins-ci.org/commit/naginator-plugin/76c78c117b80c9a0ca803df49590a75f1dabf327 Log: Merge pull request #29 from ikedam/feature/ JENKINS-32823 _NoTriggerForNoChild JENKINS-32823 [FIXED JENKINS-32821] Added "When no combinations to rerun" and "How to apply the regular expression to matrix" Compare: https://github.com/jenkinsci/naginator-plugin/compare/0f1e8f252788...76c78c117b80
          Hide
          Permalink
          ikedam ikedam added a comment -

          Fixed in naginator-1.17.

          Show
          ikedam ikedam added a comment - Fixed in naginator-1.17.

            People

            Assignee:
            ikedam ikedam
            Reporter:
            ikedam ikedam
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: