• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: promoted-builds-plugin
• Labels:

  None

[JENKINS-32993] PROMOTED_ID doesn't expose timestamp after JENKINS-24380

Félix Belzunce Arcos created issue - 2016-02-17 13:03

Félix Belzunce Arcos made changes - 2016-02-17 13:04

Description

Original: Before, Run.getId() was returning something like 2012-04-12_17-13-03, but with the change of JENKINS-24380 this is returning just the same than PROMOTED_NUMBER env var. So PROMOTED_NUMBER= PROMOTED_NUMBER {code:java}         e.put("PROMOTED_URL",rootUrl+target.getUrl());         e.put("PROMOTED_JOB_NAME", target.getParent().getName());         e.put("PROMOTED_JOB_FULL_NAME", target.getParent().getFullName());         e.put("PROMOTED_NUMBER", Integer.toString(target.getNumber()));         e.put("PROMOTED_ID", target.getId());         e.put("PROMOTED_DISPLAY_NAME", target.getDisplayName());         e.put("PROMOTED_USER_NAME", getUserName());         e.put("PROMOTED_USER_ID", getUserId()); {code} The correct fix is to maintain PROMOTED_ID for backward compatibility and create a new env var called PROMOTED_TIMESTAMP which will now exposed the timestamp on a standard way, something like 2016-02-17T10:46:14Z

New: Before, Run.getId() was returning something like 2012-04-12_17-13-03, but with the change of JENKINS-24380 this is returning just the same than PROMOTED_NUMBER env var. So PROMOTED_NUMBER= PROMOTED_NUMBER {code:java}         e.put("PROMOTED_URL",rootUrl+target.getUrl());         e.put("PROMOTED_JOB_NAME", target.getParent().getName());         e.put("PROMOTED_JOB_FULL_NAME", target.getParent().getFullName());         e.put("PROMOTED_NUMBER", Integer.toString(target.getNumber()));         e.put("PROMOTED_ID", target.getId());         e.put("PROMOTED_DISPLAY_NAME", target.getDisplayName());         e.put("PROMOTED_USER_NAME", getUserName());         e.put("PROMOTED_USER_ID", getUserId()); {code} The correct fix is to maintain PROMOTED_ID for backward compatibility and create a new env var called PROMOTED_TIMESTAMP which will now expose the timestamp on a standard way, something like 2016-02-17T10:46:14Z

Félix Belzunce Arcos made changes - 2016-02-17 13:11

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Félix Belzunce Arcos made changes - 2016-02-17 13:16

URL

New: https://github.com/jenkinsci/promoted-builds-plugin/pull/85

SCM/JIRA link daemon made changes - 2016-02-18 14:21

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

Original: JNJira [ 168817 ]

New: JNJira + In-Review [ 198471 ]