• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: credentials-plugin
• Labels:

  • icons
  • ui
• Environment:

  Hide

  Server:
  OS: Windows Home Server 2011 (64bit)
  Jenkins: 1.650
  JRE: 1.8.0_66-b18 according to /systeminfo
  Installation: Windows Installer, Windows Service
  
  Slave:
  OS: Windows 10 Professional (64bit)
  JRE: Version 8 update 71 (32bit)
  Browser: Chrome
  Installation: Windows Service
  
  Plugins:
  ant: 1.2
  antisamy-markup-formatter: 1.3
  change-assembly-version-plugin: 1.5.1
  console-tail: 1.1
  credentials: 1.25
  cvs: 2.12
  email-ext: 2.41.3
  external-monitor-job: 1.4
  gravatar: 2.1
  htmlpublisher: 1.11
  http-post: 1.2
  icon-shim: 2.0.3
  javadoc: 1.3
  junit: 1.11
  ldap: 1.11
  mailer: 1.16
  mapdb-api: 1.0.6.0
  matrix-auth: 1.3.2
  matrix-project: 1.6
  maven-plugin: 2.12.1
  msbuild: 1.25
  nunit: 0.17
  pam-auth: 1.2
  powershell: 1.3
  publish-over-cifs: 0.3
  publish-over-ftp: 1.11
  scm-api: 1.0
  script-security: 1.17
  simple-theme-plugin: 0.3
  ssh-credentials: 1.11
  ssh-slaves: 1.10
  subversion: 2.5.7
  svn-tag: 1.18
  token-macro: 1.12.1
  translation: 1.12
  windows-slaves: 1.1
  workflow-step-api: 1.14

  Show

  Server: OS: Windows Home Server 2011 (64bit) Jenkins: 1.650 JRE: 1.8.0_66-b18 according to /systeminfo Installation: Windows Installer, Windows Service Slave: OS: Windows 10 Professional (64bit) JRE: Version 8 update 71 (32bit) Browser: Chrome Installation: Windows Service Plugins: ant: 1.2 antisamy-markup-formatter: 1.3 change-assembly-version-plugin: 1.5.1 console-tail: 1.1 credentials: 1.25 cvs: 2.12 email-ext: 2.41.3 external-monitor-job: 1.4 gravatar: 2.1 htmlpublisher: 1.11 http-post: 1.2 icon-shim: 2.0.3 javadoc: 1.3 junit: 1.11 ldap: 1.11 mailer: 1.16 mapdb-api: 1.0.6.0 matrix-auth: 1.3.2 matrix-project: 1.6 maven-plugin: 2.12.1 msbuild: 1.25 nunit: 0.17 pam-auth: 1.2 powershell: 1.3 publish-over-cifs: 0.3 publish-over-ftp: 1.11 scm-api: 1.0 script-security: 1.17 simple-theme-plugin: 0.3 ssh-credentials: 1.11 ssh-slaves: 1.10 subversion: 2.5.7 svn-tag: 1.18 token-macro: 1.12.1 translation: 1.12 windows-slaves: 1.1 workflow-step-api: 1.14

1. 

   menu2.png

   52 kB

   2016-02-27 09:16

2. 

   menu.png

   6 kB

   2016-02-27 09:07

[JENKINS-33191] Credentials icon using wrong size and class name

Richard Moss created issue - 2016-02-27 09:10

Richard Moss made changes - 2016-02-27 09:11

Description

Original: The HTML for the credentials configuration link displayed in the sidebar is using the wrong image size - all the reset of the icons are 24x24, but credentials is using 48x48 and the wrong class name (plus multiple size attributes that contradict each other). {noformat}<img src="/static/1b3f74d9/plugin/credentials/images/48x48/credentials.png" style="width: 48px; height: 48px; width: 24px; height: 24px; margin: 2px;" class="icon-credentials-credentials icon-xlg">{noformat} In the above HTML, the source image is 48x48, the class name is {{icon-xlg}}, and there are two sets if {{width}} and {{height}} attributes, one for the correct {{24px}} and one for {{48px}} For reference, I included the img tag for the Manage link {noformat}<img src="/static/1b3f74d9/images/24x24/setting.png" style="width: 24px; height: 24px; width: 24px; height: 24px; margin: 2px;" class="icon-setting icon-md">{noformat} For whatever odd reason this too duplicates the {{width}} and {{height}} attributes, but the source image and all attributes are correctly {{24px}} and the class is {{icon-md}} Now this actually looks fine in the default Jenkins view, however when using third party themes (in my case the [Jenkins Material Theme|https://github.com/jenkins-contrib-themes/jenkins-material-theme/]) it causes a double size credentials icon. [^menu.png]

New: The HTML for the credentials configuration link displayed in the sidebar is using the wrong image size - all the rest of the icons are 24x24, but credentials is using 48x48 and the wrong class name (plus multiple size attributes that contradict each other). {noformat}<img src="/static/1b3f74d9/plugin/credentials/images/48x48/credentials.png" style="width: 48px; height: 48px; width: 24px; height: 24px; margin: 2px;" class="icon-credentials-credentials icon-xlg">{noformat} In the above HTML, the source image is 48x48, the class name is {{icon-xlg}}, and there are two sets if {{width}} and {{height}} attributes, one for the correct {{24px}} and one for {{48px}} For reference, I included the img tag for the Manage link {noformat}<img src="/static/1b3f74d9/images/24x24/setting.png" style="width: 24px; height: 24px; width: 24px; height: 24px; margin: 2px;" class="icon-setting icon-md">{noformat} For whatever odd reason this to duplicates the {{width}} and {{height}} attributes, but the source image and all attributes are correctly {{24px}} and the class is {{icon-md}} Now this actually looks fine in the default Jenkins view, however when using third party themes (in my case the [Jenkins Material Theme|https://github.com/jenkins-contrib-themes/jenkins-material-theme/]) it causes a double size credentials icon. [^menu.png]

Richard Moss made changes - 2016-02-27 09:16

Attachment

New: menu2.png [ 32061 ]

Richard Moss made changes - 2016-02-27 09:17

Summary

Original: Credentials icon using wrong sizes and class name

New: Credentials icon using wrong size and class name

Stephen Connolly made changes - 2016-05-20 21:39

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

SCM/JIRA link daemon made changes - 2016-05-23 11:10

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

Original: JNJira [ 169071 ]

New: JNJira + In-Review [ 198529 ]

Stephen Connolly made changes - 2017-08-29 13:19

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]