If you have some tool constantly pinging jobs/.../build?token=... but the job is stuck in the queue for a long time, you will get a CauseAction with a potentially unbounded number of causes, all identical RemoteCause instances. In a system with tens of thousands of build records loaded, there can be millions of such causes. This is a waste of heap space (and disk space, disk I/O time to load).

          [JENKINS-33467] CauseAction.causes can become huge

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Jesse Glick added a comment -

          JENKINS-4831 deduplicated the display, but not the storage.

          Jesse Glick added a comment - JENKINS-4831 deduplicated the display , but not the storage .
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-4831 [ JENKINS-4831 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 2114 (Web Link)" [ 14053 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/CauseAction.java
          test/src/test/java/hudson/model/QueueTest.java
          http://jenkins-ci.org/commit/jenkins/6ae54add5dd3f171cf7cca820ca2e5443ae34b14
          Log:
          [FIXED JENKINS-33467] Do not store redundant copies of Cause in CauseAction.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/CauseAction.java test/src/test/java/hudson/model/QueueTest.java http://jenkins-ci.org/commit/jenkins/6ae54add5dd3f171cf7cca820ca2e5443ae34b14 Log: [FIXED JENKINS-33467] Do not store redundant copies of Cause in CauseAction.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/Cause.java
          core/src/main/java/hudson/model/CauseAction.java
          test/src/test/java/hudson/model/QueueTest.java
          http://jenkins-ci.org/commit/jenkins/ed564e63643c35995e7833df04b71772ccd49074
          Log:
          Merge pull request #2114 from jglick/CauseAction-JENKINS-33467

          JENKINS-33467 Do not store duplicate Cause’s

          Compare: https://github.com/jenkinsci/jenkins/compare/c5a3b2f61f9b...ed564e63643c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/Cause.java core/src/main/java/hudson/model/CauseAction.java test/src/test/java/hudson/model/QueueTest.java http://jenkins-ci.org/commit/jenkins/ed564e63643c35995e7833df04b71772ccd49074 Log: Merge pull request #2114 from jglick/CauseAction- JENKINS-33467 JENKINS-33467 Do not store duplicate Cause’s Compare: https://github.com/jenkinsci/jenkins/compare/c5a3b2f61f9b...ed564e63643c

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4500
          [FIXED JENKINS-33467] Do not store redundant copies of Cause in (Revision 6ae54add5dd3f171cf7cca820ca2e5443ae34b14)

          Result = SUCCESS
          jesse glick : 6ae54add5dd3f171cf7cca820ca2e5443ae34b14
          Files :

          • test/src/test/java/hudson/model/QueueTest.java
          • core/src/main/java/hudson/model/CauseAction.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4500 [FIXED JENKINS-33467] Do not store redundant copies of Cause in (Revision 6ae54add5dd3f171cf7cca820ca2e5443ae34b14) Result = SUCCESS jesse glick : 6ae54add5dd3f171cf7cca820ca2e5443ae34b14 Files : test/src/test/java/hudson/model/QueueTest.java core/src/main/java/hudson/model/CauseAction.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/a57afbd1bc3fdeb47243696174d4b564ab50414f
          Log:
          JENKINS-33467 Noting merge of #2114.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/a57afbd1bc3fdeb47243696174d4b564ab50414f Log: JENKINS-33467 Noting merge of #2114.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: