-
Bug
-
Resolution: Duplicate
-
Major
-
None
-
Pipeline: Multibranch 1.15
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping".
I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin?
If there is a legit reason for this, then this message should be clarified better.
Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 . Why would we want to ignore PR's from the origin repo?
- duplicates
-
JENKINS-33161 Allow merge commits to be built from origin PRs
-
- Resolved
-
[JENKINS-33530] Pull Requests "submitted from origin repository, skipping" not clear why this is skipping
Jeff Koenig
created issue -
Jeff Koenig
made changes -
| Description |
Original:
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping". I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin? If there is a legit reason for this, then this message should be clarified better. |
New:
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping". I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin? If there is a legit reason for this, then this message should be clarified better. Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 , which is where the PR is coming from someone other then the specifed owner of the repo, but they may still be one of the owners of the repo. |
Jeff Koenig
made changes -
| Description |
Original:
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping". I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin? If there is a legit reason for this, then this message should be clarified better. Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 , which is where the PR is coming from someone other then the specifed owner of the repo, but they may still be one of the owners of the repo. |
New:
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping". I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin? If there is a legit reason for this, then this message should be clarified better. Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 |
Jeff Koenig
made changes -
| Description |
Original:
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping". I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin? If there is a legit reason for this, then this message should be clarified better. Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 |
New:
The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping". I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin? If there is a legit reason for this, then this message should be clarified better. Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 . Why would we want to ignore PR's from the origin repo? |
| Link |
New:
This issue duplicates |
| Resolution | New: Duplicate [ 3 ] | |
| Status | Original: Open [ 1 ] | New: Resolved [ 5 ] |
| Workflow | Original: JNJira [ 169462 ] | New: JNJira + In-Review [ 198608 ] |
| Component/s | New: pipeline-general [ 21692 ] |
| Component/s | Original: workflow-plugin [ 18820 ] |