• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: job-dsl-plugin
• Labels:

  None
• Environment:

  jenkins 1.625.3 LTS
  job-dsl plugin 1.42
  xunit plugin 1.93

[JENKINS-33554] Warning threshold defaults generated by the Job DSL Plugin don't match the GUI defaults

Dmitry Polyanitsa created issue - 2016-03-15 15:32

Dmitry Polyanitsa made changes - 2016-03-15 15:32

Description

Original: The default values for the thresholds are empty strings in the GUI, while in the Job DSL plugin they are zeroes. An empty threshold means it is not enforced, while a 0 one means there should not be any failures of this kind. Effectively, in the GUI the default is "enforce nothing, any number of errors is fine", while in the default DSL-generated job it's "strictly enforce everything, there should be no errors at all". While this bug is actually enforcing good practices, it is still a bug :) Faulty job example: {code:groovy} job('threshold-defaults-bug') {   publishers {     archiveXUnit {       jUnit {         pattern('test-results.xml')       }     }   } } {code} You can run it here: http://job-dsl.herokuapp.com/. Note that all the generated thresholds have 0s, not empty strings.

New: The default values for the thresholds are empty strings in the GUI, while in the Job DSL plugin they are zeroes. An empty threshold means it is not enforced, while a 0 one means there should not be any failures of this kind. Effectively, in the GUI the default is "enforce nothing, any number of errors is fine", while in the default DSL-generated job it's "strictly enforce everything, there should be no errors at all". While this bug is actually enforcing good practices, it is still a bug :) Faulty job example: {code:java} job('threshold-defaults-bug') {   publishers {     archiveXUnit {       jUnit {         pattern('test-results.xml')       }     }   } } {code} You can run it here: http://job-dsl.herokuapp.com/. Note that all the generated thresholds have 0s, not empty strings.

Dmitry Polyanitsa made changes - 2016-03-15 15:33

Environment

Original: jenkins 1.625.3 LTS job-dsl plugin 1.42 warnings plugin 4.50

New: jenkins 1.625.3 LTS job-dsl plugin 1.42 xunit plugin 1.93

Dmitry Polyanitsa made changes - 2016-03-15 15:34

Description

Original: The default values for the thresholds are empty strings in the GUI, while in the Job DSL plugin they are zeroes. An empty threshold means it is not enforced, while a 0 one means there should not be any failures of this kind. Effectively, in the GUI the default is "enforce nothing, any number of errors is fine", while in the default DSL-generated job it's "strictly enforce everything, there should be no errors at all". While this bug is actually enforcing good practices, it is still a bug :) Faulty job example: {code:java} job('threshold-defaults-bug') {   publishers {     archiveXUnit {       jUnit {         pattern('test-results.xml')       }     }   } } {code} You can run it here: http://job-dsl.herokuapp.com/. Note that all the generated thresholds have 0s, not empty strings.

New: The default values for the thresholds are empty strings in the GUI, while in the Job DSL plugin they are zeroes. An empty threshold means it is not enforced, while a 0 one means there should not be any failures of this kind. Effectively, in the GUI the default is "enforce nothing, any number of errors is fine", while in the default DSL-generated job it's "strictly enforce everything, there should be no errors at all". While this bug is actually promoting good practices, it is still a bug :) Faulty job example: {code:java} job('threshold-defaults-bug') {   publishers {     archiveXUnit {       jUnit {         pattern('test-results.xml')       }     }   } } {code} You can run it here: http://job-dsl.herokuapp.com/. Note that all the generated thresholds have 0s, not empty strings.

R. Tyler Croy made changes - 2016-07-25 23:52

Workflow

Original: JNJira [ 169499 ]

New: JNJira + In-Review [ 183526 ]

Jamie Tanna made changes - 2021-12-21 11:34

Assignee

Original: Daniel Spilker [ daspilker ]

New: Jamie Tanna [ jamietanna ]