[JENKINS-33695] Git plugin writing out incorrect settings

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: git-client-plugin, git-plugin
Labels:
None
Environment:
Jenkins: 1.653
git-client: 1.19.6
git: 2.4.3

Similar Issues:
Powered by SuggestiMate

Show

Consider the following excerpt from a job's config.xml:

<scm class="hudson.plugins.git.GitSCM" plugin="git@2.4.3">
<configVersion>2</configVersion>
<userRemoteConfigs>
<hudson.plugins.git.UserRemoteConfig>
<name>gitlab</name>
<url>[URL GOES HERE]</url>
<credentialsId>[CREDENTIAL]</credentialsId>
</hudson.plugins.git.UserRemoteConfig>
</userRemoteConfigs>
<branches>
<hudson.plugins.git.BranchSpec>
<name>*/nt-*</name>
</hudson.plugins.git.BranchSpec>
<hudson.plugins.git.BranchSpec>
<name>**/master</name>
</hudson.plugins.git.BranchSpec>
<hudson.plugins.git.BranchSpec>
<name>**/bleeding</name>
</hudson.plugins.git.BranchSpec>
[OTHER BRANCH DESIGNATIONS]
</branches>
<doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
<submoduleCfg class="list"/>
<extensions>
<hudson.plugins.git.extensions.impl.BuildChooserSetting>
<buildChooser class="hudson.plugins.git.util.InverseBuildChooser"/>
</hudson.plugins.git.extensions.impl.BuildChooserSetting>
<hudson.plugins.git.extensions.impl.BuildChooserSetting>
<buildChooser class="hudson.plugins.git.util.AncestryBuildChooser">
<maximumAgeInDays>14</maximumAgeInDays>
<ancestorCommitSha1></ancestorCommitSha1>
</buildChooser>
</hudson.plugins.git.extensions.impl.BuildChooserSetting>
<hudson.plugins.git.extensions.impl.MessageExclusion>
<excludedMessage>[REGEX HERE]</excludedMessage>
</hudson.plugins.git.extensions.impl.MessageExclusion>
</extensions>
</scm>

After reloading configurations from disk, the appropriate settings are displayed in the Additional Behvaiors area of the job's git configuration. However, if I change any of the settings and save the job, the <extensions> element is removed from the XML entirely, and the related configurations are annihilated.

Additionally, and this may require a new issue, out of these behaviors, only the first one is used: if I move the AncestryBuildChooser to the top of the element, only the commits younger than 14 days are built, but the InverseBuildChooser setting is ignored. If left in the current configuration, only the InverseBuildChooser setting is used, but Jenkins starts builds rapidly to catch up with the untested old commits, the majority of which will fail the build due to various changes over the years.

is related to

JENKINS-33811 git plugin or jenkins remove my "check to a subdirectory" field

Closed

JENKINS-35248 Additional Behaviours not saved when Jenkins updated

Closed

JENKINS-33564 Sections of "Git" SCM configuration can be X'd out but not restored

Closed

Zalan Meggyesi created issue - 2016-03-21 15:40

Zalan Meggyesi made changes - 2016-03-21 20:22

Description

Original: Consider the following excerpt from a job's config.xml:

{{<scm class="hudson.plugins.git.GitSCM" plugin="git@2.4.3">
    <configVersion>2</configVersion>
    <userRemoteConfigs>
      <hudson.plugins.git.UserRemoteConfig>
        <name>gitlab</name>
        <url>[URL GOES HERE]</url>
        <credentialsId>[CREDENTIAL]</credentialsId>
      </hudson.plugins.git.UserRemoteConfig>
    </userRemoteConfigs>
    <branches>
      <hudson.plugins.git.BranchSpec>
        <name>**/nt-**</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/master</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/bleeding</name>
      </hudson.plugins.git.BranchSpec>
[OTHER BRANCH DESIGNATIONS]
      </branches>
    <doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
    <submoduleCfg class="list"/>
    <extensions>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.InverseBuildChooser"/>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.AncestryBuildChooser">
          <maximumAgeInDays>14</maximumAgeInDays>
          <ancestorCommitSha1></ancestorCommitSha1>
        </buildChooser>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.MessageExclusion>
        <excludedMessage>[REGEX HERE]</excludedMessage>
      </hudson.plugins.git.extensions.impl.MessageExclusion>
    </extensions>
  </scm>}}

After reloading configurations from disk, the appropriate settings are displayed in the Additional Behvaiors area of the job's git configuration. However, if I change any of the settings and save the job, the {{<extensions>}} element is removed from the XML entirely, and the related configurations are annihilated.

Additionally, and this may require a new issue, out of these behaviors, only the first one is used: if I move the {{AncestryBuildChooser}} to the top of the element, only the commits younger than 14 days are built, but the {{InverseBuildChooser}} setting is ignored. If left in the current configuration, only the {{InverseBuildChooser}} setting is used, but Jenkins starts builds rapidly to catch up with the untested old commits, the majority of which will fail the build due to various changes over the years.

New: Consider the following excerpt from a job's config.xml:

{quote}<scm class="hudson.plugins.git.GitSCM" plugin="git@2.4.3">
    <configVersion>2</configVersion>
    <userRemoteConfigs>
      <hudson.plugins.git.UserRemoteConfig>
        <name>gitlab</name>
        <url>[URL GOES HERE]</url>
        <credentialsId>[CREDENTIAL]</credentialsId>
      </hudson.plugins.git.UserRemoteConfig>
    </userRemoteConfigs>
    <branches>
      <hudson.plugins.git.BranchSpec>
        <name>**/nt-**</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/master</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/bleeding</name>
      </hudson.plugins.git.BranchSpec>
[OTHER BRANCH DESIGNATIONS]
      </branches>
    <doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
    <submoduleCfg class="list"/>
    <extensions>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.InverseBuildChooser"/>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.AncestryBuildChooser">
          <maximumAgeInDays>14</maximumAgeInDays>
          <ancestorCommitSha1></ancestorCommitSha1>
        </buildChooser>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.MessageExclusion>
        <excludedMessage>[REGEX HERE]</excludedMessage>
      </hudson.plugins.git.extensions.impl.MessageExclusion>
    </extensions>
  </scm>{quote}

After reloading configurations from disk, the appropriate settings are displayed in the Additional Behvaiors area of the job's git configuration. However, if I change any of the settings and save the job, the {{<extensions>}} element is removed from the XML entirely, and the related configurations are annihilated.

Additionally, and this may require a new issue, out of these behaviors, only the first one is used: if I move the {{AncestryBuildChooser}} to the top of the element, only the commits younger than 14 days are built, but the {{InverseBuildChooser}} setting is ignored. If left in the current configuration, only the {{InverseBuildChooser}} setting is used, but Jenkins starts builds rapidly to catch up with the untested old commits, the majority of which will fail the build due to various changes over the years.

Zalan Meggyesi made changes - 2016-03-21 20:23

Description

Original: Consider the following excerpt from a job's config.xml:

{quote}<scm class="hudson.plugins.git.GitSCM" plugin="git@2.4.3">
    <configVersion>2</configVersion>
    <userRemoteConfigs>
      <hudson.plugins.git.UserRemoteConfig>
        <name>gitlab</name>
        <url>[URL GOES HERE]</url>
        <credentialsId>[CREDENTIAL]</credentialsId>
      </hudson.plugins.git.UserRemoteConfig>
    </userRemoteConfigs>
    <branches>
      <hudson.plugins.git.BranchSpec>
        <name>**/nt-**</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/master</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/bleeding</name>
      </hudson.plugins.git.BranchSpec>
[OTHER BRANCH DESIGNATIONS]
      </branches>
    <doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
    <submoduleCfg class="list"/>
    <extensions>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.InverseBuildChooser"/>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.AncestryBuildChooser">
          <maximumAgeInDays>14</maximumAgeInDays>
          <ancestorCommitSha1></ancestorCommitSha1>
        </buildChooser>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.MessageExclusion>
        <excludedMessage>[REGEX HERE]</excludedMessage>
      </hudson.plugins.git.extensions.impl.MessageExclusion>
    </extensions>
  </scm>{quote}

After reloading configurations from disk, the appropriate settings are displayed in the Additional Behvaiors area of the job's git configuration. However, if I change any of the settings and save the job, the {{<extensions>}} element is removed from the XML entirely, and the related configurations are annihilated.

Additionally, and this may require a new issue, out of these behaviors, only the first one is used: if I move the {{AncestryBuildChooser}} to the top of the element, only the commits younger than 14 days are built, but the {{InverseBuildChooser}} setting is ignored. If left in the current configuration, only the {{InverseBuildChooser}} setting is used, but Jenkins starts builds rapidly to catch up with the untested old commits, the majority of which will fail the build due to various changes over the years.

New: Consider the following excerpt from a job's config.xml:

<scm class="hudson.plugins.git.GitSCM" plugin="git@2.4.3">
    <configVersion>2</configVersion>
    <userRemoteConfigs>
      <hudson.plugins.git.UserRemoteConfig>
        <name>gitlab</name>
        <url>[URL GOES HERE]</url>
        <credentialsId>[CREDENTIAL]</credentialsId>
      </hudson.plugins.git.UserRemoteConfig>
    </userRemoteConfigs>
    <branches>
      <hudson.plugins.git.BranchSpec>
        <name>**/nt-**</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/master</name>
      </hudson.plugins.git.BranchSpec>
      <hudson.plugins.git.BranchSpec>
        <name>**/bleeding</name>
      </hudson.plugins.git.BranchSpec>
[OTHER BRANCH DESIGNATIONS]
      </branches>
    <doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
    <submoduleCfg class="list"/>
    <extensions>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.InverseBuildChooser"/>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.BuildChooserSetting>
        <buildChooser class="hudson.plugins.git.util.AncestryBuildChooser">
          <maximumAgeInDays>14</maximumAgeInDays>
          <ancestorCommitSha1></ancestorCommitSha1>
        </buildChooser>
      </hudson.plugins.git.extensions.impl.BuildChooserSetting>
      <hudson.plugins.git.extensions.impl.MessageExclusion>
        <excludedMessage>[REGEX HERE]</excludedMessage>
      </hudson.plugins.git.extensions.impl.MessageExclusion>
    </extensions>
  </scm>

After reloading configurations from disk, the appropriate settings are displayed in the Additional Behvaiors area of the job's git configuration. However, if I change any of the settings and save the job, the {{<extensions>}} element is removed from the XML entirely, and the related configurations are annihilated.

Additionally, and this may require a new issue, out of these behaviors, only the first one is used: if I move the {{AncestryBuildChooser}} to the top of the element, only the commits younger than 14 days are built, but the {{InverseBuildChooser}} setting is ignored. If left in the current configuration, only the {{InverseBuildChooser}} setting is used, but Jenkins starts builds rapidly to catch up with the untested old commits, the majority of which will fail the build due to various changes over the years.

Mark Waite made changes - 2016-03-22 00:23

Assignee

Original: Mark Waite [ markewaite ]

Mark Waite made changes - 2016-03-22 11:59

Comment

[ That's an interesting condition. As far as I understand the build chooser implementation, the implementation expects that you will choose one of them. As far as I can tell, you're correct that it is a bug that the plugin allows the user to write more than 1 build chooser setting to a job definition.

I don't know what it would mean to have multiple build choosers selected.

In my collection of 2100+ verification jobs, the 30 which include a BuildChooserSetting all have exactly 1 setting.

I believe it is intentional that only one of the build chooser setting values is used. ]

Mark Waite made changes - 2016-03-22 13:30

Assignee

New: Mark Waite [ markewaite ]

Mark Waite made changes - 2016-03-23 05:13

Link

New: This issue is related to ~~JENKINS-33564~~ [ ~~JENKINS-33564~~ ]

Mark Waite made changes - 2016-03-25 04:45

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

Mark Waite made changes - 2016-03-25 12:07

Link

New: This issue is related to ~~JENKINS-33811~~ [ ~~JENKINS-33811~~ ]

Mark Waite made changes - 2016-06-01 05:18

Link

New: This issue is related to ~~JENKINS-35248~~ [ ~~JENKINS-35248~~ ]

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

Original: JNJira [ 169659 ]

New: JNJira + In-Review [ 198656 ]

Assignee:: Mark Waite

Reporter:: Zalan Meggyesi

Votes:: 4 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 2016-03-21 15:40

Updated:: 2019-10-23 01:28

Resolved:: 2016-03-25 04:45

Jenkins

Details

Description

Attachments

Issue Links

Activity

People

Dates