Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33705

Security token not printed with proper line endings on Windows

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      While testing on Windows, I noticed that the security token is hiding in my logs! (see the attached screenshot).

      I have a feeling that this is because the security token is being logged with Unix-specific line endings \n instead of Windows ones \r\n.

      Ideally we should be using our logging framework or some cross-platform abstraction to make this a bit easier

      If you can't find the security token in the screenshot, it's only one line starting with "*****"

        1. spot-the-token.png
          spot-the-token.png
          61 kB

          [JENKINS-33705] Security token not printed with proper line endings on Windows

          R. Tyler Croy created issue -
          R. Tyler Croy made changes -
          Labels New: 2.0
          R. Tyler Croy made changes -
          Labels Original: 2.0 New: 2.0 testfest

          Daniel Beck added a comment -

          http://docs.oracle.com/javase/8/docs/api/java/lang/System.html#lineSeparator--

          Daniel Beck added a comment - http://docs.oracle.com/javase/8/docs/api/java/lang/System.html#lineSeparator--
          Daniel Beck made changes -
          Assignee New: Daniel Beck [ danielbeck ]

          Daniel Beck added a comment -

          PR at https://github.com/jenkinsci/jenkins/pull/2150

          Daniel Beck added a comment - PR at https://github.com/jenkinsci/jenkins/pull/2150
          Daniel Beck made changes -
          Remote Link New: This issue links to "PR 2150 (Web Link)" [ 14098 ]
          Daniel Beck made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/jenkins/install/SetupWizard.java
          http://jenkins-ci.org/commit/jenkins/012a92e7de75d10a90afa580badb843a7c5efb0d
          Log:
          [FIX JENKINS-33705] Use platform line endings

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/install/SetupWizard.java http://jenkins-ci.org/commit/jenkins/012a92e7de75d10a90afa580badb843a7c5efb0d Log: [FIX JENKINS-33705] Use platform line endings
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            danielbeck Daniel Beck
            rtyler R. Tyler Croy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: