I created a new Github Organization job called 'ffoo'. This automaically tried to connect to the Github Organization named, "ffoo". This organization does not exist on Github so Jenkins pulls in the default Github icon to represent the organization in the folder view. This default icon is not scaled and takes up a large percentage of my screen.

      Screen shot is attached. Select S,M,L for icon size has no effect.

          [JENKINS-33799] Githhub Organization Folder icon is not scaled

          Patrick Wolf created issue -
          Patrick Wolf made changes -
          Epic Link New: JENKINS-33810 [ 169285 ]
          Patrick Wolf made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          Daniel Beck added a comment -

          Not needed for 2.0 RC.

          Daniel Beck added a comment - Not needed for 2.0 RC.
          Daniel Beck made changes -
          Epic Link Original: JENKINS-33810 [ 169285 ]
          Daniel Beck made changes -
          Labels Original: 2.0-beta New: 2.0-beta 2.0-planned

          I think Daniel meant "this shouldn't have that epic link to JENKINS-33810 because it's not a fix in the core."

          I will operate under the assumption that this still needs to be fixed for RC. And FWIW I think this is a fix that needs to happen in core. But I'll investigate.

          Kohsuke Kawaguchi added a comment - I think Daniel meant "this shouldn't have that epic link to JENKINS-33810 because it's not a fix in the core." I will operate under the assumption that this still needs to be fixed for RC. And FWIW I think this is a fix that needs to happen in core. But I'll investigate.
          Kohsuke Kawaguchi made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Patrick Wolf added a comment -

          This also happens when I connect to a legitimate repo owner in GH. I dont know if it is only default pictures or with custom icons.

          Patrick Wolf added a comment - This also happens when I connect to a legitimate repo owner in GH. I dont know if it is only default pictures or with custom icons.

          Kohsuke Kawaguchi added a comment - - edited

          The problem is because default avatars like this is not responding to the size specifier parameter 's' unlike explicit avatars like this. Both images should be served as 100px by 100px but only the latter is.

          So the plugin ends up serving a URL to an <img> tag that's too big.

          To fix this in a plugin requires us to proxy, resize, and cache avatar images, which also requires up-to-date check. In contrast, we can fix this in the core much easily by just fixing the height and width settings to CSS.

          Kohsuke Kawaguchi added a comment - - edited The problem is because default avatars like this is not responding to the size specifier parameter 's' unlike explicit avatars like this . Both images should be served as 100px by 100px but only the latter is. So the plugin ends up serving a URL to an <img> tag that's too big. To fix this in a plugin requires us to proxy, resize, and cache avatar images, which also requires up-to-date check. In contrast, we can fix this in the core much easily by just fixing the height and width settings to CSS.
          Kohsuke Kawaguchi made changes -
          Epic Link New: JENKINS-33810 [ 169285 ]
          Kohsuke Kawaguchi made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: github-organization-folder-plugin [ 21427 ]

            kohsuke Kohsuke Kawaguchi
            hrmpw Patrick Wolf
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: