-
Task
-
Resolution: Done
-
Critical
-
Powered by SuggestiMate
https://github.com/jenkinsci/jenkins/pull/2117#issuecomment-200064473
BTW it would be prudent to prepare the patches to CustomOrganizationFolderDescriptor and/or EntityItemDescriptor to validate that your API works correctly even for nontrivial TopLevelItemDescriptors.
[JENKINS-33808] Prove that richer Create Item API works by implementing for GH Org folders.
So CustomOrganizationFolderDescriptor must implement the new quasi-overloads. Whether or not that in turn requires API additions to scm-api depends on what information is already available, and how differentiated you want to make the display for different kinds of organization folders.
First comments were addressed during the review process. Waiting for more feedback.
Based on discussion with recena jglick and danielbeck, the work by manuel in https://github.com/jenkinsci/jenkins/pull/2117 has sufficiently proven that this API is rich enough to support more complicated scenarios.
Code changed in jenkins
User: recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
src/main/java/jenkins/scm/impl/SingleSCMNavigator.java
http://jenkins-ci.org/commit/scm-api-plugin/3fcc5fe076e802c2e0aaa866fad7f21710559e7b
Log:
JENKINS-33808 New API for support Item Categorization
Code changed in jenkins
User: recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
http://jenkins-ci.org/commit/scm-api-plugin/4996fc14cbc6d1b36b91f4716954f1f79c76e932
Log:
JENKINS-33808 @jglick's comment was addressed
Code changed in jenkins
User: recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
http://jenkins-ci.org/commit/scm-api-plugin/5b289d622c0619298c33d0d5c8bba0ec338a7b08
Log:
JENKINS-33808 @jglick's comment was addressed
Code changed in jenkins
User: recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
src/main/java/jenkins/scm/impl/SingleSCMNavigator.java
http://jenkins-ci.org/commit/scm-api-plugin/044775aa99c5280db79a88a735082d4cb4ec2386
Log:
JENKINS-33808 Propagating the changes
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
src/main/java/jenkins/scm/impl/SingleSCMNavigator.java
src/main/resources/jenkins/scm/api/Messages.properties
src/main/resources/jenkins/scm/api/SCMNavigator/newInstanceDetails.jelly
src/main/resources/jenkins/scm/impl/Messages.properties
src/main/resources/jenkins/scm/impl/SingleSCMNavigator/newInstanceDetails.jelly
http://jenkins-ci.org/commit/scm-api-plugin/f5d41fd0238c01a920b1be8ab45444c91afa3b7c
Log:
JENKINS-33808 Polish details
Code changed in jenkins
User: recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
http://jenkins-ci.org/commit/scm-api-plugin/0afa7fb8c1b3c6ebef8ff90bad26650fa4a709f6
Log:
JENKINS-33808 Javadoc
Code changed in jenkins
User: recena
Path:
src/main/resources/jenkins/scm/api/SCMNavigator/newInstanceDetail.jelly
src/main/resources/jenkins/scm/api/SCMNavigator/newInstanceDetails.jelly
src/main/resources/jenkins/scm/impl/SingleSCMNavigator/newInstanceDetail.jelly
src/main/resources/jenkins/scm/impl/SingleSCMNavigator/newInstanceDetails.jelly
http://jenkins-ci.org/commit/scm-api-plugin/a8454d844b445709659b6e9f1fb3975d2b611962
Log:
JENKINS-33808 The right filename
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
src/main/java/jenkins/scm/impl/SingleSCMNavigator.java
src/main/resources/jenkins/scm/api/Messages.properties
src/main/resources/jenkins/scm/impl/SingleSCMNavigator/newInstanceDetails.jelly
http://jenkins-ci.org/commit/scm-api-plugin/1f5a956fe5f0e0a87f2fb6f786f513dde320481e
Log:
JENKINS-33808 @jglick's comments were addressed
Code changed in jenkins
User: Manuel Recena
Path:
src/main/resources/jenkins/scm/api/SCMNavigator/newInstanceDetail.jelly
src/main/resources/jenkins/scm/api/SCMNavigator/newInstanceDetails.jelly
src/main/resources/jenkins/scm/impl/SingleSCMNavigator/newInstanceDetail.jelly
http://jenkins-ci.org/commit/scm-api-plugin/26a04685a5b1d561d7c019f1263d2f52aeb2ee58
Log:
JENKINS-33808 @jglick's comments were addressed
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
src/main/resources/jenkins/scm/api/Messages.properties
src/main/resources/jenkins/scm/impl/Messages.properties
src/main/resources/jenkins/scm/impl/SingleSCMNavigator/newInstanceDetail.jelly
http://jenkins-ci.org/commit/scm-api-plugin/037bb06de2ad75b68e237d27b1b2f46bfbcc56be
Log:
JENKINS-33808 @jglick's comments were addressed
JENKINS-33808 @jglick's comments were addressed
JENKINS-33808 @jglick's comments were addressed
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
http://jenkins-ci.org/commit/scm-api-plugin/3034cb5707811cc02bdb79c68dbf364e596858a1
Log:
JENKINS-33808 @jglick's comments were addressed
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
http://jenkins-ci.org/commit/scm-api-plugin/b9793aec5a9cdcc19f2a82fb8e39d7eafadf370b
Log:
JENKINS-33808 @jglick's comments were addressed
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
http://jenkins-ci.org/commit/scm-api-plugin/5f90e8440fed3f1000151ae95029aaddd61567ae
Log:
JENKINS-33808 Javadoc reviewed
Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMNavigatorDescriptor.java
src/main/java/jenkins/scm/impl/SingleSCMNavigator.java
src/main/resources/jenkins/scm/api/Messages.properties
src/main/resources/jenkins/scm/api/SCMNavigator/newInstanceDetail.jelly
src/main/resources/jenkins/scm/impl/Messages.properties
http://jenkins-ci.org/commit/scm-api-plugin/410e10637cdf680e73d191d735b136e62178dc03
Log:
Merge pull request #9 from recena/JENKINS-33808
JENKINS-33808 New API for support Item Categorization
Compare: https://github.com/jenkinsci/scm-api-plugin/compare/cfa781a93d0a...410e10637cdf
Code changed in jenkins
User: recena
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/newInstanceDetail.jelly
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/newInstanceDetail.properties
src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
src/main/webapp/images/48x48/github-scmnavigator.png
http://jenkins-ci.org/commit/github-branch-source-plugin/3c7f5d7ed16784c9ef13ea53d233dcd94baa8df8
Log:
JENKINS-33808 Support for Item categorization
Code changed in jenkins
User: recena
Path:
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/newInstanceDetail.jelly
http://jenkins-ci.org/commit/github-branch-source-plugin/bde1a8eecdd32f9fb3ecbf661b0ece94bd76f52f
Log:
JENKINS-33808 newInstanceDetail.jelly is now provided from scm-api
Code changed in jenkins
User: recena
Path:
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
http://jenkins-ci.org/commit/github-branch-source-plugin/19c4bf370d45a5a47b9f767a6c15a64e552cd113
Log:
JENKINS-33808 getCategory() is defined by default in SCMNavigatorDescriptor()
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-excludes.html
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-includes.html
src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
http://jenkins-ci.org/commit/github-branch-source-plugin/1dd96440ab39ccbb5b1853612f7814894564aa46
Log:
JENKINS-33808 Merge commit
Code changed in jenkins
User: Manuel Recena
Path:
pom.xml
http://jenkins-ci.org/commit/github-branch-source-plugin/8fc7dfe0038f848a9d7bbee4a5725ee5a41a8bda
Log:
JENKINS-33808 Upgraded scm-api dependency
Code changed in jenkins
User: Manuel Recena
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/newInstanceDetail.jelly
src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/newInstanceDetail.properties
src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
src/main/webapp/images/48x48/github-scmnavigator.png
http://jenkins-ci.org/commit/github-branch-source-plugin/c4e5c2b829df22f4dd22fa623ca1938675dcfcb9
Log:
Merge pull request #37 from recena/JENKINS-33808
JENKINS-33808 Support for Item categorization
Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/b6e69107368c...c4e5c2b829df
Code changed in jenkins
User: recena
Path:
pom.xml
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/5c23fc93f5a45566c4c97f425c3e02943d5f92b7
Log:
JENKINS-33808 Support for Item categorization in Jenkins 2
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
http://jenkins-ci.org/commit/branch-api-plugin/d6a0d89418a26ba0bb8a654adbff4ee4d319adc7
Log:
JENKINS-33808 Some javadoc were reviewed and considered that all SCMNavigator will be part of nested-projects ItemCategory
Code changed in jenkins
User: Manuel Recena
Path:
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/ab854055946a155bcd3f1c30d1da83f499afc5c8
Log:
JENKINS-33808 Removed no needed methods
Code changed in jenkins
User: recena
Path:
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
http://jenkins-ci.org/commit/branch-api-plugin/2fd013c5b12ea794b800ad95e6e3443422f8760a
Log:
JENKINS-33808 Javadoc
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
http://jenkins-ci.org/commit/branch-api-plugin/65d718bec515a9364d3ffa2407eb29f763c01cdb
Log:
JENKINS-33808 The category definition has been delegate to SCMNavigatorDescriptor()
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
http://jenkins-ci.org/commit/branch-api-plugin/ac53bac9efbebaaea1b683c763f03d662547ad32
Log:
Merge branch 'JENKINS-33808' of github.com:recena/branch-api-plugin into JENKINS-33808
Code changed in jenkins
User: Manuel Recena
Path:
pom.xml
http://jenkins-ci.org/commit/branch-api-plugin/20ff9fddfd9888c8c3283dda9fb9cd4533fd4dac
Log:
JENKINS-33808 Upgraded scm-api dependency
Code changed in jenkins
User: Manuel Recena
Path:
pom.xml
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/172be45b9e1d126190639fd0ac2cba0be8907d3d
Log:
Merge pull request #33 from recena/JENKINS-33808
JENKINS-33808 Support for Item categorization
Compare: https://github.com/jenkinsci/branch-api-plugin/compare/253aa576f008...172be45b9e1d
Probably a generic implementation could be created in branch-api, but a nicer display would be possible with API additions to scm-api and matching implementation in github-branch-source etc.