Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33840

All stages colored red, after last stage failed.

      Given a Pipeline with a sequence of multiple stages, e.g.
      stage 'one'
      stage 'two'
      stage 'three'
      and the last one fails, in this example "three", the visualizing shows all stages in red, although only the last one failed. Expectation is that only the failed stage is colored red, and all others, that were processed successfully before, are colored green.

          [JENKINS-33840] All stages colored red, after last stage failed.

          Michael Hüttermann created issue -
          Michael Hüttermann made changes -
          Epic Link New: JENKINS-31152 [ 165808 ]

          Daniel Beck added a comment -

          Could you please provide a complete pipeline that demonstrates this problem?

          Daniel Beck added a comment - Could you please provide a complete pipeline that demonstrates this problem?

          All tests with more than one stage where a downstream stage fails shows the behavior. One example:

             stage 'Smoke'
             parallel firstBranch: {
                  echo "one"
              }, secondBranch: {
                  echo "two"
              }
            
              stage 'Unit Test'
              sh "${mvnHome}/bin/mvn clean test -f ppom.xml"
             

          The POM file in the second stage, named ppom.xml does not exist, and thus provokes a failure.This is great! But the first stage is also colored slighly red, and, to make it more confusing, the tooltip text over the stage stages "success". The first stage was processed successfully and thus the stage should be colored green, or slight green.

          Michael Hüttermann added a comment - All tests with more than one stage where a downstream stage fails shows the behavior. One example: stage 'Smoke' parallel firstBranch: { echo "one" }, secondBranch: { echo "two" } stage 'Unit Test' sh "${mvnHome}/bin/mvn clean test -f ppom.xml" The POM file in the second stage, named ppom.xml does not exist, and thus provokes a failure.This is great! But the first stage is also colored slighly red, and, to make it more confusing, the tooltip text over the stage stages "success". The first stage was processed successfully and thus the stage should be colored green, or slight green.
          Antonio Muñiz made changes -
          Assignee Original: Antonio Muñiz [ amuniz ]

          Daniel Beck added a comment -

          Not an expert with the Stage View, but judging from our screenshot at https://jenkins.io/images/pipeline-stage-view.png I'm pretty sure it's deliberate to indicate the pipeline runs that failed. Remember from JENKINS-33844, you may not be able to see the failing stage, so it helps to indicate which pipeline runs were successful, and which weren't.

          Daniel Beck added a comment - Not an expert with the Stage View, but judging from our screenshot at https://jenkins.io/images/pipeline-stage-view.png I'm pretty sure it's deliberate to indicate the pipeline runs that failed. Remember from JENKINS-33844 , you may not be able to see the failing stage, so it helps to indicate which pipeline runs were successful, and which weren't.

          OK, but I still believe that successfully passed stages should be, by definition, green, or at least light green, or green with red bars, or red with green bars, but not entirely (light) red.
          Good point: Not seeing the failing stage in long pipelines is a different point IMO though. If this is an issue for someone, you may want to consider pointing to the failed stage with additional, prominent text or any other reference, which is displayed at the most left. I assume it is directly clear that the pipeline run failed if the build itself failed thus has a red bubble in build history, thus just another link directly to the failed stage would help.

          Michael Hüttermann added a comment - OK, but I still believe that successfully passed stages should be, by definition, green, or at least light green, or green with red bars, or red with green bars, but not entirely (light) red. Good point: Not seeing the failing stage in long pipelines is a different point IMO though. If this is an issue for someone, you may want to consider pointing to the failed stage with additional, prominent text or any other reference, which is displayed at the most left. I assume it is directly clear that the pipeline run failed if the build itself failed thus has a red bubble in build history, thus just another link directly to the failed stage would help.
          Sam Van Oort made changes -
          Priority Original: Major [ 3 ] New: Minor [ 4 ]

          Sam Van Oort added a comment -

          Hi Micheal,
          As Daniel noted, this behavior is intentional; I am retagging this as an enhancement (and reducing priority) to look at if there might be a better way to indicate this graphically.

          Thanks,
          Sam

          Sam Van Oort added a comment - Hi Micheal, As Daniel noted, this behavior is intentional; I am retagging this as an enhancement (and reducing priority) to look at if there might be a better way to indicate this graphically. Thanks, Sam
          Sam Van Oort made changes -
          Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]

            Unassigned Unassigned
            michaelhuettermann Michael Hüttermann
            Votes:
            3 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: