Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34040

Add support for Pipeline plugin in the Delivery Pipeline plugin

      Add support for Pipeline plugin (formerly known as Workflow plugin) to the Delivery Pipeline plugin. The support is important to allow for improved visualization of pipelines created with the Pipeline plugin.

          [JENKINS-34040] Add support for Pipeline plugin in the Delivery Pipeline plugin

          I have the same issue, important to fix.

          Alexandre Navarro added a comment - I have the same issue, important to fix.

          Hi,

          Any updates?

          Dmytro Slupytskyi added a comment - Hi, Any updates?

          Tommy Tynjä added a comment - - edited

          It is still work in progress. Basic support is implemented though.

          dslupytskyi: if you want, you can check out my branch (https://github.com/tommysdk/delivery-pipeline-plugin/tree/JENKINS-34040) and review the current state. You can also build it yourself using "mvn install hpi:hpi" from that source root.

          Tommy Tynjä added a comment - - edited It is still work in progress. Basic support is implemented though. dslupytskyi : if you want, you can check out my branch (https://github.com/tommysdk/delivery-pipeline-plugin/tree/JENKINS-34040) and review the current state. You can also build it yourself using "mvn install hpi:hpi" from that source root.

          Hi, what is planned for support? Version and downstream deps?

          Kanstantsin Shautsou added a comment - Hi, what is planned for support? Version and downstream deps?

          Tommy Tynjä added a comment -

          integer Basic pipeline visualization in delivery pipeline view based on the workflow/pipeline plugin configuration with appropriate pipeline status (green/red). This currently works but has some minor details left. I think we could possibly release a first version soon and then just iterate and improve as we move along. It won't have as many configuration options (initially at least), but since it is a fundamentally different model configuration options will most likely diverge.

          Tommy Tynjä added a comment - integer Basic pipeline visualization in delivery pipeline view based on the workflow/pipeline plugin configuration with appropriate pipeline status (green/red). This currently works but has some minor details left. I think we could possibly release a first version soon and then just iterate and improve as we move along. It won't have as many configuration options (initially at least), but since it is a fundamentally different model configuration options will most likely diverge.

          Maybe you would be interested in https://github.com/jenkinsci/pipeline-view-plugin that has modern behaviours? It on top of pipeline but maybe it could be useful to refresh something.

          Kanstantsin Shautsou added a comment - Maybe you would be interested in https://github.com/jenkinsci/pipeline-view-plugin that has modern behaviours? It on top of pipeline but maybe it could be useful to refresh something.

          Tommy Tynjä added a comment -

          There has been development done here: https://github.com/tommysdk/delivery-pipeline-plugin/tree/JENKINS-34040

          It provides basic support but there are some identified issues which would be nice to have:
          [ ] Last run on failed builds
          [ ] Progress bar timing corresponding to actual stages/tasks
          [ ] Build failure should not mark all tasks as failed (mimic DPP behaviour)
          [ ] Number of pipeline instances per pipeline
          [ ] Enable start of new pipeline build?
          [ ] Show commit message

          It could be argued that the currently provided functionality is enough to satisfy this ticket and move the identified issues to separate tickets in JIRA.

          Tommy Tynjä added a comment - There has been development done here: https://github.com/tommysdk/delivery-pipeline-plugin/tree/JENKINS-34040 It provides basic support but there are some identified issues which would be nice to have: [ ] Last run on failed builds [ ] Progress bar timing corresponding to actual stages/tasks [ ] Build failure should not mark all tasks as failed (mimic DPP behaviour) [ ] Number of pipeline instances per pipeline [ ] Enable start of new pipeline build? [ ] Show commit message It could be argued that the currently provided functionality is enough to satisfy this ticket and move the identified issues to separate tickets in JIRA.

          Tommy Tynjä added a comment -

          Failed builds now properly showing time and duration of last run.

          Tommy Tynjä added a comment - Failed builds now properly showing time and duration of last run.

          Tommy Tynjä added a comment -

          Now able to start new pipeline builds from view and to configure the number of pipeline instances per pipeline.

          Tommy Tynjä added a comment - Now able to start new pipeline builds from view and to configure the number of pipeline instances per pipeline.

          Tommy Tynjä added a comment -

          There has been some more progress on this functionality. The following issues are still to be addressed:
          [ ] Build failure should not mark all tasks as failed (mimic DPP behaviour) when task nodes are configured (currently works if no tasks are defined)
          [ ] Progress bar timing
          [ ] Verify that commit messages are shown
          [ ] Increase test coverage

          Tommy Tynjä added a comment - There has been some more progress on this functionality. The following issues are still to be addressed: [ ] Build failure should not mark all tasks as failed (mimic DPP behaviour) when task nodes are configured (currently works if no tasks are defined) [ ] Progress bar timing [ ] Verify that commit messages are shown [ ] Increase test coverage

          Tommy Tynjä added a comment -

          Investigate how we can address usage of Pipeline Stage View 2.0 and if we can use APIs that are consistent between 1.x versions and 2.x.

          Tommy Tynjä added a comment - Investigate how we can address usage of Pipeline Stage View 2.0 and if we can use APIs that are consistent between 1.x versions and 2.x.

          Tommy Tynjä added a comment -

          Assure arrows are consistently shown as expected. Need to resolve task connections for workflow stages and set them on each stage.

          Tommy Tynjä added a comment - Assure arrows are consistently shown as expected. Need to resolve task connections for workflow stages and set them on each stage.

          Tommy Tynjä added a comment -

          Moving tasks out of scope for this ticket.
          See if a meta task connection can be added between stages.

          Tommy Tynjä added a comment - Moving tasks out of scope for this ticket. See if a meta task connection can be added between stages.

          Tommy Tynjä added a comment -

          Task connections implemented.
          After discussions among the maintainers we decided to cut the scope and focus on delivering this feature as an MVP.
          Only code review and possible refactoring improvements left to consider before delivery.

          Tommy Tynjä added a comment - Task connections implemented. After discussions among the maintainers we decided to cut the scope and focus on delivering this feature as an MVP. Only code review and possible refactoring improvements left to consider before delivery.

          Tommy Tynjä added a comment -

          WorkflowPipelineView and model.Task classes could use some more test coverage and possible refactorings.
          Development branch should be rebased with current master before opening a pull request to the upstream repository.

          Tommy Tynjä added a comment - WorkflowPipelineView and model.Task classes could use some more test coverage and possible refactorings. Development branch should be rebased with current master before opening a pull request to the upstream repository.

          Anthony Wat added a comment -

          Hi there, may I ask what the status is with this feature request?

          Anthony Wat added a comment - Hi there, may I ask what the status is with this feature request?

          Tommy Tynjä added a comment -

          anthonywat Hi! I would say that we are soon about to offer a first version of this functionality. Basic support is implemented with sufficient test coverage. With limited time to work on the plugin in January I would not expect this to be released before February.

          Tommy Tynjä added a comment - anthonywat Hi! I would say that we are soon about to offer a first version of this functionality. Basic support is implemented with sufficient test coverage. With limited time to work on the plugin in January I would not expect this to be released before February.

          Tommy Tynjä added a comment -

          PR: https://github.com/Diabol/delivery-pipeline-plugin/pull/228

          There is currently (706f650853304a5ece9aaf314dcae743616d9621) a limitation that it does not support multi branch pipelines (the wrong URL is specified towards the WF API thus returning a 404 from the WorkflowApi class).

          Tommy Tynjä added a comment - PR: https://github.com/Diabol/delivery-pipeline-plugin/pull/228 There is currently (706f650853304a5ece9aaf314dcae743616d9621) a limitation that it does not support multi branch pipelines (the wrong URL is specified towards the WF API thus returning a 404 from the WorkflowApi class).

          Lars Lars added a comment -

          Any update on when this issue will be completed and released?

          Lars Lars added a comment - Any update on when this issue will be completed and released?

          Tommy Tynjä added a comment -

          redlars It is currently being tested on a set of production used Jenkins instance since a few weeks back to assure features, performance etc works as expected. Due to lack of feedback and contributions from the community, the progress if unfortunately slow since this feature is basically being developed on spare time hours. If you would be willing to contribute it would be much appreciated. You can check out the pull request mentioned above, try it out and give us feedback.

          Tommy Tynjä added a comment - redlars It is currently being tested on a set of production used Jenkins instance since a few weeks back to assure features, performance etc works as expected. Due to lack of feedback and contributions from the community, the progress if unfortunately slow since this feature is basically being developed on spare time hours. If you would be willing to contribute it would be much appreciated. You can check out the pull request mentioned above, try it out and give us feedback.

          Tommy Tynjä added a comment -

          Pull request merged: https://github.com/Diabol/delivery-pipeline-plugin/pull/228

          Will be available in version 1.0.0.

          Tommy Tynjä added a comment - Pull request merged: https://github.com/Diabol/delivery-pipeline-plugin/pull/228 Will be available in version 1.0.0.

          Tommy Tynjä added a comment -

          Released in 1.0.0.

          Tommy Tynjä added a comment - Released in 1.0.0.

            tommysdk Tommy Tynjä
            tommysdk Tommy Tynjä
            Votes:
            5 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved: