Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34093

2.0 introduces TopLevelItemDescriptor.LOGGER that is not private

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • core
    • None

      I may be missing the usage of this logger but I don't think it's needed to have default access by package (seems strange anyway)

      https://github.com/daniel-beck/jenkins/commit/1fe9cf7b7ada45230f2bc5b8e2f1bdb93175ff9f#diff-ad8ba48d76d0d0aa6faa012af1f42280R53

          [JENKINS-34093] 2.0 introduces TopLevelItemDescriptor.LOGGER that is not private

          James Nord created issue -
          James Nord made changes -
          Summary Original: 2.0 introduces TopLevelDescriptor.LOGGER that is not private New: 2.0 introduces TopLevelItemDescriptor.LOGGER that is not private

          Daniel Beck added a comment -

          Good catch, this actually changed which logger AbstractProject.AbstractProjectDescriptor methods referred to.

          Daniel Beck added a comment - Good catch, this actually changed which logger AbstractProject.AbstractProjectDescriptor methods referred to.
          Daniel Beck made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/TopLevelItemDescriptor.java
          http://jenkins-ci.org/commit/jenkins/b01a1b1c15b3ed17a5bb4d584218ef3e9cf3de3f
          Log:
          [FIX JENKINS-34093] Make logger field private

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/TopLevelItemDescriptor.java http://jenkins-ci.org/commit/jenkins/b01a1b1c15b3ed17a5bb4d584218ef3e9cf3de3f Log: [FIX JENKINS-34093] Make logger field private
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/TopLevelItemDescriptor.java
          http://jenkins-ci.org/commit/jenkins/4f51944cf1f9fcf4d8b5bb4a9671730bf455838c
          Log:
          Merge pull request #2271 from daniel-beck/JENKINS-34093

          [FIX JENKINS-34093] Make logger field private

          Compare: https://github.com/jenkinsci/jenkins/compare/51b70aea3754...4f51944cf1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/TopLevelItemDescriptor.java http://jenkins-ci.org/commit/jenkins/4f51944cf1f9fcf4d8b5bb4a9671730bf455838c Log: Merge pull request #2271 from daniel-beck/ JENKINS-34093 [FIX JENKINS-34093] Make logger field private Compare: https://github.com/jenkinsci/jenkins/compare/51b70aea3754...4f51944cf1f9
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 170121 ] New: JNJira + In-Review [ 198789 ]

            danielbeck Daniel Beck
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: