Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34120

Do not suppress unmergeable PRs

XMLWordPrintable

      If I create a PR in github, the build automatically gets created.

      However, if it fails, the next branch indexing log (which happened just after) does this:

      Getting remote pull requests...

    Checking pull request #PR-4
    Not mergeable, skipping

      This removes the build entirely - so one cannot find out why it failed.

      Incidentally, the "Not mergeable" isn't correct - it is mergeable, it's just Jenkins has reported a check-failure against it.

          [JENKINS-34120] Do not suppress unmergeable PRs

          magnayn created issue -

          Jesse Glick added a comment -

          Dubious. The stated error message indicates that GitHub considers the PR to not be mergeable without conflict. Has nothing to do with Jenkins build results.

          Jesse Glick added a comment - Dubious. The stated error message indicates that GitHub considers the PR to not be mergeable without conflict. Has nothing to do with Jenkins build results.
          Jesse Glick made changes -
          Component/s Original: workflow-plugin [ 18820 ]
          Assignee Original: Jesse Glick [ jglick ]
          Description Original: If I create a PR in github, the build automatically gets created.

          However, if it fails, the next branch indexing log (which happened just after) does this:

          {{ Getting remote pull requests...

              Checking pull request #PR-4
              Not mergeable, skipping}}

          This removes the build entirely - so one cannot find out why it failed.

          Incidentally, the "Not mergeable" isn't correct - it is mergeable, it's just Jenkins has reported a check-failure against it.           		New: If I create a PR in github, the build automatically gets created.

          However, if it fails, the next branch indexing log (which happened just after) does this:

          {code:none}
          Getting remote pull requests...

              Checking pull request #PR-4
              Not mergeable, skipping
          {code}

          This removes the build entirely - so one cannot find out why it failed.

          Incidentally, the "Not mergeable" isn't correct - it is mergeable, it's just Jenkins has reported a check-failure against it.
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-33161 [ JENKINS-33161 ]

          Jesse Glick added a comment -

          I thought this was already filed, but cannot find it now. Anyway, the suggested resolution is simple: do not check mergeability during branch indexing, so always create the branch project; when performing the build, if there is a merge failure, fail the build.

          Jesse Glick added a comment - I thought this was already filed, but cannot find it now. Anyway, the suggested resolution is simple: do not check mergeability during branch indexing, so always create the branch project; when performing the build, if there is a merge failure, fail the build.
          Jesse Glick made changes -
          Summary Original: PRs that fail builds immediately disappear from the build list New: Do not suppress unmergeable PRs

          magnayn added a comment -

          When I looked in github, as far as it was concerned it was still mergeable; the only check that had failed (and the only one we use) was the Jenkins build.

          magnayn added a comment - When I looked in github, as far as it was concerned it was still mergeable; the only check that had failed (and the only one we use) was the Jenkins build.

          Manuel Recena Soto added a comment -

          jglick I agree with you. We can avoid that check mergeability.

          Manuel Recena Soto added a comment - jglick I agree with you. We can avoid that check mergeability.
          Manuel Recena Soto made changes -
          Assignee New: Manuel Recena Soto [ recena ]
          Manuel Recena Soto made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            recena Manuel Recena Soto
            magnayn magnayn
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: