[JENKINS-34239] GitHub Organization Folder not available as a new item without a restart - Jenkins Jira

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Minor
Resolution: Fixed
Component/s: branch-api-plugin
Labels:
- 2.0-rc
- testfest

Similar Issues:

Show

Description

Steps to reproduce it

Fresh installation of Jenkins (Jenkins ver. 2.0-rc-1)
We choose Recommended Plugins option
Items availables are: Freestyle project, Pipeline, External Job, Multi-configuration project, Folder, Multibranch Pipeline

Where is GitHub Organization?

Only if we acces to Manage Plugins >> Installed (tab) we see the following message:

Warning: This Jenkins instance requires a restart. Changing the state of plugins at this time is strongly discouraged. Restart Jenkins before proceeding.

After restarting, we can see the item GitHub Organization.

I see here two problems:

We need to restart Jenkins after the wizard installation
The warning message is completely hidden. It is difficult to know that you have to restart.

Attachments

Issue Links

is duplicated by

JENKINS-34842 Getting Started page broken

Closed

is related to

JENKINS-33106 CustomOrganizationFolderDescriptor does not work after a dynamic installation

Resolved

JENKINS-33950 Unbundled / implicit plugin dependencies may be installed multiple times

Resolved

links to

CloudBees Internal OSS-1402

PR 49

Activity

Ascending order - Click to sort in descending order

View 15 older comments

Ryan Campbell added a comment - 2016-09-02 21:46

This is still reproducible with Jenkins LTS 2.7.3 and github-organizational-folder 1.4.

Ryan Campbell added a comment - 2016-09-02 21:46 This is still reproducible with Jenkins LTS 2.7.3 and github-organizational-folder 1.4.

Jesse Glick added a comment - 2016-09-02 21:53

I am ignoring the original issue description, which was about messaging about plugins which request restart (as a workaround for some buggy behavior), and focusing on why the fix of ~~JENKINS-33106~~ did not suffice to make this plugin not require restart.

Jesse Glick added a comment - 2016-09-02 21:53 I am ignoring the original issue description, which was about messaging about plugins which request restart (as a workaround for some buggy behavior), and focusing on why the fix of JENKINS-33106 did not suffice to make this plugin not require restart.

Jesse Glick added a comment - 2016-09-02 22:25

Amending steps to reproduce interactively from ~~JENKINS-33106~~ to work in 2.7.3 is trickier due to security setup and ~~JENKINS-18114~~, so it is more manual, but anyway the deployment step looks like

java -jar /tmp/WEB-INF/jenkins-cli.jar -s http://localhost:8080/ install-plugin -deploy cloudbees-folder scm-api structs $(pwd)/target/branch-api.hpi workflow-multibranch github-branch-source

Note the order of the last two items, which I think is the key.

Jesse Glick added a comment - 2016-09-02 22:25 Amending steps to reproduce interactively from JENKINS-33106 to work in 2.7.3 is trickier due to security setup and JENKINS-18114 , so it is more manual, but anyway the deployment step looks like java -jar /tmp/WEB-INF/jenkins-cli.jar -s http://localhost:8080/ install-plugin -deploy cloudbees-folder scm-api structs $(pwd)/target/branch-api.hpi workflow-multibranch github-branch-source Note the order of the last two items, which I think is the key.

SCM/JIRA link daemon added a comment - 2016-09-02 23:28

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/e05c287883ec4b46b4820004d9d540ef70c12cea
Log:
[FIXED JENKINS-34239] Need to rerun doAddSpecificDescriptors in case a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.

SCM/JIRA link daemon added a comment - 2016-09-02 23:28 Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java http://jenkins-ci.org/commit/branch-api-plugin/e05c287883ec4b46b4820004d9d540ef70c12cea Log: [FIXED JENKINS-34239] Need to rerun doAddSpecificDescriptors in case a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.

SCM/JIRA link daemon added a comment - 2016-09-03 01:34

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/d297b9480b5fddfeacc878f832ef352926fecfd6
Log:
[FIXED JENKINS-34239] Need to rerun doAddSpecificDescriptors in case a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.

SCM/JIRA link daemon added a comment - 2016-09-03 01:34 Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java http://jenkins-ci.org/commit/branch-api-plugin/d297b9480b5fddfeacc878f832ef352926fecfd6 Log: [FIXED JENKINS-34239] Need to rerun doAddSpecificDescriptors in case a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.

Jenkins

GitHub Organization Folder not available as a new item without a restart