Weird, I thought jglick fixed this?

danielbeck I have a PR for this, it's a duplicate of JENKINS-33950

Reproduced the problem with Jenkins 2.0 RC, installing recommended plugins.

Interesting. Groovy script console:

hudson.ExtensionList.lookup(TopLevelItemDescriptor).each {
  println it
  println it.displayName
}

Output:

hudson.model.FreeStyleProject$DescriptorImpl@a75b92e
Freestyle project
org.jenkinsci.plugins.workflow.job.WorkflowJob$DescriptorImpl@36d0805f
Pipeline
hudson.model.ExternalJob$DescriptorImpl@329bf916
External Job
jenkins.branch.OrganizationFolder$DescriptorImpl@1dfe2d4f
Folder
com.cloudbees.hudson.plugins.folder.Folder$DescriptorImpl@1a50aceb
Folder
hudson.matrix.MatrixProject$DescriptorImpl@268885cc
Multi-configuration project
org.jenkinsci.plugins.workflow.multibranch.WorkflowMultiBranchProject$DescriptorImpl@4d0827d7
Multibranch Pipeline

danielbeck yes, sorry misunderstood. The PR fixes 'restart required'. It seems there's still an issue getting GitHub Org Folders in the new item list.

This was the jglick's PR related with Restarting required, IMO the problem here is different.

recena I've relabeled this, as 'restart required', it's a duplicate of the issue I referenced. However, even with that fixed, GHO still doesn't show up. This may be an ordering issue between the plugins being dynamically loaded, which it looks like that PR was intended to solve but apparently didn't in some case (maybe requiring work elsewhere to make it reliable).

kzantow Thanks for your feedback. Remember I noticed two things here:

1. We need to restart Jenkins after the wizard installation. There is an issue for that .
2. The warning message is completely hidden. It is difficult to know whether you have to restart.

As github-organization-folder 1.2 is picked up by the setup wizard this is not happening anymore (manually tested).

However the message Warning: This Jenkins instance requires a restart. Changing the state of plugins at this time is strongly discouraged. Restart Jenkins before proceeding. is still there, but it seems to be worked out in JENKINS-33950, so I think this issue can be closed.

Mmmm, right, I thought this https://github.com/jenkinsci/github-organization-folder-plugin/pull/9 was already released. At any rate, Github Organization new item type is showing up now (without restarting), not sure what have changed since yesterday.

I started a new instance from scratch and it not showing the item type again... perhaps it is affected by the load order ( ? )

I'm going to try it again.

shott85 reported today that this is still an issue. He had a fresh install and the GH Org item type did not display until he restarted.

This is still reproducible with Jenkins LTS 2.7.3 and github-organizational-folder 1.4.

I am ignoring the original issue description, which was about messaging about plugins which request restart (as a workaround for some buggy behavior), and focusing on why the fix of JENKINS-33106 did not suffice to make this plugin not require restart.

Amending steps to reproduce interactively from JENKINS-33106 to work in 2.7.3 is trickier due to security setup and JENKINS-18114, so it is more manual, but anyway the deployment step looks like

java -jar /tmp/WEB-INF/jenkins-cli.jar -s http://localhost:8080/ install-plugin -deploy cloudbees-folder scm-api structs $(pwd)/target/branch-api.hpi workflow-multibranch github-branch-source

Note the order of the last two items, which I think is the key.

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/e05c287883ec4b46b4820004d9d540ef70c12cea
Log:
[FIXED JENKINS-34239] Need to rerun doAddSpecificDescriptors in case a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
src/test/java/jenkins/branch/CustomOrganizationFolderDescriptorTest.java
http://jenkins-ci.org/commit/branch-api-plugin/d297b9480b5fddfeacc878f832ef352926fecfd6
Log:
[FIXED JENKINS-34239] Need to rerun doAddSpecificDescriptors in case a MultiBranchProjectFactoryDescriptor is added first, then a SCMNavigatorDescriptor.