Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34437

Enable amazon-ecr-plugin behind proxy

XMLWordPrintable

      amazon-ecr-plugin cannot currently be used behind a proxy.
      Connection attempts are getting connection timeout.

      One solution is to use Jenkins proxy settings.

          [JENKINS-34437] Enable amazon-ecr-plugin behind proxy

          Ivan Fernandez Calvo added a comment -

          As ndeloof said this is more a improvement to AWS Java SDK Plugin, I will adapt your PR to it

          Ivan Fernandez Calvo added a comment - As ndeloof said this is more a improvement to AWS Java SDK Plugin, I will adapt your PR to it

          Marcus Wallin added a comment -

          Have you done any progress on this or would you consider a PR?

          Currently there seem to be no code in this component, but would you consider an AmazonECRClientBuilder with the option to use Jenkins proxy configuration and other config (e.g. AmazonWebServicesCredentials)?

          Marcus Wallin added a comment - Have you done any progress on this or would you consider a PR? Currently there seem to be no code in this component, but would you consider an AmazonECRClientBuilder with the option to use Jenkins proxy configuration and other config (e.g. AmazonWebServicesCredentials)?

          Ivan Fernandez Calvo added a comment -

          vlatombe I was wondering if could we add a adapter/wrapper class to aws-java-sdk-plugin over AmazonClient to use the proxy configuration, but I am not sure because in aws-java-sdk-plugin there is not code is only some kind of installer for the SDK, Do it make sense?

          Ivan Fernandez Calvo added a comment - vlatombe I was wondering if could we add a adapter/wrapper class to aws-java-sdk-plugin over AmazonClient to use the proxy configuration, but I am not sure because in aws-java-sdk-plugin there is not code is only some kind of installer for the SDK, Do it make sense?

          Vincent Latombe added a comment -

          ifernandezcalvo Given the number of Client classes in aws-java-sdk, I don't think it would work. However a factory method producing the right ClientConfiguration object preconfigured with Jenkins proxy could be interesting.

          Vincent Latombe added a comment - ifernandezcalvo Given the number of Client classes in aws-java-sdk, I don't think it would work. However a factory method producing the right ClientConfiguration object preconfigured with Jenkins proxy could be interesting.

          Ivan Fernandez Calvo added a comment -

          vlatombe ok cool, I will make the PR in few days

          Ivan Fernandez Calvo added a comment - vlatombe ok cool, I will make the PR in few days

          Markus Pöschl added a comment -

          PR is through

          Markus Pöschl added a comment - PR is through

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ivan Fernandez Calvo
          Path:
          src/main/java/com/amazonaws/AmazonECRClientFactory.java
          http://jenkins-ci.org/commit/aws-java-sdk-plugin/76824efc621ced9983dc7839c89b2059ee8c6e47
          Log:
          JENKINS-34437 Factory to use Jenkins Proxy configuration with a AmazonECRClient. (#10)

          • Factory to use Jenkins Proxy configuration with a AmazonECRClient.
          • minimise class

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Fernandez Calvo Path: src/main/java/com/amazonaws/AmazonECRClientFactory.java http://jenkins-ci.org/commit/aws-java-sdk-plugin/76824efc621ced9983dc7839c89b2059ee8c6e47 Log: JENKINS-34437 Factory to use Jenkins Proxy configuration with a AmazonECRClient. (#10) Factory to use Jenkins Proxy configuration with a AmazonECRClient. minimise class

          Ivan Fernandez Calvo added a comment -

          now I have to make the changes on ECR and upgrade the version of aws-java-sdk to 1.11.68.1

          Ivan Fernandez Calvo added a comment - now I have to make the changes on ECR and upgrade the version of aws-java-sdk to 1.11.68.1

          Ivan Fernandez Calvo added a comment -

          The PR is in review

          Ivan Fernandez Calvo added a comment - The PR is in review

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ivan Fernandez Calvo
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java
          src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java
          src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryTokenSource.java
          http://jenkins-ci.org/commit/amazon-ecr-plugin/a5e88f2b303f590310994abd4278ffde70e38a3e
          Log:
          JENKINS-34437 Enable amazon-ecr-plugin behind proxy (#9)

          • upgrade parent pom
            set minor version to 1.651.3
            upgrade Credentials Plugin
            upgrade AWS Java SDK Plugin
            upgrade AWS Credentials Plugin
            upgrade Docket Commons Plugin
          • add support to proxy configuration
            change deprecated annotations
          • change deprecated annotations
          • improve log
          • improve log
          • improve performance on getDescription there was a call to getCredentials that consumes too much time and it is not need
            improve log in FINEST and ALL levels
          • Update pom.xml

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Fernandez Calvo Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryTokenSource.java http://jenkins-ci.org/commit/amazon-ecr-plugin/a5e88f2b303f590310994abd4278ffde70e38a3e Log: JENKINS-34437 Enable amazon-ecr-plugin behind proxy (#9) upgrade parent pom set minor version to 1.651.3 upgrade Credentials Plugin upgrade AWS Java SDK Plugin upgrade AWS Credentials Plugin upgrade Docket Commons Plugin add support to proxy configuration change deprecated annotations change deprecated annotations improve log improve log improve performance on getDescription there was a call to getCredentials that consumes too much time and it is not need improve log in FINEST and ALL levels Update pom.xml

          Ivan Fernandez Calvo added a comment -

          released on 1.5 version

          Ivan Fernandez Calvo added a comment - released on 1.5 version

            ifernandezcalvo Ivan Fernandez Calvo
            wallmarc Marcus Wallin
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: