Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34628

Jenkins core contains dependencies with external static resources

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • jenkins-2.0+

      There are dependencies with external resources in runtime. You can find an example like this:

      <?jelly escape-by-default='true'?>
      <l:html norefresh="true" title="${it.displayName}" xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
        <l:main-panel>
          <style type="text/css">
            @import url(https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css);
            @import url(https://fonts.googleapis.com/css?family=Roboto:400,300,500,900,700);
      

      in core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly.

      1. Remove CSS inline in Jelly file if it is possible.
      2. Remove duplicated refereces: here and here

      This does more difficult a real environment without direct internet connection (offline mode).

          [JENKINS-34628] Jenkins core contains dependencies with external static resources

          Manuel Recena Soto created issue -
          Manuel Recena Soto made changes -
          Description New: There are dependencies with external resources in runtime. You can find an example like this:

          {code}
          <?jelly escape-by-default='true'?>
          <l:html norefresh="true" title="${it.displayName}" xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
            <l:main-panel>
              <style type="text/css">
                @import url(https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css);
                @import url(https://fonts.googleapis.com/css?family=Roboto:400,300,500,900,700);
          {code}

          in {{core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly}}.

          # Remove CSS inline in Jelly file if it is possible.
          # Remove duplicated refereces: [here|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly#L7] and [here|https://github.com/jenkinsci/jenkins/blob/master/war/src/main/less/pluginSetupWizard.less#L1]

          Manuel Recena Soto made changes -
          Description Original: There are dependencies with external resources in runtime. You can find an example like this:

          {code}
          <?jelly escape-by-default='true'?>
          <l:html norefresh="true" title="${it.displayName}" xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
            <l:main-panel>
              <style type="text/css">
                @import url(https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css);
                @import url(https://fonts.googleapis.com/css?family=Roboto:400,300,500,900,700);
          {code}

          in {{core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly}}.

          # Remove CSS inline in Jelly file if it is possible.
          # Remove duplicated refereces: [here|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly#L7] and [here|https://github.com/jenkinsci/jenkins/blob/master/war/src/main/less/pluginSetupWizard.less#L1]

          New: There are dependencies with external resources in runtime. You can find an example like this:

          {code}
          <?jelly escape-by-default='true'?>
          <l:html norefresh="true" title="${it.displayName}" xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
            <l:main-panel>
              <style type="text/css">
                @import url(https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css);
                @import url(https://fonts.googleapis.com/css?family=Roboto:400,300,500,900,700);
          {code}

          in {{core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly}}.

          # Remove CSS inline in Jelly file if it is possible.
          # Remove duplicated refereces: [here|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly#L7] and [here|https://github.com/jenkinsci/jenkins/blob/master/war/src/main/less/pluginSetupWizard.less#L1]

          This does more difficult a real environment without direct internet connection (offline mode).

          kzantow What do you think?

          Manuel Recena Soto added a comment - kzantow What do you think?
          Manuel Recena Soto made changes -
          Issue Type Original: Bug [ 1 ] New: Task [ 3 ]
          Manuel Recena Soto made changes -
          Summary Original: Remove external static resources New: Remove dependencies with external static resources

          Daniel Beck added a comment -

          Agree, we shouldn't do this. Jenkins must be able to work equally well offline (there could be update sites on the local network, which make internet access for even that unnecessary).

          Daniel Beck added a comment - Agree, we shouldn't do this. Jenkins must be able to work equally well offline (there could be update sites on the local network, which make internet access for even that unnecessary).
          Manuel Recena Soto made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Manuel Recena Soto made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 14277 ]

          Oleg Nenashev added a comment -

          I vote for converting it to a Bug. Just in case the fix misses the 2.x LTS baseline and we need to backport it

          Oleg Nenashev added a comment - I vote for converting it to a Bug. Just in case the fix misses the 2.x LTS baseline and we need to backport it

            recena Manuel Recena Soto
            recena Manuel Recena Soto
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: