Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34675

PluginSetupWizard hangs if the default update site is not resolvable

    XMLWordPrintable

Details

    Description

      If the 'default' UpdateSite ID cannot be resolved due to whatever reason, Jenkins Installation wizard hangs infinitely.

      As a solution, I propose to return a fatal error to the WebUI.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-39637 How to remove jsessionid on the url when logging in

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-34674 Support configurable Default Update center IDs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-39637 How to remove jsessionid on the url when logging in

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-34674 [ JENKINS-34674 ]
            danielbeck Daniel Beck added a comment -

            What specifically does 'cannot be resolved' mean? Network issue? Or there is no such configured update site?

            danielbeck Daniel Beck added a comment - What specifically does 'cannot be resolved' mean? Network issue? Or there is no such configured update site?
            oleg_nenashev Oleg Nenashev added a comment -

            danielbeck
            It's a follow-up to JENKINS-34674, which may expose the code issue heavily. If the requested UpdateSite ID is not resolvable (e.g. no JENKINS_HOME/updates/UPDATESITE_ID.json), the current logic does not handle it effectively.

            PR: https://github.com/jenkinsci/jenkins/pull/2319

            oleg_nenashev Oleg Nenashev added a comment - danielbeck It's a follow-up to JENKINS-34674 , which may expose the code issue heavily. If the requested UpdateSite ID is not resolvable (e.g. no JENKINS_HOME/updates/UPDATESITE_ID.json), the current logic does not handle it effectively. PR: https://github.com/jenkinsci/jenkins/pull/2319
            oleg_nenashev Oleg Nenashev made changes -
            Labels installation ui
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/UpdateCenter.java
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/util/jenkins.js
            http://jenkins-ci.org/commit/jenkins/5d1f81c56c9635ec53dce2b60563047837361251
            Log:
            [FIXED JENKINS-34675] - Prevent hanging of the WebUI if the default Update Site ID cannot be resolved.

            Also hardens the Java code a bit.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/UpdateCenter.java war/src/main/js/pluginSetupWizardGui.js war/src/main/js/util/jenkins.js http://jenkins-ci.org/commit/jenkins/5d1f81c56c9635ec53dce2b60563047837361251 Log: [FIXED JENKINS-34675] - Prevent hanging of the WebUI if the default Update Site ID cannot be resolved. Also hardens the Java code a bit.
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            test/src/test/java/hudson/model/UpdateCenterConnectionStatusTest.java
            http://jenkins-ci.org/commit/jenkins/25f6c2cf6d771668fe1caae1c11c82a2b80284e7
            Log:
            JENKINS-34675 - Fix the Unit test

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: test/src/test/java/hudson/model/UpdateCenterConnectionStatusTest.java http://jenkins-ci.org/commit/jenkins/25f6c2cf6d771668fe1caae1c11c82a2b80284e7 Log: JENKINS-34675 - Fix the Unit test
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/UpdateCenter.java
            test/src/test/java/hudson/model/UpdateCenterConnectionStatusTest.java
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/util/jenkins.js
            http://jenkins-ci.org/commit/jenkins/0b3dbfce64a3cae69e96beb6f7a437db587e401a
            Log:
            Merge pull request #2319 from oleg-nenashev/JENKINS-34674

            [JENKINS-34674,JENKINS-34675] - Handling of the default update site ID

            Compare: https://github.com/jenkinsci/jenkins/compare/b9bb52ffce51...0b3dbfce64a3

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/UpdateCenter.java test/src/test/java/hudson/model/UpdateCenterConnectionStatusTest.java war/src/main/js/pluginSetupWizardGui.js war/src/main/js/util/jenkins.js http://jenkins-ci.org/commit/jenkins/0b3dbfce64a3cae69e96beb6f7a437db587e401a Log: Merge pull request #2319 from oleg-nenashev/ JENKINS-34674 [JENKINS-34674,JENKINS-34675] - Handling of the default update site ID Compare: https://github.com/jenkinsci/jenkins/compare/b9bb52ffce51...0b3dbfce64a3
            oleg_nenashev Oleg Nenashev made changes -
            Labels installation ui installation lts-candidate ui
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev added a comment -

            released in jenkins-2.4

            oleg_nenashev Oleg Nenashev added a comment - released in jenkins-2.4
            olivergondza Oliver Gondža added a comment -

            The feature is missing in pre-2.0 LTS so rejecting for now.

            olivergondza Oliver Gondža added a comment - The feature is missing in pre-2.0 LTS so rejecting for now.
            olivergondza Oliver Gondža made changes -
            Labels installation lts-candidate ui 1.651.3-rejected installation lts-candidate ui
            olivergondza Oliver Gondža made changes -
            Labels 1.651.3-rejected installation lts-candidate ui 1.651.3-rejected installation ui
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170850 ] JNJira + In-Review [ 198956 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is related to JENKINS-39637 [ JENKINS-39637 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is duplicated by JENKINS-39637 [ JENKINS-39637 ]

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: