Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34676

Duplicate include of pluginSetupWizard.js

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      During fixing of JENKINS-34669 I've discovered that Jenkins 2.1 bundles the obsolete version of jenkins-js-builder. The last release version is 0.0.51, but Jenkins core still bundles 0.0.40. It means the core does not get patches like this one: https://github.com/tfennelly/jenkins-js-modules/commit/dd98ceefcc28861b11272214aeb9bc32a3aaae62

      This fix is required to prevent fatal failures on module duplicates

      Background

      We have a plugin, which tweaks Jenkins UI before the startup in order to initialize some stuff (add extra plugins, etc.). So the plugin has an additional UI page. When I bundle this plugin into Jenkins.war, Jenkins 2.0 installation Wizard hangs infinitely.
      
      According to the JS debugger, it happens due to the ""Jenkins global module 'pluginSetupWizard' already registered." error. There are stacktraces for the first and second export operations.
      
      Jenkins WebUI should at least return an error for such failures. Ideally it should be robust agains such "hacks in plugins"
      

        Attachments

        1. firstCall.png
          firstCall.png
          305 kB
        2. hangingInstallationWizard.png
          hangingInstallationWizard.png
          137 kB
        3. secondCall.png
          secondCall.png
          278 kB

          Issue Links

            Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Labels jenkins2.0 regression
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Remote Link This issue links to "jenkins/pull/2320 (Web Link)" [ 14279 ]
            oleg_nenashev Oleg Nenashev made changes -
            Description We have a plugin, which tweaks Jenkins UI before the startup in order to initialize some stuff (add extra plugins, etc.). So the plugin has an additional UI page. When I bundle this plugin into Jenkins.war, Jenkins 2.0 installation Wizard hangs infinitely.

            According to the JS debugger, it happens due to the ""Jenkins global module 'pluginSetupWizard' already registered." error. There are stacktraces for the first and second export operations.

            Jenkins WebUI should at least return an error for such failures. Ideally it should be robust agains such "hacks in plugins"
            During fixing of JENKINS-34669 I've discovered that Jenkins 2.1 bundles the obsolete version of jenkins-js-builder. The last release version is 0.0.51, but Jenkins core still bundles 0.0.40. It means the core does not get patches like this one: https://github.com/tfennelly/jenkins-js-modules/commit/dd98ceefcc28861b11272214aeb9bc32a3aaae62

            This fix is required to prevent fatal failures on module duplicates

            Background
            {noformat}
            We have a plugin, which tweaks Jenkins UI before the startup in order to initialize some stuff (add extra plugins, etc.). So the plugin has an additional UI page. When I bundle this plugin into Jenkins.war, Jenkins 2.0 installation Wizard hangs infinitely.

            According to the JS debugger, it happens due to the ""Jenkins global module 'pluginSetupWizard' already registered." error. There are stacktraces for the first and second export operations.

            Jenkins WebUI should at least return an error for such failures. Ideally it should be robust agains such "hacks in plugins"
            {noformat}
            oleg_nenashev Oleg Nenashev made changes -
            Summary Conflict with a plugin causes hanging of the Jenkins 2 installation Wizard Outdated version of js-modules causes loading issues on JS module conflicts
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is related to JENKINS-34669 [ JENKINS-34669 ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            recena Manuel Recena Soto made changes -
            Assignee Manuel Jesús Recena Soto [ recena ]
            recena Manuel Recena Soto made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            recena Manuel Recena Soto made changes -
            Link This issue duplicates JENKINS-34668 [ JENKINS-34668 ]
            recena Manuel Recena Soto made changes -
            Resolution Duplicate [ 3 ]
            Status Open [ 1 ] Closed [ 6 ]
            recena Manuel Recena Soto made changes -
            Resolution Duplicate [ 3 ]
            Status Closed [ 6 ] Reopened [ 4 ]
            recena Manuel Recena Soto made changes -
            Link This issue duplicates JENKINS-34668 [ JENKINS-34668 ]
            kzantow Keith Zantow made changes -
            Summary Outdated version of js-modules causes loading issues on JS module conflicts Duplicate include of pluginSetupWizard.js
            kzantow Keith Zantow made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]
            kzantow Keith Zantow made changes -
            Link This issue is related to JENKINS-34990 [ JENKINS-34990 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170851 ] JNJira + In-Review [ 198957 ]

              People

              Assignee:
              recena Manuel Recena Soto
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: