[JENKINS-34722] Unbounded searches with BuildUtil.getDownstreamBuild - Jenkins Jira

XML

Word

Printable

Details

Type: Improvement
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: build-pipeline-plugin
Labels:
None

Similar Issues:

Show

Description

BuildUtil.getDownstreamBuild does an unbounded search of build records, which is never acceptable due to Jenkins lazy-loading, and particular not in the context of an HTTP handler thread.

It would be better is to use AbstractBuild.getDownstreamBuilds(AbstractProject), which is efficient, though it only works for project chains which are correctly configured with fingerprints.

Example:

"Handling GET /jenkins/org/job/Pipelines/job/org-build/view/Pipelines_View/ from 10.x.x.x : RequestHandlerThread[#2296] View/index.jelly" Id=126293 BLOCKED on hudson.model.RunMap@607d5beb owned by "Handling GET /jenkins/org/job/Pipelines/job/org-build/ from 10.x.x.x : RequestHandlerThread[#2297] View/index.jelly" Id=126471
    at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java)
    -  blocked on hudson.model.RunMap@607d5beb
    at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:448)
    at jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:356)
    at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:332)
    at jenkins.model.lazy.LazyLoadRunMapEntrySet$1.next(LazyLoadRunMapEntrySet.java:74)
    at jenkins.model.lazy.LazyLoadRunMapEntrySet$1.next(LazyLoadRunMapEntrySet.java:63)
    at java.util.AbstractMap$2$1.next(AbstractMap.java:396)
    at au.com.centrumsystems.hudson.plugin.util.BuildUtil.getDownstreamBuild(BuildUtil.java:66)

Attachments

Issue Links

links to

PR 100

Activity

Ascending order - Click to sort in descending order

View 9 older comments

Sean McIntyre added a comment - 2016-11-17 16:03

Hi there,

I wanted to chime in and let everyone know we are having a similar issue with our Jenkins setup using the Pipeline plug-in. Each page load in Jenkins was approaching 11s, which is unacceptable for our CI pipeline and causing friction on our team.

I found that this was the issue by sampling the Java stack every second during a GET request, here are the results in a gist. I saw the common denominator of each sample was the BuildUtil.getDownstreamBuild, and found this ticket.

We have 7 pipelines in our installation, each having about 6 jobs, and most of those jobs having 1-3K builds in their histories. I purged the histories of these pipelines, reducing their histories to about 300 each (total 60K -> 17K), and Jenkins pageloads are now 2s. I had to do a Jenkins restart after the purges.

We are running Build Pipeline Plugin 1.5.4 and Jenkins 2.30.

Thanks!

Sean McIntyre added a comment - 2016-11-17 16:03 Hi there, I wanted to chime in and let everyone know we are having a similar issue with our Jenkins setup using the Pipeline plug-in. Each page load in Jenkins was approaching 11s, which is unacceptable for our CI pipeline and causing friction on our team. I found that this was the issue by sampling the Java stack every second during a GET request, here are the results in a gist . I saw the common denominator of each sample was the BuildUtil.getDownstreamBuild , and found this ticket. We have 7 pipelines in our installation, each having about 6 jobs, and most of those jobs having 1-3K builds in their histories. I purged the histories of these pipelines, reducing their histories to about 300 each (total 60K -> 17K), and Jenkins pageloads are now 2s. I had to do a Jenkins restart after the purges. We are running Build Pipeline Plugin 1.5.4 and Jenkins 2.30. Thanks!

Dan Alvizu added a comment - 2016-12-08 22:57

Fixed in 1.5.6

Dan Alvizu added a comment - 2016-12-08 22:57 Fixed in 1.5.6

Dan Alvizu added a comment - 2016-12-09 21:49

1.5.6 included this fix:
https://github.com/jenkinsci/build-pipeline-plugin/pull/88

Dan Alvizu added a comment - 2016-12-09 21:49 1.5.6 included this fix: https://github.com/jenkinsci/build-pipeline-plugin/pull/88

Sean McIntyre added a comment - 2016-12-12 17:06

Great, dalvizu. Our Jenkins page load times fell from 2s to 20ms with the upgrade to 1.5.6.

Sean McIntyre added a comment - 2016-12-12 17:06 Great, dalvizu . Our Jenkins page load times fell from 2s to 20ms with the upgrade to 1.5.6.

Dan Alvizu added a comment - 2016-12-12 17:08

good to hear, all credit to jpederzolli

Dan Alvizu added a comment - 2016-12-12 17:08 good to hear, all credit to jpederzolli