[JENKINS-34751] StackOverflowError in Groovy scripts - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core, groovy-plugin, job-dsl-plugin, pipeline
Labels:
- 2.7.1-fixed
- regression
Environment:
Jenkins 2.0

Similar Issues:

Show

Description

Due to a regression in Groovy 2.4 (GROOVY-7826) scripts using some of the core classes with complex generic type arguments (e.g. hudson.model.Run or hudson.model.Job) will cause a StackoverflowError.

Run this script in Script Console to reproduce the problem:

def foo(hudson.model.Run run) {}

This affects Script Console, Pipeline, Job DSL, Groovy plugin (system Groovy script) and probably other plugins using the Groovy runtime provided by Jenkins core.

java.lang.StackOverflowError
	at java.lang.StringBuilder.append(StringBuilder.java:132)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1173)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1159)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1178)
	at org.codehaus.groovy.ast.ClassNode.genericTypeAsString(ClassNode.java:1199)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1173)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1159)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1178)
	at org.codehaus.groovy.ast.ClassNode.genericTypeAsString(ClassNode.java:1199)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1173)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1159)
	at org.codehaus.groovy.ast.ClassNode.toString(ClassNode.java:1178)
	at org.codehaus.groovy.ast.ClassNode.genericTypeAsString(ClassNode.java:1199)
        ...

Attachments

Issue Links

is duplicated by

JENKINS-34765 "All Changes" returning stack overflow

Resolved

is related to

JENKINS-14044 System Groovy - Unable to cast to AbstractBuild

Open

JENKINS-34525 StackOverflowError in Jenkins 2.0 with Simple Parameterized Builds Report

Closed

JENKINS-21249 Update Groovy

Resolved

Activity

Ascending order - Click to sort in descending order

Daniel Spilker created issue - 2016-05-12 07:42

Daniel Spilker made changes - 2016-05-12 07:43

Field	Original Value	New Value
Link		This issue is related to ~~JENKINS-34525~~ [ ~~JENKINS-34525~~ ]

Daniel Spilker made changes - 2016-05-12 07:44

Link

This issue is related to ~~JENKINS-21249~~ [ ~~JENKINS-21249~~ ]

Hide

Permalink

Daniel Spilker added a comment - 2016-05-12 11:55

Here is a fix for Groovy: https://github.com/apache/groovy/pull/333

Show

Daniel Spilker added a comment - 2016-05-12 11:55 Here is a fix for Groovy: https://github.com/apache/groovy/pull/333

Hide

Permalink

John Wynne added a comment - 2016-05-19 16:45 - edited

I can see a fix included in groovy 2.4.7 but there is no planned release for it.
Will we have to wait for groovy to release and then for jenkins to consume it before we see this fixed? If so, I'll need to downgrade from 2.x sharpish
https://issues.apache.org/jira/browse/GROOVY/fixforversion/12334898/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-summary-panel

Alternatively, Daniel Spilker are there instructions for pulling that fix on github that you've posted into my jenkins installation?

Show

John Wynne added a comment - 2016-05-19 16:45 - edited I can see a fix included in groovy 2.4.7 but there is no planned release for it. Will we have to wait for groovy to release and then for jenkins to consume it before we see this fixed? If so, I'll need to downgrade from 2.x sharpish https://issues.apache.org/jira/browse/GROOVY/fixforversion/12334898/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-summary-panel Alternatively, Daniel Spilker are there instructions for pulling that fix on github that you've posted into my jenkins installation?

Hide

Permalink

Daniel Spilker added a comment - 2016-05-19 16:55

I hope to get a Groovy 2.4.x release for the first 2.x LTS release, which will come in a few weeks.

John Wynne you can pull the GROOVY_2_4_X branch from GitHub (https://github.com/apache/groovy/tree/GROOVY_2_4_X), run the build (instructions are in the README) and then replace the Groovy JAR in your Jenkins installation (e.g. in /var/cache/jenkins/war/WEB-INF/lib) with the JAR from the build (in target/libs).

Show

Daniel Spilker added a comment - 2016-05-19 16:55 I hope to get a Groovy 2.4.x release for the first 2.x LTS release, which will come in a few weeks. John Wynne you can pull the GROOVY_2_4_X branch from GitHub ( https://github.com/apache/groovy/tree/GROOVY_2_4_X ), run the build (instructions are in the README) and then replace the Groovy JAR in your Jenkins installation (e.g. in /var/cache/jenkins/war/WEB-INF/lib) with the JAR from the build (in target/libs).

Hide

Permalink

Daniel Beck added a comment - 2016-05-19 18:02

Daniel Spilker While we release 2.x.1 LTS on July 6, we decide the baseline on June 8 and the version we choose is typically 3-4 weeks old. I.e. now.

If this is supposed to be fixed for 2.x.1 LTS in July, we need to go the patched Groovy route again, and quickly.

Show

Daniel Beck added a comment - 2016-05-19 18:02 Daniel Spilker While we release 2.x.1 LTS on July 6, we decide the baseline on June 8 and the version we choose is typically 3-4 weeks old. I.e. now. If this is supposed to be fixed for 2.x.1 LTS in July, we need to go the patched Groovy route again, and quickly.

Hide

Permalink

Daniel Spilker added a comment - 2016-05-19 18:33

Daniel Beck Arg. I will ask on the Groovy dev list. The last 2.4 release is 3 month old, so it should be time to cut a release.

Show

Daniel Spilker added a comment - 2016-05-19 18:33 Daniel Beck Arg. I will ask on the Groovy dev list. The last 2.4 release is 3 month old, so it should be time to cut a release.

Jesse Glick made changes - 2016-05-19 18:43

Link

This issue is related to JENKINS-14044 [ JENKINS-14044 ]

Jesse Glick made changes - 2016-05-19 18:44

Link

This issue is duplicated by ~~JENKINS-34765~~ [ ~~JENKINS-34765~~ ]

Daniel Spilker made changes - 2016-05-20 08:57

Assignee

vjuranek [ vjuranek ]

Daniel Spilker [ daspilker ]

Daniel Beck made changes - 2016-05-24 10:58

Labels

regression

lts-candidate regression

Hide

Permalink

SCM/JIRA link daemon added a comment - 2016-05-28 07:26

Code changed in jenkins
User: Daniel Spilker
Path:
core/pom.xml
http://jenkins-ci.org/commit/jenkins/a3ddc89afe27a52554a79ff9e6d1b2ec714f96cd
Log:
~~JENKINS-34751~~ use patched version of Groovy 2.4.6 (#2369)

contains fixes for GROOVY-7761 and GROOVY-7826

[FIXES JENKINS-34751]

Show

SCM/JIRA link daemon added a comment - 2016-05-28 07:26 Code changed in jenkins User: Daniel Spilker Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/a3ddc89afe27a52554a79ff9e6d1b2ec714f96cd Log: JENKINS-34751 use patched version of Groovy 2.4.6 (#2369) contains fixes for GROOVY-7761 and GROOVY-7826 [FIXES JENKINS-34751]

Hide

Permalink

Oleg Nenashev added a comment - 2016-06-06 08:06

The fix has been released in jenkins-2.7
Now we need to upgrade to 2.4.7 once it gets released

Show

Oleg Nenashev added a comment - 2016-06-06 08:06 The fix has been released in jenkins-2.7 Now we need to upgrade to 2.4.7 once it gets released

Oleg Nenashev made changes - 2016-06-06 08:06

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Hide

Permalink

Daniel Spilker added a comment - 2016-06-07 20:22

Follow-up PR to update to Groovy 2.4.7: https://github.com/jenkinsci/jenkins/pull/2399

Show

Daniel Spilker added a comment - 2016-06-07 20:22 Follow-up PR to update to Groovy 2.4.7: https://github.com/jenkinsci/jenkins/pull/2399

Hide

Permalink

SCM/JIRA link daemon added a comment - 2016-06-08 18:42

Code changed in jenkins
User: Daniel Spilker
Path:
core/pom.xml
http://jenkins-ci.org/commit/jenkins/96a782853eb006d76eb8eb2aad68d3046a5f9756
Log:
updated Groovy to 2.4.7

follow-up for ~~JENKINS-34751~~

Show

SCM/JIRA link daemon added a comment - 2016-06-08 18:42 Code changed in jenkins User: Daniel Spilker Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/96a782853eb006d76eb8eb2aad68d3046a5f9756 Log: updated Groovy to 2.4.7 follow-up for JENKINS-34751

Hide

Permalink

SCM/JIRA link daemon added a comment - 2016-06-08 18:42

Code changed in jenkins
User: Oliver Gondža
Path:
core/pom.xml
http://jenkins-ci.org/commit/jenkins/057791ca34c8f85080ca1f4957843fb7c72b615b
Log:
Merge pull request #2399 from daspilker/~~JENKINS-34751~~

~~JENKINS-34751~~ updated Groovy to 2.4.7

Compare: https://github.com/jenkinsci/jenkins/compare/f1dfc7207fc3...057791ca34c8

Show

SCM/JIRA link daemon added a comment - 2016-06-08 18:42 Code changed in jenkins User: Oliver Gondža Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/057791ca34c8f85080ca1f4957843fb7c72b615b Log: Merge pull request #2399 from daspilker/ JENKINS-34751 JENKINS-34751 updated Groovy to 2.4.7 Compare: https://github.com/jenkinsci/jenkins/compare/f1dfc7207fc3...057791ca34c8

Hide

Permalink

Oliver Gondža added a comment - 2016-06-20 08:56

Backporting bump to 2.4.7 into 2.7.1 not to depend on forked build.

Show

Oliver Gondža added a comment - 2016-06-20 08:56 Backporting bump to 2.4.7 into 2.7.1 not to depend on forked build.

Oliver Gondža made changes - 2016-06-20 08:58

Labels

lts-candidate regression

2.7.1-fixed regression

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

JNJira [ 170933 ]

JNJira + In-Review [ 198987 ]

Daniel Spilker made changes - 2016-08-16 07:52

Status

Resolved [ 5 ]

Closed [ 6 ]

Andrew Bayer made changes - 2016-08-26 21:50

Component/s

pipeline-general [ 21692 ]

Andrew Bayer made changes - 2016-08-26 21:54

Component/s

workflow-plugin [ 18820 ]

People

Assignee:: Daniel Spilker

Reporter:: Daniel Spilker

Votes:: 2 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 2016-05-12 07:42

Updated:: 2016-08-26 21:54

Resolved:: 2016-06-06 08:06