Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34808

Allow user to adjust socket timeout

    XMLWordPrintable

Details

    Description

      Follow-up to https://github.com/jenkinsci/remoting/pull/68

      > we encounter slave offline issue when executing commands like "sleep 40m"
      on jnlp agent, the socket read timeout is hard coded to 30 minutes and caused the issue

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-22722 Master doesn't show connected slave

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            oleg_nenashev Oleg Nenashev created issue -
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/jenkins/409438f36dc80f20964fb16f8d88041e11ba4ed4
            Log:
            [JENKINS-19445, JENKINS-34213, JENKINS-34808, JENKINS-34121] Bump remoting to 2.59. (#2344)

            • [JENKINS-19445, JENKINS-34213, JENKINS-34808] Bump remoting to 2.58.

            Changes:

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/409438f36dc80f20964fb16f8d88041e11ba4ed4 Log: [JENKINS-19445, JENKINS-34213, JENKINS-34808, JENKINS-34121] Bump remoting to 2.59. (#2344) [JENKINS-19445, JENKINS-34213, JENKINS-34808] Bump remoting to 2.58. Changes: JENKINS-34213 ( https://issues.jenkins-ci.org/browse/JENKINS-34213 ) - Ensure that the unexporter cleans up whatever it can each sweep ( https://github.com/jenkinsci/remoting/pull/81 ) JENKINS-19445 ( https://issues.jenkins-ci.org/browse/JENKINS-19445 ) Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion ( https://github.com/jenkinsci/remoting/pull/81 ) JENKINS-34808 ( https://issues.jenkins-ci.org/browse/JENKINS-34808 ) - Allow user to adjust socket timeout ( https://github.com/jenkinsci/remoting/pull/68 ) JENKINS-34121 - Upgrade remoting to 2.59
            oleg_nenashev Oleg Nenashev added a comment -

            released in remoting 2.58 and jenkins-2.4

            oleg_nenashev Oleg Nenashev added a comment - released in remoting 2.58 and jenkins-2.4
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Assignee Oleg Nenashev [ oleg_nenashev ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/jenkins/12e79963cca5122351943ee107f65c3ad91a2e25
            Log:
            [JENKINS-19445, JENKINS-34213, JENKINS-34808, JENKINS-34121] Bump remoting to 2.59. (#2344)

            • [JENKINS-19445, JENKINS-34213, JENKINS-34808] Bump remoting to 2.58.

            Changes:

            (cherry picked from commit 409438f36dc80f20964fb16f8d88041e11ba4ed4)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/12e79963cca5122351943ee107f65c3ad91a2e25 Log: [JENKINS-19445, JENKINS-34213, JENKINS-34808, JENKINS-34121] Bump remoting to 2.59. (#2344) [JENKINS-19445, JENKINS-34213, JENKINS-34808] Bump remoting to 2.58. Changes: JENKINS-34213 ( https://issues.jenkins-ci.org/browse/JENKINS-34213 ) - Ensure that the unexporter cleans up whatever it can each sweep ( https://github.com/jenkinsci/remoting/pull/81 ) JENKINS-19445 ( https://issues.jenkins-ci.org/browse/JENKINS-19445 ) Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion ( https://github.com/jenkinsci/remoting/pull/81 ) JENKINS-34808 ( https://issues.jenkins-ci.org/browse/JENKINS-34808 ) - Allow user to adjust socket timeout ( https://github.com/jenkinsci/remoting/pull/68 ) JENKINS-34121 - Upgrade remoting to 2.59 (cherry picked from commit 409438f36dc80f20964fb16f8d88041e11ba4ed4)
            olivergondza Oliver Gondža made changes -
            Labels 1.651.3-fixed
            teilo James Nord added a comment -

            I beleive this was the wrong fix.

            A SocketTimeoutException is a non fatal exception.

            As per the javacoc

            Enable/disable SO_TIMEOUT with the specified timeout, in milliseconds. With this option set to a non-zero timeout, a read() call on the InputStream associated with this Socket will block for only this amount of time. If the timeout expires, a java.net.SocketTimeoutException is raised, though the Socket is still valid. The option must be enabled prior to entering the blocking operation to have effect. The timeout must be > 0. A timeout of zero is interpreted as an infinite timeout.

            the code should be handling SocketTimeoutException and retrying. blindly changing the timeout is just going to punt the issue until someone does nothing for longer still. The only thing that timeouts out that should cause a connection close is a Ping timeout.

            teilo James Nord added a comment - I beleive this was the wrong fix. A SocketTimeoutException is a non fatal exception. As per the javacoc Enable/disable SO_TIMEOUT with the specified timeout, in milliseconds. With this option set to a non-zero timeout, a read() call on the InputStream associated with this Socket will block for only this amount of time. If the timeout expires, a java.net.SocketTimeoutException is raised, though the Socket is still valid . The option must be enabled prior to entering the blocking operation to have effect. The timeout must be > 0. A timeout of zero is interpreted as an infinite timeout. the code should be handling SocketTimeoutException and retrying. blindly changing the timeout is just going to punt the issue until someone does nothing for longer still. The only thing that timeouts out that should cause a connection close is a Ping timeout.
            teilo James Nord made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            oleg_nenashev Oleg Nenashev added a comment -

            teilo This PR fixed what has been requested. So it's perfectly valid.
            But I agree that Channel reader thread should not fail on SocketTimeoutException. I am working on a fix for it

            oleg_nenashev Oleg Nenashev added a comment - teilo This PR fixed what has been requested. So it's perfectly valid. But I agree that Channel reader thread should not fail on SocketTimeoutException. I am working on a fix for it
            teilo James Nord added a comment -

            oleg_nenashev well it fixes the symptom not the underlying cause - so it's valid - but not perfectly valid

            Do you want me to create a new "Channel reader thread should not fail on SocketTimeoutException" ticket?

            teilo James Nord added a comment - oleg_nenashev well it fixes the symptom not the underlying cause - so it's valid - but not perfectly valid Do you want me to create a new "Channel reader thread should not fail on SocketTimeoutException" ticket?
            oleg_nenashev Oleg Nenashev added a comment -

            I have a template for it, but I still have to fill in all fields

            oleg_nenashev Oleg Nenashev added a comment - I have a template for it, but I still have to fill in all fields
            oleg_nenashev Oleg Nenashev added a comment -

            teilo I'm fixing the Socket timeout exception as a part of JENKINS-22722

            oleg_nenashev Oleg Nenashev added a comment - teilo I'm fixing the Socket timeout exception as a part of JENKINS-22722
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is related to JENKINS-22722 [ JENKINS-22722 ]
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170999 ] JNJira + In-Review [ 199003 ]

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: