Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34835

GitHub team should be referenced by slug not name

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • github-oauth-plugin
    • None
    • 0.24
    • 0.35

      The GitHub OAuth plugin adds a user's organizations and teams as Jenkins groups when authenticating through GItHub.

      The pattern for teams is: organization.login*team.name

      Instead of team.name, Jenkins should store the group name as team.slug. Team slugs are unique per organization and are more URL path / script friendly.

      Reference: https://developer.github.com/v3/orgs/teams/#list-teams

          [JENKINS-34835] GitHub team should be referenced by slug not name

          Andy Pemberton created issue -
          Andy Pemberton made changes -
          Assignee Original: Sam Gleske [ sag47 ] New: Andy Pemberton [ apemberton ]
          Sam Gleske made changes -
          Link New: This issue is related to JENKINS-34896 [ JENKINS-34896 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 171026 ] New: JNJira + In-Review [ 184133 ]

          Sam Gleske added a comment -

          Andy, have you had a chance to look at this further?

          Sam Gleske added a comment - Andy, have you had a chance to look at this further?

          Andy Pemberton added a comment -

          Hey sag47: I haven't, though it does appear the required PR was merged in the github-api project: https://github.com/kohsuke/github-api/pull/281, so should be an easy fix from here.

          Andy Pemberton added a comment - Hey sag47 : I haven't, though it does appear the required PR was merged in the github-api project: https://github.com/kohsuke/github-api/pull/281 , so should be an easy fix from here.
          Sam Gleske made changes -
          Issue Type Original: Improvement [ 4 ] New: Bug [ 1 ]
          Sam Gleske made changes -
          Assignee Original: Andy Pemberton [ apemberton ] New: Sam Gleske [ sag47 ]

          Sam Gleske added a comment -

          Fix in github-auth plugin https://github.com/jenkinsci/github-oauth-plugin/pull/116

          Sam Gleske added a comment - Fix in github-auth plugin https://github.com/jenkinsci/github-oauth-plugin/pull/116
          Sam Gleske made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            mancuniansam Sam Palmer
            apemberton Andy Pemberton
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: