• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: gerrit-trigger-plugin
• Labels:

  • gerrit-trigger
• Environment:

  Ubuntu, Jenkins 1.595, gerrit-trigger-plugin 2.20.0, gerrit 2.11.2

[JENKINS-34869] 'exclude trivial rebase' check box does not affects.

Aleksey LastName created issue - 2016-05-17 07:39

Collapse comment: Aleksey LastName added a comment - 2016-05-17 08:23, Edited by Aleksey LastName - 2016-05-17 08:29

Aleksey LastName added a comment - 2016-05-17 08:23 - edited

I figure out why it does so:
Gerrit 2.10 has Kind of change uploaded:
REWORK,
TRIVIAL_REBASE,
NO_CODE_CHANGE,

Gerrit 2.11:
REWORK
Nontrivial content changes.

TRIVIAL_REBASE
Conflict-free merge between the new parent and the prior patch set.

NO_CODE_CHANGE
No code changed; same tree and same parent tree.

NO_CHANGE
No changes; same commit message, same tree and same parent tree.

So, when we do some kind of trivial rebase (rebase some change in chain-changes after a patch set of some change in the chain was chanded) in Gerrit 2.11 we get kind:NO_CHANGE

Will you do update for Gerrit >2.10 ?

Expand comment: Aleksey LastName added a comment - 2016-05-17 08:23, Edited by Aleksey LastName - 2016-05-17 08:29

Aleksey LastName added a comment - 2016-05-17 08:23 - edited I figure out why it does so: Gerrit 2.10 has Kind of change uploaded: REWORK, TRIVIAL_REBASE, NO_CODE_CHANGE, Gerrit 2.11 : REWORK Nontrivial content changes. TRIVIAL_REBASE Conflict-free merge between the new parent and the prior patch set. NO_CODE_CHANGE No code changed; same tree and same parent tree. NO_CHANGE No changes; same commit message, same tree and same parent tree. So, when we do some kind of trivial rebase (rebase some change in chain-changes after a patch set of some change in the chain was chanded) in Gerrit 2.11 we get kind:NO_CHANGE Will you do update for Gerrit >2.10 ?

Aleksey LastName made changes - 2016-05-17 08:29

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Aleksey LastName made changes - 2016-05-17 08:29

Status

Original: In Progress [ 3 ]

New: Open [ 1 ]

R. Tyler Croy made changes - 2016-07-25 23:52

Workflow

Original: JNJira [ 171069 ]

New: JNJira + In-Review [ 184149 ]